Commit 0cd13ce
trees_gene_groups/gene_groups-COPYME STEP_3: fix newick-existence false-skip
gene_groups-COPYME's STEP_3 orchestrator was using
ls "${NEWICK_DIR}"/*.fasttree "${NEWICK_DIR}"/*.treefile \
"${NEWICK_DIR}"/*.veryfasttree "${NEWICK_DIR}"/*.phylobayes.nwk
to test "did STEP_2 produce ANY tree file for this gene group?" — but `ls`
returns exit-2 whenever ANY of the four patterns misses, so a gene group
that legitimately produced only one tree type (e.g. fasttree-only runs from
STEP_2 profile=standard) was silently skipped as "no STEP_2 newicks".
Manifested today as: STEP_3 RUN_1 in gene_groups-hugo_hgnc reported
"Setup: 0 new, 2060 skipped (no STEP_2 newicks)" even though gene_group-
synaptotagmins/ contained a valid .fasttree file at the resolved
STEP2_RUN_DIR path. The check is now:
shopt -s nullglob
NEWICK_FILES=( "${NEWICK_DIR}"/*.fasttree ... )
shopt -u nullglob
(( ${#NEWICK_FILES[@]} == 0 )) && skip
nullglob makes absent patterns expand to nothing; the array union answers
"did anything match across the four extensions". Matches the working
version already in gene_groups_hgnc-COPYME/STEP_3-*/RUN-workflow.sh.
Verified end-to-end by re-running STEP_3 RUN_1 (3 trees) + RUN_2 (1 tree,
2682 tips) in gene_groups-hugo_hgnc — all 4 trees rendered to PDF + SVG.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>1 parent 00dc9c7 commit 0cd13ce
1 file changed
Lines changed: 20 additions & 2 deletions
File tree
- gigantic_project-COPYME/subprojects/trees_gene_groups/gene_groups-COPYME/STEP_3-tree_visualization/workflow-COPYME-tree_visualization
Lines changed: 20 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
233 | 233 | | |
234 | 234 | | |
235 | 235 | | |
236 | | - | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
237 | 243 | | |
238 | | - | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
239 | 257 | | |
240 | 258 | | |
241 | 259 | | |
| |||
0 commit comments