HUD goes off the screen in fullscreen mode on non-16:9 monitors

[TellowKrinkle]

If you fullscreen on a non-16:9 monitor, for example, the (16:10, 2880x1800, though the game treats it as 1440x900) internal display of a MacBook Pro, the main background and text letterboxes as you would expect, however the HUD (part which supplies buttons for quick save, quick load, menu, log, skip, and auto) positions itself as if the game had been zoomed in to fill the display, putting the four right-edge buttons (menu, log, skip, auto) completely offscreen. Watanagashi is the first game I noticed this on (since it's the first game I played patched) but I would guess it also happens on the other games.
Screenshot:

[ItaloKnox]

Since this is a non-standard resolution, it would be hard to reproduce the issue in our end, but if I recall correctly we have received a few issues regarding this and there was a fix for it. @enumag should be able to help you better, I think he has the resources needed in hand.

[enumag]

This can be fixed by tweaking some values in init.txt. The problem is that I no longer have a file that worked well with 16:10 because I've bought 16:9 monitor a year ago or so. I'll try to find it in my backups but I can't promise I will.

[enumag]

Try this and let us know if it works:
https://gist.githubusercontent.com/enumag/9881c28436039928a5bac13bdbe538e3/raw/fdebf05a7184f1d9325a44a03ee19d9b47dcc281/init.txt

Old issue about this problem: 07th-mod/onikakushi#95

[TellowKrinkle]

It does appear to work though it ends up cropping all the backgrounds instead of letterboxing. Resetting the SetScreenAspect call fixes that but messes up the positioning when not fullscreen.

Based on those changes I made a full fix:
I added this function to MOD.Scripts.UI.MODMainUIController:

public void AutoSetWindowPosX(bool fullscreen) {
	float aspectRatio = GameSystem.Instance.AspectRatio;
	if (fullscreen) {
		aspectRatio = Screen.currentResolution.width / (float)Screen.currentResolution.height;
	}
	float differenceFrom43 = aspectRatio - (4f / 3f);
	int adjustment = Mathf.RoundToInt(differenceFrom43 * 375f);
	ADVModeWindowPosX = -adjustment;
	NVLModeWindowPosX = -adjustment;
	NVLADVModeWindowPosX = -adjustment;
	GameSystem.Instance.MainUIController.UpdateGuiPosition(adjustment, 0);
	if (BurikoMemory.Instance.GetGlobalFlag("GADVMode").IntValue() == 1) {
		ADVModeSettingStore();
	} else {
		NVLModeSettingStore();
	}
}

Then I added this to the end of Assets.Scripts.UI.Config.ScreenSwitcherButton.OnClick():

MOD.Scripts.UI.MODMainUIController controller = new MOD.Scripts.UI.MODMainUIController();
controller.AutoSetWindowPosX(fullscreen: IsFullscreen);

And finally, I couldn't figure out how to add a new custom command to the script system so I added this to the end of the OperationSetGuiPosition command (it should probably get its own though):

MODMainUIController mODMainUIController = new MODMainUIController();
mODMainUIController.AutoSetWindowPosX(fullscreen: Screen.fullScreen);

[enumag]

@TellowKrinkle Nice! Does it work with our normal init.txt or is the edited file still necessary?

[TellowKrinkle]

The edited file is no longer necessary though if you do make AutoSetWindowPosX its own command it would need to be run from the init (it should be compatible with any aspect ratio)
Also I just did a bit more testing and it looks like the scaling number should be 384f, not 375f
Finally, I just checked and it looks like due to Screen.currentResolution working differently on Mac vs Windows, this code breaks on Windows. Use this instead for the large function:

public void AutoSetWindowPosX(bool fullscreen) {
	float aspectRatio = GameSystem.Instance.AspectRatio;
	if (fullscreen) {
		if (!Screen.fullScreen || Application.platform == RuntimePlatform.OSXPlayer) {
			aspectRatio = Screen.currentResolution.width / (float)Screen.currentResolution.height;
		} else if (PlayerPrefs.HasKey("fullscreen_width") && PlayerPrefs.HasKey("fullscreen_height")) {
			aspectRatio = PlayerPrefs.GetInt("fullscreen_width") / (float)PlayerPrefs.GetInt("fullscreen_height");
		}
	}
	float differenceFrom43 = aspectRatio - (4f / 3f);
	int adjustment = Mathf.RoundToInt(differenceFrom43 * 384f);
	ADVModeWindowPosX = -adjustment;
	NVLModeWindowPosX = -adjustment;
	NVLADVModeWindowPosX = -adjustment;
	GameSystem.Instance.MainUIController.UpdateGuiPosition(adjustment, 0);
	if (BurikoMemory.Instance.GetGlobalFlag("GADVMode").IntValue() == 1) {
		ADVModeSettingStore();
	} else {
		NVLModeSettingStore();
	}
}

[enumag]

Does the code you added for windows work for mac too or do we really need the if? Also any idea which implementation would work on linux?

[TellowKrinkle]

The added code should work for Mac as well, you could drop the check in the if. The !Screen.fullScreen check is to catch the case where the user fullscreens for the first time, since the PlayerPrefs may not be set yet at that point (and Screen.currentResolution works as expected on Windows as long as the window isn't already fullscreen). If this website is correct, the code (both implementations) might break on linux if you have multiple monitors, though the entire fullscreen system might also be broken there so if someone could test it that would be great.

[vstax]

I can test on Linux with multiple monitors having different resolution and aspect ratios, one 16:10 and other 16:9 (in expand desktop mode). However, I have no idea how you build from that source so a compiled library is appreciated.

[TellowKrinkle]

Ahh yeah here you go Assembly-CSharp.dll.zip

[enumag]

@TellowKrinkle Just to be clear, which chapter is that DLL for?

[TellowKrinkle]

Watanagashi

[vstax]

@TellowKrinkle The fix doesn't work for me on Linux even with single monitor having 2560x1600 resolution. HUD goes off the screen in fullscreen, just like with .dll from the release.

Also, can you please check Onikakushi? The situation there is much more severe on my system (07th-mod/higurashi-assembly#133) with not just UI buttons but everything, including backgrounds being cut.

[TellowKrinkle]

So it doesn't work with a single monitor connected to your computer that's 2560x1600?

Could you run the game with this DLL, go fullscreen at least once, and then open the log (somewhere around ~/.config/unity3d/MangaGamer/Watanagashi Full Game Name/player.log or something like that) and find the lines that say Detected Screen Resolution: ***x*** and Using Resolution ***x*** to set window position and report what it says?
Assembly-CSharp.dll.zip