fix: Strip the unmask directive (#354)

Author: JoviDeCroock

.changeset/fluffy-rabbits-shake.md

@@ -0,0 +1,5 @@
+---
+'@0no-co/graphqlsp': patch
+---
+
+Strip our internal `@_unmask` directive from fragment-definitions when creating hashes for persisted-operations

packages/graphqlsp/src/persisted.ts

@@ -12,6 +12,7 @@ import {
 import { resolveTemplate } from './ast/resolve';
 import {
   FragmentDefinitionNode,
+  Kind,
   parse,
   print,
   visit,
@@ -183,8 +184,22 @@ export const generateHashForDocument = (
       foundFilename,
       info
     ).combinedText;
+    const parsed = parse(text);
+    const seen = new Set<unknown>();
+    for (const definition of parsed.definitions) {
+      if (
+        definition.kind === Kind.FRAGMENT_DEFINITION &&
+        !seen.has(definition)
+      ) {
+        stripUnmaskDirectivesFromDefinition(definition);
+      }
+    }
+
     const deduplicatedFragments = fragments
-      .map(fragment => print(fragment))
+      .map(fragment => {
+        stripUnmaskDirectivesFromDefinition(fragment);
+        return print(fragment)
+      })
       .filter((fragment, index, array) => array.indexOf(fragment) === index);
 
     deduplicatedFragments.forEach(fragmentDefinition => {
@@ -203,6 +218,16 @@ export const generateHashForDocument = (
     ).combinedText;
 
     const parsed = parse(text);
+    const seen = new Set<unknown>();
+    for (const definition of parsed.definitions) {
+      if (
+        definition.kind === Kind.FRAGMENT_DEFINITION &&
+        !seen.has(definition)
+      ) {
+        stripUnmaskDirectivesFromDefinition(definition);
+      }
+    }
+
     const spreads = new Set<string>();
     visit(parsed, {
       FragmentSpread: node => {
@@ -227,6 +252,8 @@ export const generateHashForDocument = (
         return;
       }
 
+      stripUnmaskDirectivesFromDefinition(fragmentDefinition);
+
       visit(fragmentDefinition, {
         FragmentSpread: node => {
           if (!visited.has(node.name.value))
@@ -322,3 +349,14 @@ export const getDocumentReferenceFromDocumentNode = (
     return { node: documentNodeArgument, filename };
   }
 };
+
+type writable<T> = { -readonly [K in keyof T]: T[K] };
+
+const stripUnmaskDirectivesFromDefinition = (
+  definition: FragmentDefinitionNode
+) => {
+  (definition as writable<FragmentDefinitionNode>).directives =
+    definition.directives?.filter(
+      directive => directive.name.value !== '_unmask'
+    );
+};