fix wrong offsets by altering the source-file after doing original diag (#53)

Author: JoviDeCroock

.changeset/shaggy-ravens-train.md

@@ -0,0 +1,5 @@
+---
+'@0no-co/graphqlsp': patch
+---
+
+First perform the graphqlsp operations and only after do the TypeScript ones, this to account for changed lines from semantic-diagnostics

packages/graphqlsp/src/index.ts

@@ -46,14 +46,16 @@ function create(info: ts.server.PluginCreateInfo) {
   );
 
   proxy.getSemanticDiagnostics = (filename: string): ts.Diagnostic[] => {
-    const originalDiagnostics =
-      info.languageService.getSemanticDiagnostics(filename);
     const graphQLDiagnostics = getGraphQLDiagnostics(
       filename,
       baseTypesPath,
       schema,
       info
     );
+
+    const originalDiagnostics =
+      info.languageService.getSemanticDiagnostics(filename);
+
     return graphQLDiagnostics
       ? [...graphQLDiagnostics, ...originalDiagnostics]
       : originalDiagnostics;
@@ -64,6 +66,13 @@ function create(info: ts.server.PluginCreateInfo) {
     cursorPosition: number,
     options: any
   ): ts.WithMetadata<ts.CompletionInfo> | undefined => {
+    const completions = getGraphQLCompletions(
+      filename,
+      cursorPosition,
+      schema,
+      info
+    );
+
     const originalCompletions = info.languageService.getCompletionsAtPosition(
       filename,
       cursorPosition,
@@ -75,13 +84,6 @@ function create(info: ts.server.PluginCreateInfo) {
       entries: [],
     };
 
-    const completions = getGraphQLCompletions(
-      filename,
-      cursorPosition,
-      schema,
-      info
-    );
-
     if (completions) {
       return {
         ...completions,
@@ -93,18 +95,18 @@ function create(info: ts.server.PluginCreateInfo) {
   };
 
   proxy.getQuickInfoAtPosition = (filename: string, cursorPosition: number) => {
-    const originalInfo = info.languageService.getQuickInfoAtPosition(
-      filename,
-      cursorPosition
-    );
-
     const quickInfo = getGraphQLQuickInfo(
       filename,
       cursorPosition,
       schema,
       info
     );
 
+    const originalInfo = info.languageService.getQuickInfoAtPosition(
+      filename,
+      cursorPosition
+    );
+
     return quickInfo || originalInfo;
   };