feat(cookie): improve cookie_provider for better ergonomics and flexibility

Author: 0x676e67

src/client/http/mod.rs

@@ -531,11 +531,11 @@ impl ClientBuilder {
     /// This requires the optional `cookies` feature to be enabled.
     #[inline]
     #[cfg(feature = "cookies")]
-    pub fn cookie_provider<C: cookie::CookieStore + 'static>(
-        mut self,
-        cookie_store: Arc<C>,
-    ) -> ClientBuilder {
-        self.config.cookie_store = Some(cookie_store as _);
+    pub fn cookie_provider<C>(mut self, cookie_store: C) -> ClientBuilder
+    where
+        C: cookie::IntoCookieStore,
+    {
+        self.config.cookie_store = Some(cookie_store.into_cookie_store());
         self
     }
 
@@ -1256,13 +1256,13 @@ impl ClientBuilder {
 
     /// Override the DNS resolver implementation.
     ///
-    /// Pass an `Arc` wrapping a trait object implementing `Resolve`.
+    /// Pass an `Arc` wrapping a type implementing `Resolve`.
     /// Overrides for specific names passed to `resolve` and `resolve_to_addrs` will
     /// still be applied on top of this resolver.
     #[inline]
     pub fn dns_resolver<R>(mut self, resolver: R) -> ClientBuilder
     where
-        R: IntoResolve + Send + Sync + 'static,
+        R: IntoResolve,
     {
         self.config.dns_resolver = Some(resolver.into_resolve());
         self

src/cookie.rs

@@ -1,6 +1,6 @@
 //! HTTP Cookies
 
-use std::{convert::TryInto, fmt, time::SystemTime};
+use std::{convert::TryInto, fmt, sync::Arc, time::SystemTime};
 
 use bytes::BufMut;
 use cookie_crate::{Cookie as RawCookie, Expiration, SameSite};
@@ -20,6 +20,20 @@ pub trait CookieStore: Send + Sync {
     fn cookies(&self, url: &url::Url) -> Vec<HeaderValue>;
 }
 
+/// Trait for converting types into a shared cookie store ([`Arc<dyn CookieStore>`]).
+///
+/// Implemented for any [`CookieStore`] type, [`Arc<T>`] where `T: CookieStore`, and [`Arc<dyn
+/// CookieStore>`]. Enables ergonomic conversion to a trait object for use in APIs without manual
+/// boxing.
+pub trait IntoCookieStore {
+    /// Converts the implementor into an [`Arc<dyn CookieStore>`].
+    ///
+    /// This method allows ergonomic conversion of concrete cookie stores, [`Arc<T>`], or
+    /// existing [`Arc<dyn CookieStore>`] into a trait object suitable for APIs that expect
+    /// a shared cookie store.
+    fn into_cookie_store(self) -> Arc<dyn CookieStore>;
+}
+
 /// A single HTTP cookie.
 #[derive(Debug, Clone)]
 pub struct Cookie<'a>(RawCookie<'a>);
@@ -32,7 +46,37 @@ pub struct Cookie<'a>(RawCookie<'a>);
 #[derive(Debug)]
 pub struct Jar(RwLock<cookie_store::CookieStore>);
 
+// ===== impl IntoCookieStore =====
+
+impl IntoCookieStore for Arc<dyn CookieStore> {
+    #[inline]
+    fn into_cookie_store(self) -> Arc<dyn CookieStore> {
+        self
+    }
+}
+
+impl<R> IntoCookieStore for Arc<R>
+where
+    R: CookieStore + 'static,
+{
+    #[inline]
+    fn into_cookie_store(self) -> Arc<dyn CookieStore> {
+        self
+    }
+}
+
+impl<R> IntoCookieStore for R
+where
+    R: CookieStore + 'static,
+{
+    #[inline]
+    fn into_cookie_store(self) -> Arc<dyn CookieStore> {
+        Arc::new(self)
+    }
+}
+
 // ===== impl Cookie =====
+
 impl<'a> Cookie<'a> {
     fn parse(value: &'a HeaderValue) -> crate::Result<Cookie<'a>> {
         std::str::from_utf8(value.as_bytes())
@@ -126,6 +170,7 @@ pub(crate) fn extract_response_cookies(
 }
 
 // ===== impl Jar =====
+
 impl Jar {
     /// Add a cookie str to this jar.
     ///