Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the redundant sync_wrapper dependency from the core HTTP client implementation by refactoring the ResponseFuture to use a direct Pin<Box<dyn Future>> instead of wrapping it with SyncWrapper. The changes move ResponseFuture to its own module and make sync_wrapper an optional dependency only needed for specific features.
- Extracted
ResponseFutureimplementation to a separatefuture.rsmodule - Replaced
SyncWrapper<Pin<Box<dyn Future>>>with directPin<Box<dyn Future>> - Made
sync_wrapperan optional dependency formultipartandstreamfeatures only
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/core/client/mod.rs | Removes ResponseFuture implementation and sync_wrapper usage, adds future module import |
| src/core/client/future.rs | New module containing the refactored ResponseFuture implementation without sync_wrapper |
| src/client/http/future.rs | Updates import to use the new ResponseFuture location |
| src/client/http/aliases.rs | Removes unused CoreResponseFuture type alias |
| Cargo.toml | Makes sync_wrapper optional, only required for specific features |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.