fix: an unknown profile key silently became a MIN 7-10kW

get_profile() falls back to min_7000_10000_tl_x for any key it does not
recognise. That keeps setup alive, but it is a single-phase profile reading the
3000 range, so on any other model the integration loads cleanly and reports
almost nothing - with no log line and no repair to trace it to.

#360 hit it: a user hand-edited a profile into the component directory, updating
replaced those files, and their entry still named the profile that had gone. The
visible symptom was 'phase voltage and frequency show nothing', which points
nowhere near the cause.

Adds a warning in get_profile(), profile_exists() for callers that can surface
it, and an unknown_profile repair issue naming the missing key and telling the
user to re-select their model. The stale-entity cleanup is skipped in that state:
the fallback's sensor set is not the device's, and treating it as authoritative
would delete every entity the real profile created.

Also fixes the placeholder test that should have caught the new repair being
wrong. It compared strings.json against a hard-coded dict and searched only
coordinator.py, so it verified nothing about a repair raised elsewhere. It now
reads the actual translation_placeholders from every module that raises one,
parsed with ast because the values are f-strings whose braces truncate any regex.

Co-Authored-By: Claude <noreply@anthropic.com>

Author: 0xAHA

custom_components/growatt_modbus/__init__.py

@@ -376,12 +376,42 @@ def _cleanup_unsupported_vpp_entities() -> None:
     # Not gated on connectivity, for the same reason as the blocks above: profile
     # membership is a static fact needing no inverter and no poll. Gating it is what
     # stopped the v1.4.0 cleanup running at all (#362).
+    # A profile key that no longer exists resolves to min_7000_10000_tl_x, which loads
+    # cleanly and reports almost nothing on any other model. Nothing fails, so there is
+    # nothing for the user to search for — #360 spent a round trip on "my phase sensors
+    # show nothing" that turned out to be this.
+    #
+    # Raised before the cleanup below, which is skipped in that state: the fallback's
+    # sensor set is not this device's, and treating it as authoritative would delete
+    # every entity the real profile had created.
+    from .device_profiles import profile_exists
+
+    configured_profile = entry.data.get(CONF_INVERTER_SERIES, "")
+    profile_is_known = profile_exists(configured_profile)
+    if not profile_is_known:
+        try:
+            ir.async_create_issue(
+                hass,
+                DOMAIN,
+                f"unknown_profile_{entry.entry_id}",
+                is_fixable=False,
+                severity=ir.IssueSeverity.ERROR,
+                translation_key="unknown_profile",
+                translation_placeholders={"profile": configured_profile or "(none)"},
+                learn_more_url=(
+                    "https://github.com/0xAHA/Growatt_ModbusTCP/blob/main/"
+                    "docs/hardware/models.md"
+                ),
+            )
+        except Exception as err:  # noqa: BLE001
+            _LOGGER.debug("Could not create unknown-profile repair issue: %s", err)
+
     # Imported here rather than at module scope: sensor.py imports coordinator.py, and
     # hoisting this creates a cycle at integration load.
     from .sensor import SENSOR_DEFINITIONS
     from .device_profiles import get_sensors_for_profile
 
-    profile_sensors = get_sensors_for_profile(entry.data.get(CONF_INVERTER_SERIES, ""))
+    profile_sensors = get_sensors_for_profile(configured_profile) if profile_is_known else set()
     if profile_sensors:
         for sensor_key in SENSOR_DEFINITIONS:
             if sensor_key in profile_sensors:

custom_components/growatt_modbus/device_profiles.py

@@ -1,6 +1,9 @@
 """Device profiles for Growatt inverters."""
+import logging
 from typing import Dict, Set
 
+_LOGGER = logging.getLogger(__name__)
+
 # ============================================================================
 # SENSOR GROUPS
 # ============================================================================
@@ -1136,9 +1139,42 @@ def resolve_profile_alias(series: str) -> str:
     return PROFILE_ALIASES.get(series, series)
 
 
+def profile_exists(series: str) -> bool:
+    """Whether a profile key resolves to a real profile rather than the fallback.
+
+    Callers that can surface a problem to the user should check this first: get_profile()
+    cannot distinguish "you asked for MIN 7-10kW" from "you asked for something that does
+    not exist", because both return the same profile.
+    """
+    return resolve_profile_alias(series) in INVERTER_PROFILES
+
+
 def get_profile(series: str):
-    """Get inverter profile by series name, resolving any alias first."""
-    return INVERTER_PROFILES.get(resolve_profile_alias(series), INVERTER_PROFILES["min_7000_10000_tl_x"])
+    """Get inverter profile by series name, resolving any alias first.
+
+    An unknown key falls back to min_7000_10000_tl_x. That keeps setup alive rather than
+    raising, but it is a single-phase profile reading the 3000 range, so on anything else
+    it produces an integration that loads cleanly and reports almost nothing — with no
+    error to trace it to.
+    #360 hit this: a user hand-edited a profile into the component directory, and updating
+    the integration replaced those files. Their entry still named the vanished profile, so
+    they silently became a MIN.
+
+    The warning below is why this is not silent any more; __init__ also raises a repair
+    issue, because a log line alone does not reach anyone.
+    """
+    resolved = resolve_profile_alias(series)
+    profile = INVERTER_PROFILES.get(resolved)
+    if profile is None:
+        _LOGGER.warning(
+            "Unknown inverter profile %r — falling back to 'min_7000_10000_tl_x'. "
+            "Sensors for your model will be missing or empty. Reconfigure the "
+            "integration and select your model. This usually means a hand-edited "
+            "profile was removed by an update.",
+            series,
+        )
+        return INVERTER_PROFILES["min_7000_10000_tl_x"]
+    return profile
 
 
 def get_available_profiles(legacy_only: bool = False, friendly_names: bool = True) -> Dict[str, str]:

custom_components/growatt_modbus/strings.json

@@ -99,6 +99,10 @@
       "title": "Growatt: settings are being reverted",
       "description": "Local changes to **{controls}** were reverted shortly after being set, so the inverter is not keeping them.\n\nThe usual causes, in order of likelihood:\n\n- **Growatt's cloud is pushing settings back.** A ShineWiFi or ShineLink dongle that is only uploading telemetry does not appear to be enough on its own — one user runs one alongside this integration with local writes persisting overnight. What overwrites local changes is the cloud sending settings *down*: remote control enabled in the ShinePhone app, or a schedule configured there. Turn those off before disconnecting anything.\n- **A prerequisite setting is not enabled.** On MOD inverters, *Allow Grid Charge* must be Enabled before time-of-use schedules will persist.\n- **The register is not writable on your firmware.** Some models accept the write and ignore it. The log has the register number if you want to report it.\n\nThis notice will not reappear until Home Assistant restarts."
     },
+    "unknown_profile": {
+      "title": "Growatt: inverter model no longer recognised",
+      "description": "This entry is configured for the profile **{profile}**, which no longer exists in the integration.\n\nIt has fallen back to a MIN 7-10kW profile so Home Assistant can still start, but that profile reads different registers from your inverter. Most sensors will be missing or stuck at zero until this is corrected.\n\n**Fix it:** go to Settings > Devices & Services > Growatt Modbus > Configure, and select your model.\n\nThe usual cause is a profile added or edited by hand in the integration's folder, which an update then replaced. If you need a model the integration does not cover, please open an issue rather than editing the files - a profile added properly survives updates."
+    },
     "gateway_malformed_frames": {
       "title": "Growatt: RS485 gateway returning mismatched responses",
       "description": "The gateway at **{gateway}** answered **{percent}%** of requests with a frame that did not match the request — typically a complete response to an *earlier* request, replayed.\n\n**Your data is not affected.** These responses are detected and discarded rather than decoded, which is what this check is for. But the reads are lost, so sensors update less often than they should.\n\nThis is a gateway problem, not an inverter problem. Things that have helped others:\n\n- Set **Max Register Block Size** to 25 in the integration options.\n- Check the gateway is in **Modbus TCP to RTU** mode, not transparent passthrough.\n- If it has a TCP timeout setting, make sure it is enabled rather than disabled, so dead sessions are cleaned up.\n\nSee the linked guide for gateways known to work and the settings they use."

custom_components/growatt_modbus/translations/en.json

@@ -99,6 +99,10 @@
       "title": "Growatt: settings are being reverted",
       "description": "Local changes to **{controls}** were reverted shortly after being set, so the inverter is not keeping them.\n\nThe usual causes, in order of likelihood:\n\n- **Growatt's cloud is pushing settings back.** A ShineWiFi or ShineLink dongle that is only uploading telemetry does not appear to be enough on its own — one user runs one alongside this integration with local writes persisting overnight. What overwrites local changes is the cloud sending settings *down*: remote control enabled in the ShinePhone app, or a schedule configured there. Turn those off before disconnecting anything.\n- **A prerequisite setting is not enabled.** On MOD inverters, *Allow Grid Charge* must be Enabled before time-of-use schedules will persist.\n- **The register is not writable on your firmware.** Some models accept the write and ignore it. The log has the register number if you want to report it.\n\nThis notice will not reappear until Home Assistant restarts."
     },
+    "unknown_profile": {
+      "title": "Growatt: inverter model no longer recognised",
+      "description": "This entry is configured for the profile **{profile}**, which no longer exists in the integration.\n\nIt has fallen back to a MIN 7-10kW profile so Home Assistant can still start, but that profile reads different registers from your inverter. Most sensors will be missing or stuck at zero until this is corrected.\n\n**Fix it:** go to Settings > Devices & Services > Growatt Modbus > Configure, and select your model.\n\nThe usual cause is a profile added or edited by hand in the integration's folder, which an update then replaced. If you need a model the integration does not cover, please open an issue rather than editing the files - a profile added properly survives updates."
+    },
     "gateway_malformed_frames": {
       "title": "Growatt: RS485 gateway returning mismatched responses",
       "description": "The gateway at **{gateway}** answered **{percent}%** of requests with a frame that did not match the request — typically a complete response to an *earlier* request, replayed.\n\n**Your data is not affected.** These responses are detected and discarded rather than decoded, which is what this check is for. But the reads are lost, so sensors update less often than they should.\n\nThis is a gateway problem, not an inverter problem. Things that have helped others:\n\n- Set **Max Register Block Size** to 25 in the integration options.\n- Check the gateway is in **Modbus TCP to RTU** mode, not transparent passthrough.\n- If it has a TCP timeout setting, make sure it is enabled rather than disabled, so dead sessions are cleaned up.\n\nSee the linked guide for gateways known to work and the settings they use."

tests/test_gateway_health.py

@@ -97,6 +97,7 @@ def test_no_division_by_zero_on_a_fresh_connection():
 # still appears, so it looks like it works — it just says "gateway_malformed_frames" to
 # the user instead of explaining anything.
 
+import ast
 import io
 import json
 import re
@@ -136,24 +137,57 @@ def test_repair_strings_have_title_and_description(filename):
         assert body.get("description"), f"{filename}: issue '{key}' has no description"
 
 
+def _supplied_placeholders() -> dict[str, set[str]]:
+    """Placeholder names each repair issue actually passes, read from the source.
+
+    Keyed by translation_key, taken from the `translation_placeholders={...}` dict in the
+    same `ir.async_create_issue(...)` call. Repairs are raised from more than one module,
+    so every file that creates them has to be searched — an earlier version of this test
+    looked only in coordinator.py and compared against a hard-coded list, which meant it
+    verified nothing about a repair raised anywhere else.
+
+    Parsed with `ast` rather than regex: the placeholder values are f-strings such as
+    f"{hub.host}:{hub.port}", whose own braces terminate any non-greedy brace match and
+    silently drop every key after the first.
+    """
+    supplied: dict[str, set[str]] = {}
+    for filename in ("coordinator.py", "__init__.py"):
+        tree = ast.parse((COMPONENT / filename).read_text(encoding="utf-8"))
+        for node in ast.walk(tree):
+            if not isinstance(node, ast.Call):
+                continue
+            func = node.func
+            if not (isinstance(func, ast.Attribute) and func.attr == "async_create_issue"):
+                continue
+            kwargs = {kw.arg: kw.value for kw in node.keywords if kw.arg}
+            key_node = kwargs.get("translation_key")
+            if not isinstance(key_node, ast.Constant):
+                continue
+            names: set[str] = set()
+            ph = kwargs.get("translation_placeholders")
+            if isinstance(ph, ast.Dict):
+                names = {
+                    k.value for k in ph.keys
+                    if isinstance(k, ast.Constant) and isinstance(k.value, str)
+                }
+            supplied.setdefault(key_node.value, set()).update(names)
+    return supplied
+
+
 def test_placeholders_used_in_strings_are_supplied_by_the_code():
     """A placeholder with no matching value raises at render time, so the repair never
     appears — the failure is invisible rather than ugly."""
     data = json.load(io.open(COMPONENT / "strings.json", encoding="utf-8"))
-    source = (COMPONENT / "coordinator.py").read_text(encoding="utf-8")
+    supplied = _supplied_placeholders()
 
-    expected = {
-        "write_reversion": {"controls"},
-        "gateway_malformed_frames": {"gateway", "percent"},
-    }
     for key, body in data.get("issues", {}).items():
         used = set(re.findall(r"\{([a-z_]+)\}", body["title"] + body["description"]))
-        assert used == expected.get(key, set()), (
+        assert key in supplied, (
+            f"issue '{key}' is defined in strings.json but no ir.async_create_issue() "
+            f"call raises it — either it is dead, or it is raised from a module this "
+            f"test does not search"
+        )
+        assert used == supplied[key], (
             f"issue '{key}' uses placeholders {sorted(used)}; "
-            f"the code supplies {sorted(expected.get(key, set()))}"
+            f"the code supplies {sorted(supplied[key])}"
         )
-        for placeholder in used:
-            assert f'"{placeholder}"' in source, (
-                f"issue '{key}' needs placeholder '{placeholder}' but coordinator.py "
-                f"never supplies it"
-            )