fix clippy so that CI check pass

Author: arnaucube

plonky2/examples/bench_recursion.rs

@@ -284,7 +284,7 @@ fn test_serialization<F: RichField + Extendable<D>, C: GenericConfig<D, F = F>,
         common_data_bytes.len()
     );
     let common_data_from_bytes =
-        CommonCircuitData::<F, D>::from_bytes(common_data_bytes, &gate_serializer)
+        CommonCircuitData::<F, D>::from_bytes(&common_data_bytes, &gate_serializer)
             .map_err(|_| anyhow::Error::msg("CommonCircuitData deserialization failed."))?;
     assert_eq!(common_data, &common_data_from_bytes);
 

plonky2/examples/square_root.rs

@@ -23,7 +23,7 @@ use plonky2_field::extension::Extendable;
 
 /// A generator used by the prover to calculate the square root (`x`) of a given value
 /// (`x_squared`), outside of the circuit, in order to supply it as an additional public input.
-#[derive(Debug, Default)]
+#[derive(Clone, Debug, Default)]
 struct SquareRootGenerator<F: RichField + Extendable<D>, const D: usize> {
     x: Target,
     x_squared: Target,

plonky2/src/batch_fri/oracle.rs

@@ -460,7 +460,7 @@ mod test {
             &fri_instances,
             &fri_openings,
             &fri_challenges,
-            &[merkle_cap.clone()],
+            std::slice::from_ref(&merkle_cap),
             &proof,
             &fri_params,
         )?;

plonky2/src/fri/validate_shape.rs

@@ -20,7 +20,7 @@ where
     F: RichField + Extendable<D>,
     C: GenericConfig<D, F = F>,
 {
-    validate_batch_fri_proof_shape::<F, C, D>(proof, &[instance.clone()], params)
+    validate_batch_fri_proof_shape::<F, C, D>(proof, std::slice::from_ref(instance), params)
 }
 
 pub(crate) fn validate_batch_fri_proof_shape<F, C, const D: usize>(

plonky2/src/gadgets/interpolation.rs

@@ -86,7 +86,7 @@ mod tests {
 
         let value_targets = values
             .iter()
-            .map(|&v| (builder.constant_extension(v)))
+            .map(|&v| builder.constant_extension(v))
             .collect::<Vec<_>>();
 
         let zt = builder.constant_extension(z);

plonky2/src/hash/merkle_proofs.rs

@@ -59,7 +59,7 @@ pub fn verify_merkle_proof_to_cap<F: RichField, H: Hasher<F>>(
     proof: &MerkleProof<F, H>,
 ) -> Result<()> {
     verify_batch_merkle_proof_to_cap(
-        &[leaf_data.clone()],
+        std::slice::from_ref(&leaf_data),
         &[proof.siblings.len()],
         leaf_index,
         merkle_cap,

plonky2/src/iop/generator.rs

@@ -244,7 +244,7 @@ pub trait SimpleGenerator<F: RichField + Extendable<D>, const D: usize>:
 #[derive(Debug, Clone)]
 pub struct SimpleGeneratorAdapter<
     F: RichField + Extendable<D>,
-    SG: SimpleGenerator<F, D> + ?Sized,
+    SG: SimpleGenerator<F, D>,
     const D: usize,
 > {
     _phantom: PhantomData<F>,

plonky2/src/plonk/circuit_data.rs

@@ -315,7 +315,7 @@ impl<F: RichField + Extendable<D>, C: GenericConfig<D, F = F>, const D: usize>
     }
 
     pub fn from_bytes(bytes: &[u8], gate_serializer: &dyn GateSerializer<F, D>) -> IoResult<Self> {
-        let mut buffer = Buffer::new(&bytes);
+        let mut buffer = Buffer::new(bytes);
         buffer.read_verifier_circuit_data(gate_serializer)
     }
 
@@ -405,7 +405,7 @@ impl<C: GenericConfig<D>, const D: usize> VerifierOnlyCircuitData<C, D> {
     }
 
     pub fn from_bytes(bytes: &[u8]) -> IoResult<Self> {
-        let mut buffer = Buffer::new(&bytes);
+        let mut buffer = Buffer::new(bytes);
         buffer.read_verifier_only_circuit_data()
     }
 }
@@ -458,7 +458,7 @@ impl<F: RichField + Extendable<D>, const D: usize> CommonCircuitData<F, D> {
     }
 
     pub fn from_bytes(bytes: &[u8], gate_serializer: &dyn GateSerializer<F, D>) -> IoResult<Self> {
-        let mut buffer = Buffer::new(&bytes);
+        let mut buffer = Buffer::new(bytes);
         buffer.read_common_circuit_data(gate_serializer)
     }
 

plonky2/src/plonk/config.rs

@@ -51,7 +51,7 @@ pub trait Hasher<F: RichField>: Sized + Copy + Debug + Eq + PartialEq {
     fn hash_pad(input: &[F]) -> Self::Hash {
         let mut padded_input = input.to_vec();
         padded_input.push(F::ONE);
-        while (padded_input.len() + 1) % Self::Permutation::RATE != 0 {
+        while !(padded_input.len() + 1).is_multiple_of(Self::Permutation::RATE) {
             padded_input.push(F::ZERO);
         }
         padded_input.push(F::ONE);

plonky2/src/util/reducing.rs

@@ -150,7 +150,7 @@ impl<const D: usize> ReducingFactorTarget<D> {
         let zero_ext = builder.zero_extension();
         let mut acc = zero_ext;
         let mut reversed_terms = terms.to_vec();
-        while reversed_terms.len() % max_coeffs_len != 0 {
+        while !reversed_terms.len().is_multiple_of(max_coeffs_len) {
             reversed_terms.push(zero);
         }
         reversed_terms.reverse();
@@ -200,7 +200,7 @@ impl<const D: usize> ReducingFactorTarget<D> {
         let zero_ext = builder.zero_extension();
         let mut acc = zero_ext;
         let mut reversed_terms = terms.to_vec();
-        while reversed_terms.len() % max_coeffs_len != 0 {
+        while !reversed_terms.len().is_multiple_of(max_coeffs_len) {
             reversed_terms.push(zero_ext);
         }
         reversed_terms.reverse();