Skip to content

Commit 3bbb4b8

Browse files
committed
apply review suggestions from @ed255
1 parent f4bd18a commit 3bbb4b8

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

src/backends/plonky2/circuits/mainpod.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1231,6 +1231,9 @@ impl MainPodVerifyGadget {
12311231
}
12321232
.eval(builder);
12331233

1234+
// ensure that mt_proof is enabled
1235+
let true_targ = builder._true();
1236+
builder.connect(vd_mt_proof.enabled.target, true_targ.target);
12341237
// connect the vd_mt_proof's root to the actual vds_root, to ensure that the mt proof
12351238
// verifies against the vds_root
12361239
builder.connect_hashes(vds_root, vd_mt_proof.root);

src/backends/plonky2/mainpod/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -701,7 +701,7 @@ pub mod tests {
701701
{self},
702702
},
703703
middleware,
704-
middleware::{CustomPredicateRef, NativePredicate as NP, RawValue, DEFAULT_VD_SET},
704+
middleware::{CustomPredicateRef, NativePredicate as NP, DEFAULT_VD_SET},
705705
op,
706706
};
707707

src/frontend/mod.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@ use serialization::{SerializedMainPod, SerializedSignedPod};
1010
use crate::middleware::{
1111
self, check_st_tmpl, hash_str, hash_values, AnchoredKey, Hash, Key, MainPodInputs,
1212
NativeOperation, NativePredicate, OperationAux, OperationType, Params, PodId, PodProver,
13-
PodSigner, Predicate, Statement, StatementArg, VDSet, Value, WildcardValue, DEFAULT_VD_SET,
14-
KEY_TYPE, SELF,
13+
PodSigner, Predicate, Statement, StatementArg, VDSet, Value, WildcardValue, KEY_TYPE, SELF,
1514
};
1615

1716
mod custom;
@@ -565,7 +564,7 @@ impl MainPodBuilder {
565564
statements: &statements,
566565
operations: &operations,
567566
public_statements: &public_statements,
568-
vds_root: DEFAULT_VD_SET.root(),
567+
vds_root: self.vd_set.root(),
569568
};
570569
let pod = prover.prove(&self.params, &self.vd_set, inputs)?;
571570

@@ -841,7 +840,7 @@ pub mod tests {
841840
eth_dos_pod_builder, eth_friend_signed_pod_builder, great_boy_pod_full_flow,
842841
tickets_pod_full_flow, zu_kyc_pod_builder, zu_kyc_sign_pod_builders,
843842
},
844-
middleware::{containers::Dictionary, Value},
843+
middleware::{containers::Dictionary, Value, DEFAULT_VD_SET},
845844
};
846845

847846
// Check that frontend public statements agree with those

src/frontend/serialization.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ mod tests {
112112
middleware::{
113113
self,
114114
containers::{Array, Dictionary, Set},
115-
Params, RawValue, TypedValue, DEFAULT_VD_SET,
115+
Params, TypedValue, DEFAULT_VD_SET,
116116
},
117117
};
118118

0 commit comments

Comments
 (0)