fix lint

marcello33 · marcello33 · commit 21b808b53c80 · 2026-01-23T14:22:00.000+01:00
diff --git a/blocksync/reactor_test.go b/blocksync/reactor_test.go
@@ -261,7 +261,7 @@ func TestBadBlockStopsPeer(t *testing.T) {
 		require.NoError(t, err)
 	}()
 
-	reactorPairs := make([]ReactorPair, 4)
+	reactorPairs := make([]ReactorPair, 4) //nolint:prealloc
 
 	reactorPairs[0] = newReactor(t, log.TestingLogger(), genDoc, privVals, maxBlockHeight)
 	reactorPairs[1] = newReactor(t, log.TestingLogger(), genDoc, privVals, 0)
@@ -344,7 +344,7 @@ func TestCheckSwitchToConsensusLastHeightZero(t *testing.T) {
 
 	reactorPairs = append(reactorPairs, newReactor(t, log.TestingLogger(), genDoc, privVals, maxBlockHeight))
 
-	var switches []*p2p.Switch
+	var switches []*p2p.Switch //nolint:prealloc
 	for _, r := range reactorPairs {
 		switches = append(switches, p2p.MakeConnectedSwitches(config.P2P, 1, func(i int, s *p2p.Switch) *p2p.Switch {
 			s.AddReactor("BLOCKSYNC", r.reactor)
@@ -410,7 +410,7 @@ func ExtendedCommitNetworkHelper(t *testing.T, maxBlockHeight int64, enableVoteE
 
 	reactorPairs = append(reactorPairs, newReactor(t, log.TestingLogger(), genDoc, privVals, maxBlockHeight, invalidBlockHeightAt))
 
-	var switches []*p2p.Switch
+	var switches []*p2p.Switch //nolint:prealloc
 	for _, r := range reactorPairs {
 		switches = append(switches, p2p.MakeConnectedSwitches(config.P2P, 1, func(i int, s *p2p.Switch) *p2p.Switch {
 			s.AddReactor("BLOCKSYNC", r.reactor)
diff --git a/libs/bits/bit_array.go b/libs/bits/bit_array.go
@@ -472,7 +472,7 @@ func (bA *BitArray) UnmarshalJSON(bz []byte) error {
 			bA2.SetIndex(i, true)
 		}
 	}
-	*bA = *bA2 //nolint:govet
+	*bA = *bA2 //nolint:govet,copylocks
 	return nil
 }
 
diff --git a/libs/pubsub/query/query.go b/libs/pubsub/query/query.go
@@ -64,7 +64,7 @@ func Compile(ast syntax.Query) (*Query, error) {
 }
 
 func ExpandEvents(flattenedEvents map[string][]string) []types.Event {
-	events := make([]types.Event, 0)
+	events := make([]types.Event, 0) //nolint:prealloc
 
 	for composite, values := range flattenedEvents {
 		tokens := strings.Split(composite, ".")
diff --git a/libs/pubsub/query/query_test.go b/libs/pubsub/query/query_test.go
@@ -443,7 +443,7 @@ func TestAllMatchesAll(t *testing.T) {
 		`Route|66=`,
 		`Rilly|Blue=`,
 	)
-	keys := make([]string, 0)
+	keys := make([]string, 0) //nolint:prealloc
 	for k := range events {
 		keys = append(keys, k)
 	}
diff --git a/mempool/cache_test.go b/mempool/cache_test.go
@@ -70,7 +70,7 @@ func TestCacheAfterUpdate(t *testing.T) {
 			require.NoError(t, err)
 		}
 
-		updateTxs := []types.Tx{}
+		updateTxs := []types.Tx{} //nolint:prealloc
 		for _, v := range tc.updateIndices {
 			tx := kvstore.NewTx(fmt.Sprintf("%d", v), "value")
 			updateTxs = append(updateTxs, tx)
diff --git a/p2p/conn/connection.go b/p2p/conn/connection.go
@@ -197,7 +197,7 @@ func NewMConnectionWithConfig(
 
 	// Create channels
 	channelsIdx := map[byte]*Channel{}
-	channels := []*Channel{}
+	channels := []*Channel{} //nolint:prealloc
 
 	for _, desc := range chDescs {
 		channel := newChannel(mconn, *desc)
diff --git a/p2p/node_info_test.go b/p2p/node_info_test.go
@@ -18,7 +18,7 @@ func TestNodeInfoValidate(t *testing.T) {
 	for i := 0; i < maxNumChannels; i++ {
 		channels[i] = byte(i)
 	}
-	dupChannels := make([]byte, 5)
+	dupChannels := make([]byte, 5) //nolint:prealloc
 	copy(dupChannels, channels[:5])
 	dupChannels = append(dupChannels, testCh)
 
diff --git a/p2p/pex/addrbook.go b/p2p/pex/addrbook.go
@@ -831,7 +831,7 @@ func (a *addrBook) addBadPeer(addr *p2p.NetAddress, banTime time.Duration) bool
 
 // hash(key + sourcegroup + int64(hash(key + group + sourcegroup)) % bucket_per_group) % num_new_buckets
 func (a *addrBook) calcNewBucket(addr, src *p2p.NetAddress) (int, error) {
-	data1 := []byte{}
+	data1 := []byte{} //nolint:prealloc
 	data1 = append(data1, []byte(a.key)...)
 	data1 = append(data1, []byte(a.groupKey(addr))...)
 	data1 = append(data1, []byte(a.groupKey(src))...)
@@ -843,7 +843,7 @@ func (a *addrBook) calcNewBucket(addr, src *p2p.NetAddress) (int, error) {
 	hash64 %= newBucketsPerGroup
 	var hashbuf [8]byte
 	binary.BigEndian.PutUint64(hashbuf[:], hash64)
-	data2 := []byte{}
+	data2 := []byte{} //nolint:prealloc
 	data2 = append(data2, []byte(a.key)...)
 	data2 = append(data2, a.groupKey(src)...)
 	data2 = append(data2, hashbuf[:]...)
@@ -858,7 +858,7 @@ func (a *addrBook) calcNewBucket(addr, src *p2p.NetAddress) (int, error) {
 
 // hash(key + group + int64(hash(key + addr)) % buckets_per_group) % num_old_buckets
 func (a *addrBook) calcOldBucket(addr *p2p.NetAddress) (int, error) {
-	data1 := []byte{}
+	data1 := []byte{} //nolint:prealloc
 	data1 = append(data1, []byte(a.key)...)
 	data1 = append(data1, []byte(addr.String())...)
 	hash1, err := a.hash(data1)
@@ -869,7 +869,7 @@ func (a *addrBook) calcOldBucket(addr *p2p.NetAddress) (int, error) {
 	hash64 %= oldBucketsPerGroup
 	var hashbuf [8]byte
 	binary.BigEndian.PutUint64(hashbuf[:], hash64)
-	data2 := []byte{}
+	data2 := []byte{} //nolint:prealloc
 	data2 = append(data2, []byte(a.key)...)
 	data2 = append(data2, a.groupKey(addr)...)
 	data2 = append(data2, hashbuf[:]...)
diff --git a/privval/signer_client_test.go b/privval/signer_client_test.go
@@ -25,7 +25,7 @@ type signerTestCase struct {
 }
 
 func getSignerTestCases(t *testing.T) []signerTestCase {
-	testCases := make([]signerTestCase, 0)
+	testCases := make([]signerTestCase, 0) //nolint:prealloc
 
 	// Get test cases for each possible dialer (DialTCP / DialUnix / etc)
 	for _, dtc := range getDialerTestCases(t) {
diff --git a/rpc/core/net.go b/rpc/core/net.go
@@ -100,7 +100,7 @@ func (env *Environment) UnsafeDialPeers(
 //nolint:govet
 func (env *Environment) Genesis(*rpctypes.Context) (*ctypes.ResultGenesis, error) {
 	return nil, errors.New("endpoint is disabled due to large genesis file size")
-
+	//nolint:govet
 	if len(env.genChunks) > 1 {
 		return nil, errors.New("genesis response is large, please use the genesis_chunked API instead")
 	}
@@ -111,6 +111,7 @@ func (env *Environment) Genesis(*rpctypes.Context) (*ctypes.ResultGenesis, error
 //nolint:govet
 func (env *Environment) GenesisChunked(_ *rpctypes.Context, chunk uint) (*ctypes.ResultGenesisChunk, error) {
 	return nil, errors.New("endpoint is disabled due to large genesis file size")
+	//nolint:govet
 	if env.genChunks == nil {
 		return nil, fmt.Errorf("service configuration error, genesis chunks are not initialized")
 	}
diff --git a/rpc/jsonrpc/server/http_uri_handler.go b/rpc/jsonrpc/server/http_uri_handler.go
@@ -37,7 +37,7 @@ func makeHTTPHandler(rpcFunc *RPCFunc, logger log.Logger) func(http.ResponseWrit
 		logger.Debug("HTTP HANDLER", "req", r)
 
 		ctx := &types.Context{HTTPReq: r}
-		args := []reflect.Value{reflect.ValueOf(ctx)}
+		args := []reflect.Value{reflect.ValueOf(ctx)} //nolint:prealloc
 
 		fnArgs, err := httpParamsToArgs(rpcFunc, r)
 		if err != nil {
diff --git a/scripts/metricsgen/metricsgen.go b/scripts/metricsgen/metricsgen.go
@@ -269,7 +269,7 @@ func extractHelpMessage(cg *ast.CommentGroup) string {
 	if cg == nil {
 		return ""
 	}
-	var help []string //nolint: prealloc
+	var help []string
 	for _, c := range cg.List {
 		mt := strings.TrimPrefix(c.Text, "//metrics:")
 		if mt != c.Text {
@@ -288,7 +288,7 @@ func extractLabels(bl *ast.BasicLit) string {
 	if bl != nil {
 		t := reflect.StructTag(strings.Trim(bl.Value, "`"))
 		if v := t.Get(labelsTag); v != "" {
-			var res []string
+			var res []string //nolint:prealloc
 			for _, s := range strings.Split(v, ",") {
 				res = append(res, strconv.Quote(strings.TrimSpace(s)))
 			}
diff --git a/state/execution_test.go b/state/execution_test.go
@@ -399,11 +399,11 @@ func TestProcessProposal(t *testing.T) {
 
 	block0, err := makeBlock(state, height-1, new(types.Commit))
 	require.NoError(t, err)
-	lastCommitSig := []types.CommitSig{}
+	lastCommitSig := []types.CommitSig{} //nolint:prealloc
 	partSet, err := block0.MakePartSet(types.PartSizeBytes)
 	require.NoError(t, err)
 	blockID := types.BlockID{Hash: block0.Hash(), PartSetHeader: partSet.Header()}
-	voteInfos := []abci.VoteInfo{}
+	voteInfos := []abci.VoteInfo{} //nolint:prealloc
 	for _, privVal := range privVals {
 		pk, err := privVal.GetPubKey()
 		require.NoError(t, err)
diff --git a/state/validation_test.go b/state/validation_test.go
@@ -102,7 +102,7 @@ func TestValidateBlockHeader(t *testing.T) {
 			block, err := makeBlock(state, height, lastCommit)
 			require.NoError(t, err)
 			tc.malleateBlock(block)
-			err = blockExec.ValidateBlock(state, block)
+			_ = blockExec.ValidateBlock(state, block)
 		}
 
 		/*
diff --git a/test/e2e/app/app.go b/test/e2e/app/app.go
@@ -492,7 +492,7 @@ func (app *Application) ApplySnapshotChunk(_ context.Context, req *abci.RequestA
 	}
 	app.restoreChunks = append(app.restoreChunks, req.Chunk)
 	if len(app.restoreChunks) == int(app.restoreSnapshot.Chunks) {
-		bz := []byte{}
+		bz := []byte{} //nolint:prealloc
 		for _, chunk := range app.restoreChunks {
 			bz = append(bz, chunk...)
 		}
diff --git a/test/e2e/generator/random.go b/test/e2e/generator/random.go
@@ -22,7 +22,7 @@ import (
 // {"foo": 3, "bar": 5}
 // {"foo": 3, "bar": 6}
 func combinations(items map[string][]interface{}) []map[string]interface{} {
-	keys := []string{}
+	keys := []string{} //nolint:prealloc
 	for key := range items {
 		keys = append(keys, key)
 	}
@@ -73,7 +73,7 @@ func (pc probSetChoice) Choose(r *rand.Rand) []string {
 type uniformSetChoice []string
 
 func (usc uniformSetChoice) Choose(r *rand.Rand) []string {
-	choices := []string{}
+	choices := []string{} //nolint:prealloc
 	indexes := r.Perm(len(usc))
 	if len(indexes) > 1 {
 		indexes = indexes[:1+r.Intn(len(indexes)-1)]
diff --git a/test/e2e/pkg/infrastructure.go b/test/e2e/pkg/infrastructure.go
@@ -46,7 +46,7 @@ type InstanceData struct {
 
 func sortNodeNames(m Manifest) []string {
 	// Set up nodes, in alphabetical order (IPs and ports get same order).
-	nodeNames := []string{}
+	nodeNames := []string{} //nolint:prealloc
 	for name := range m.Nodes {
 		nodeNames = append(nodeNames, name)
 	}
diff --git a/types/evidence.go b/types/evidence.go
@@ -481,7 +481,7 @@ func (evl EvidenceList) Has(evidence Evidence) bool {
 // ToABCI converts the evidence list to a slice of the ABCI protobuf messages
 // for use when communicating the evidence to an application.
 func (evl EvidenceList) ToABCI() []abci.Misbehavior {
-	var el []abci.Misbehavior
+	var el []abci.Misbehavior //nolint:prealloc
 	for _, e := range evl {
 		el = append(el, e.ABCI()...)
 	}
diff --git a/types/validator_set_test.go b/types/validator_set_test.go
@@ -1280,7 +1280,7 @@ func randTestVSetCfg(nBase, nAddMax int) testVSetCfg {
 }
 
 func applyChangesToValSet(t *testing.T, expErr error, valSet *ValidatorSet, valsLists ...[]testVal) {
-	changes := make([]testVal, 0)
+	changes := make([]testVal, 0) //nolint:prealloc
 	for _, valsList := range valsLists {
 		changes = append(changes, valsList...)
 	}

Original file line number	Diff line number	Diff line change
`@@ -472,7 +472,7 @@ func (bA *BitArray) UnmarshalJSON(bz []byte) error {`
`472`	`472`	`bA2.SetIndex(i, true)`
`473`	`473`	`}`
`474`	`474`	`}`
`475`		`- bA = bA2 //nolint:govet`
	`475`	`+ bA = bA2 //nolint:govet,copylocks`
`476`	`476`	`return nil`
`477`	`477`	`}`
`478`	`478`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ func Compile(ast syntax.Query) (*Query, error) {`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`func ExpandEvents(flattenedEvents map[string][]string) []types.Event {`
`67`		`- events := make([]types.Event, 0)`
	`67`	`+ events := make([]types.Event, 0) //nolint:prealloc`
`68`	`68`
`69`	`69`	`for composite, values := range flattenedEvents {`
`70`	`70`	`tokens := strings.Split(composite, ".")`
Original file line number	Diff line number	Diff line change
`@@ -443,7 +443,7 @@ func TestAllMatchesAll(t *testing.T) {`
`443`	`443`	`Route\|66=`,
`444`	`444`	`Rilly\|Blue=`,
`445`	`445`	`)`
`446`		`- keys := make([]string, 0)`
	`446`	`+ keys := make([]string, 0) //nolint:prealloc`
`447`	`447`	`for k := range events {`
`448`	`448`	`keys = append(keys, k)`
`449`	`449`	`}`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ func TestCacheAfterUpdate(t *testing.T) {`
`70`	`70`	`require.NoError(t, err)`
`71`	`71`	`}`
`72`	`72`
`73`		`- updateTxs := []types.Tx{}`
	`73`	`+ updateTxs := []types.Tx{} //nolint:prealloc`
`74`	`74`	`for _, v := range tc.updateIndices {`
`75`	`75`	`tx := kvstore.NewTx(fmt.Sprintf("%d", v), "value")`
`76`	`76`	`updateTxs = append(updateTxs, tx)`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ func TestNodeInfoValidate(t *testing.T) {`
`18`	`18`	`for i := 0; i < maxNumChannels; i++ {`
`19`	`19`	`channels[i] = byte(i)`
`20`	`20`	`}`
`21`		`- dupChannels := make([]byte, 5)`
	`21`	`+ dupChannels := make([]byte, 5) //nolint:prealloc`
`22`	`22`	`copy(dupChannels, channels[:5])`
`23`	`23`	`dupChannels = append(dupChannels, testCh)`
`24`	`24`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ type signerTestCase struct {`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`func getSignerTestCases(t *testing.T) []signerTestCase {`
`28`		`- testCases := make([]signerTestCase, 0)`
	`28`	`+ testCases := make([]signerTestCase, 0) //nolint:prealloc`
`29`	`29`
`30`	`30`	`// Get test cases for each possible dialer (DialTCP / DialUnix / etc)`
`31`	`31`	`for _, dtc := range getDialerTestCases(t) {`