lint and build fixes

Author: lucca30

node/node_test.go

@@ -459,6 +459,7 @@ func TestNodeNewNodeCustomReactors(t *testing.T) {
 		cfg.DefaultDBProvider,
 		DefaultMetricsProvider(config.Instrumentation),
 		log.TestingLogger(),
+		true,
 		CustomReactors(map[string]p2p.Reactor{"FOO": cr, "BLOCKSYNC": customBlocksyncReactor}),
 	)
 	require.NoError(t, err)

state/store.go

@@ -1,11 +1,9 @@
 package state
 
 import (
-	"bytes"
 	"encoding/binary"
 	"errors"
 	"fmt"
-	"strconv"
 	"time"
 
 	"github.com/cosmos/gogoproto/proto"
@@ -33,7 +31,6 @@ const (
 var (
 	ErrKeyNotFound        = errors.New("key not found")
 	ErrInvalidHeightValue = errors.New("invalid height value")
-	abciResponsesPrefix   = []byte("abciResponsesKey:")
 )
 
 //------------------------------------------------------------------------
@@ -50,22 +47,6 @@ func calcABCIResponsesKey(height int64) []byte {
 	return []byte(fmt.Sprintf("abciResponsesKey:%v", height))
 }
 
-// parseABCIResponsesKey checks if key has the prefix and returns (ok, height).
-func parseABCIResponsesKey(key []byte) (bool, int64) {
-	if !bytes.HasPrefix(key, abciResponsesPrefix) {
-		return false, 0
-	}
-	// Extract the suffix part (height as bytes)
-	suffix := key[len(abciResponsesPrefix):]
-
-	// Parse it as int64
-	height, err := strconv.ParseInt(string(suffix), 10, 64)
-	if err != nil {
-		return false, 0
-	}
-	return true, height
-}
-
 // ----------------------
 var (
 	lastABCIResponseKey              = []byte("lastABCIResponseKey")

state/store_test.go

@@ -479,6 +479,7 @@ func TestFinalizeBlockResponsePruning(t *testing.T) {
 			sm.WithPrunerObserver(obs),
 			sm.WithPrunerCompanionEnabled(),
 		)
+		pruner.DisableWaitAtStart()
 
 		// Check that we have written a finalize block result at height 'height - 1'
 		_, err = stateStore.LoadFinalizeBlockResponse(height - 1)

test/e2e/node/main.go

@@ -140,6 +140,7 @@ func startNode(cfg *Config) error {
 		config.DefaultDBProvider,
 		node.DefaultMetricsProvider(cmtcfg.Instrumentation),
 		nodeLogger,
+		false,
 	)
 	if err != nil {
 		return err