Removed unused argument from Prune function;

Author: jmalicevic

state/mocks/store.go

@@ -40,6 +40,7 @@ type Pruner struct {
 
 	// Preserve the number of state entries pruned.
 	// Used to calculated correctly when to trigger compactions
+	// TODO This is unused and should be removed from V1 and main as well.
 	prunedStates uint64
 }
 
@@ -370,7 +371,7 @@ func (p *Pruner) pruneBlocksToHeight(height int64) (uint64, int64, error) {
 
 	if pruned > 0 {
 
-		p.prunedStates, err = p.stateStore.PruneStates(base, height, evRetainHeight, p.prunedStates)
+		_, err = p.stateStore.PruneStates(base, height, evRetainHeight)
 		if err != nil {
 			return 0, 0, ErrFailedToPruneStates{Height: height, Err: err}
 		}

state/pruner.go

@@ -85,7 +85,7 @@ type Store interface {
 	// Gets the height at which the store is bootstrapped after out of band statesync
 	GetOfflineStateSyncHeight() (int64, error)
 	// PruneStates takes the height from which to start pruning and which height stop at
-	PruneStates(fromHeight, toHeight, evidenceThresholdHeight int64, previouslyPrunedStates uint64) (uint64, error)
+	PruneStates(fromHeight, toHeight, evidenceThresholdHeight int64) (uint64, error)
 	// PruneABCIResponses will prune all ABCI responses below the given height.
 	PruneABCIResponses(targetRetainHeight int64, forceCompact bool) (int64, int64, error)
 	// SaveApplicationRetainHeight persists the application retain height from the application
@@ -306,7 +306,7 @@ func (store dbStore) Bootstrap(state State) error {
 // encoding not preserving ordering: https://github.com/tendermint/tendermint/issues/4567
 // This will cause some old states to be left behind when doing incremental partial prunes,
 // specifically older checkpoints and LastHeightChanged targets.
-func (store dbStore) PruneStates(from int64, to int64, evidenceThresholdHeight int64, previosulyPrunedStates uint64) (uint64, error) {
+func (store dbStore) PruneStates(from int64, to int64, evidenceThresholdHeight int64) (uint64, error) {
 	if from <= 0 || to <= 0 {
 		return 0, fmt.Errorf("from height %v and to height %v must be greater than 0", from, to)
 	}

state/store.go

@@ -175,7 +175,7 @@ func TestPruneStates(t *testing.T) {
 			makeAndSaveStates(t, 1, tc.makeHeights, stateStore)
 
 			// Test assertions
-			_, err := stateStore.PruneStates(tc.pruneFrom, tc.pruneTo, tc.evidenceThresholdHeight, 0)
+			_, err := stateStore.PruneStates(tc.pruneFrom, tc.pruneTo, tc.evidenceThresholdHeight)
 			if tc.expectErr {
 				require.Error(t, err)
 				return