-
Notifications
You must be signed in to change notification settings - Fork 2
Description
I noticed that the api/chainlink/productRegistration endpoint does not currently accept parameters in the following format:
"{'title': 'Burton Custom Freestyle 151','body_html': '<strong>Good snowboard!</strong>','vendor': 'Burton','product_type': 'Snowboard'}",
"[{'sku':'skusample','cost':'100'}]",
As shown in this commit: 0xShin0221/Protocol_ShopDAOGenerator_Chainlink2023@b9662aa#diff-5a8cc94f1ee5a6af228c61192731833298e8fdc1fd38af75dd506579a007d899R44-R51
I propose updating the endpoint to correctly handle parameters in this format.
Additionally, I have learned that obtaining access tokens through environment variables may not be the best approach. To address this, I suggest retrieving access tokens from the accessTokenWalletAddress table in the database, using the wallet address as a reference. This change would require us to pass the wallet address as a request parameter.
Furthermore, the current naming convention for storeUrl is not ideal. I recommend renaming it to shopifyStoreDomain or something similar to better reflect its purpose.