Update tests

Author: frankdekker

src/Form/Review/AddCommentFormType.php

@@ -43,14 +43,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
         $builder->add(
             'lineReference',
             HiddenType::class,
-            [
-                'data' => (string)$lineReference,
-                'setter' => static function (Comment $comment, string $value): void {
-                    $lineReference = LineReference::fromString($value);
-                    $comment->setLineReference($lineReference);
-                    $comment->setFilePath(Assert::notNull($lineReference->oldPath ?? $lineReference->newPath));
-                },
-            ]
+            ['data' => (string)$lineReference, 'setter' => $this->setter(...)]
         );
         $builder->add(
             'message',
@@ -63,4 +56,11 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
         $builder->add('tag', CommentTagType::class);
         $builder->add('save', SubmitType::class, ['label' => 'add.comment']);
     }
+
+    public function setter(Comment $comment, string $value): void
+    {
+        $lineReference = LineReference::fromString($value);
+        $comment->setLineReference($lineReference);
+        $comment->setFilePath(Assert::notNull($lineReference->oldPath ?? $lineReference->newPath));
+    }
 }

tests/Unit/Form/Review/AddCommentFormTypeTest.php

@@ -5,6 +5,7 @@
 
 use DR\Review\Controller\App\Review\Comment\AddCommentController;
 use DR\Review\Entity\Review\CodeReview;
+use DR\Review\Entity\Review\Comment;
 use DR\Review\Entity\Review\LineReference;
 use DR\Review\Form\Review\AddCommentFormType;
 use DR\Review\Form\Review\CommentTagType;
@@ -74,4 +75,13 @@ public function testBuildForm(): void
 
         $this->type->buildForm($builder, ['review' => $review, 'lineReference' => $lineReference]);
     }
+
+    public function testSetter(): void
+    {
+        $reference = 'old/path:new/path:1:2:3:commitSha:A';
+        $comment   = new Comment();
+        $this->type->setter($comment, $reference);
+        static::assertEquals(LineReference::fromString($reference), $comment->getLineReference());
+        static::assertSame('old/path', $comment->getFilePath());
+    }
 }