Add coverage

frankdekker · frankdekker · commit 51adf2ce48df · 2025-09-19T20:54:37.000+02:00
diff --git a/src/Security/Voter/AssetVoter.php b/src/Security/Voter/AssetVoter.php
@@ -38,10 +38,6 @@ protected function voteOnAttribute(string $attribute, mixed $subject, TokenInter
         $hash  = Assert::notNull($this->requestStack->getCurrentRequest())->query->getString('hash');
         $asset = Assert::isInstanceOf($subject, Asset::class);
 
-        // Validate that the hash parameter is not empty before comparison
-        if ($hash === '' || $hash === null) {
-            return false;
-        }
-        return hash_equals($asset->getHash(), $hash);
+        return $hash !== '' && hash_equals($asset->getHash(), $hash);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -38,10 +38,6 @@ protected function voteOnAttribute(string $attribute, mixed $subject, TokenInter`
`38`	`38`	`$hash = Assert::notNull($this->requestStack->getCurrentRequest())->query->getString('hash');`
`39`	`39`	`$asset = Assert::isInstanceOf($subject, Asset::class);`
`40`	`40`
`41`		`- // Validate that the hash parameter is not empty before comparison`
`42`		`- if ($hash === '' \|\| $hash === null) {`
`43`		`- return false;`
`44`		`- }`
`45`		`- return hash_equals($asset->getHash(), $hash);`
	`41`	`+ return $hash !== '' && hash_equals($asset->getHash(), $hash);`
`46`	`42`	`}`
`47`	`43`	`}`