Merge pull request #43 from anne-gaelle123inkt/master

warning when custom coverage is above or equal to global coverage

Author: frankdekker

src/Lib/Metrics/Inspection/CustomCoverageAboveGlobalInspection.php

@@ -24,7 +24,7 @@ public function inspect(?PathInspectionConfig $fileConfig, FileMetric $metric):
         $customCoverage = $fileConfig->getMinimumCoverage();
 
         // custom coverage is lower than global coverage, and file is above global coverage
-        if ($customCoverage < $globalCoverage && $metric->getCoverage() >= $globalCoverage) {
+        if ($customCoverage <= $globalCoverage && $metric->getCoverage() >= $globalCoverage) {
             return new Failure($metric, $fileConfig->getMinimumCoverage(), Failure::UNNECESSARY_CUSTOM_COVERAGE);
         }
 

tests/Unit/Lib/Config/ConfigFactoryTest.php

@@ -150,7 +150,7 @@ public function testCreateInspectConfigDuplicateOutputReport(): void
         touch($coveragePath);
 
         $input = $this->createMock(InputInterface::class);
-        $input->expects(self::exactly(5))->method('getOption')->willReturn($configPath, null, null, null);
+        $input->expects(self::exactly(5))->method('getOption')->willReturn($configPath, null, null, null, null);
         $input->expects(self::once())->method('getArgument')->with('coverage')->willReturn([$coveragePath]);
 
         $config = $this->factory->createInspectConfig($input);