B#187800 PHPFCI: warning when custom coverage is above or equal to global coverage

anne-gaelle123inkt · anne-gaelle123inkt · commit d958cc605136 · 2024-10-30T12:21:09.000+01:00
diff --git a/src/Lib/Metrics/Inspection/CustomCoverageAboveGlobalInspection.php b/src/Lib/Metrics/Inspection/CustomCoverageAboveGlobalInspection.php
@@ -24,7 +24,7 @@ public function inspect(?PathInspectionConfig $fileConfig, FileMetric $metric):
         $customCoverage = $fileConfig->getMinimumCoverage();
 
         // custom coverage is lower than global coverage, and file is above global coverage
-        if ($customCoverage < $globalCoverage && $metric->getCoverage() >= $globalCoverage) {
+        if ($customCoverage <= $globalCoverage && $metric->getCoverage() >= $globalCoverage) {
             return new Failure($metric, $fileConfig->getMinimumCoverage(), Failure::UNNECESSARY_CUSTOM_COVERAGE);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ public function inspect(?PathInspectionConfig $fileConfig, FileMetric $metric):`
`24`	`24`	`$customCoverage = $fileConfig->getMinimumCoverage();`
`25`	`25`
`26`	`26`	`// custom coverage is lower than global coverage, and file is above global coverage`
`27`		`- if ($customCoverage < $globalCoverage && $metric->getCoverage() >= $globalCoverage) {`
	`27`	`+ if ($customCoverage <= $globalCoverage && $metric->getCoverage() >= $globalCoverage) {`
`28`	`28`	`return new Failure($metric, $fileConfig->getMinimumCoverage(), Failure::UNNECESSARY_CUSTOM_COVERAGE);`
`29`	`29`	`}`
`30`	`30`