'External' object is not subscriptable

[pawamoy]

I have this in a test:

snapshots_signatures = snapshot()

def test_thing():
    html = ...
    snapshot_key = (..., ...)
    assert outsource(html, suffix=".html") == snapshots_signatures[snapshot_key]

I tried migrating to the new external with UUID protocol:

snapshots_signatures = external("uuid:.html")

def test_thing():
    html = ...
    snapshot_key = (..., ...)
    assert html == snapshots_signatures[snapshot_key]

...but I'm getting this error: TypeError: 'External' object is not subscriptable.

Is there a way to migrate my current tests to the UUID protocol, or is this not possible for now?

[pawamoy]

Ah maybe I should just switch to external_file using a slightly updated snapshot_key as file name 😄

[pawamoy]

Yaaaaaaaay it's looking great 🚀

    snapshot_key = "snapshots/signatures/" + ",".join(f"{k}={v}" for k, v in sorted(final_options.items())) + ".html"
    assert html == external_file(snapshot_key, format=".txt")

[pawamoy]

One small thing: even though I added register_format_alias(".html", ".txt") at the top of the module, I still had to pass format=".txt" to the external_file(...) calls.

[15r10nk]

The way to switch to the uuid storage is to replace the first arg of external("a138a1837*.html") with the 'uuid:' -> external("uuid:"), inline-snapshot can then store the value with the uuid protocol. The problem is that the uuid protocol needs the function and filename, but outsource does not know where the external will be placed in the code when outsource() is called. I'm pretty sure that I can fix this in a future version ... but 4000 lines pr was enough 😄

and yes I think you found the first bug in external_file.

[pawamoy]

Thanks! So I'd just have to manually replace external args with "uuid:.html", then probably update snapshots again. Sounds good enough for something to do only once, when migrating from hash to uuid 🙂! Anyway, I much prefer using the low-level external_file now, for complete control over the file names 🥰 Awesome feature @15r10nk !