refactor: extract CLI env helper

Author: 1613358894

tests/test_cli_config.py

@@ -3,13 +3,37 @@
 import pytest
 
 from typetreeflow import cli
+from typetreeflow.cli_config import _env_value as config_env_value
 from typetreeflow.cli_config import _normalize_command_argv as config_normalize_argv
 
 
 def test_cli_normalize_command_argv_compatibility_export():
     assert cli._normalize_command_argv is config_normalize_argv
 
 
+def test_cli_env_value_compatibility_export():
+    assert cli._env_value is config_env_value
+
+
+def test_env_value_returns_stripped_set_value(monkeypatch):
+    monkeypatch.setenv("TYPETREEFLOW_EMAIL", " user@example.org ")
+
+    assert cli._env_value("TYPETREEFLOW_EMAIL") == "user@example.org"
+    assert config_env_value("TYPETREEFLOW_EMAIL") == "user@example.org"
+
+
+def test_env_value_returns_none_for_unset_or_blank_value(monkeypatch):
+    monkeypatch.delenv("TYPETREEFLOW_EMAIL", raising=False)
+
+    assert cli._env_value("TYPETREEFLOW_EMAIL") is None
+    assert config_env_value("TYPETREEFLOW_EMAIL") is None
+
+    monkeypatch.setenv("TYPETREEFLOW_EMAIL", "   ")
+
+    assert cli._env_value("TYPETREEFLOW_EMAIL") is None
+    assert config_env_value("TYPETREEFLOW_EMAIL") is None
+
+
 def test_normalize_command_aliases_preserves_existing_rewrites():
     assert config_normalize_argv(["doctor", "--strict"]) == (
         ["--doctor", "--doctor-strict"],

typetreeflow/cli.py

@@ -2,7 +2,6 @@
 
 import csv
 import logging
-import os
 import shutil
 import sys
 from dataclasses import dataclass, field, replace
@@ -16,7 +15,7 @@
     write_completion_summary,
 )
 from typetreeflow.completion_gaps import generate_completion_gap_reports
-from typetreeflow.cli_config import _normalize_command_argv
+from typetreeflow.cli_config import _env_value, _normalize_command_argv
 from typetreeflow.cli_parser import build_parser
 from typetreeflow.config import AppConfig, ensure_real_action_allowed
 from typetreeflow.delivery import package_results
@@ -317,14 +316,6 @@ def parse_args(argv: list[str] | None = None) -> AppConfig:
     )
 
 
-def _env_value(name: str) -> str | None:
-    value = os.environ.get(name)
-    if value is None:
-        return None
-    stripped = value.strip()
-    return stripped or None
-
-
 def main(
     argv: list[str] | None = None,
     download_runner=None,

typetreeflow/cli_config.py

@@ -1,8 +1,17 @@
 from __future__ import annotations
 
+import os
 import sys
 
 
+def _env_value(name: str) -> str | None:
+    value = os.environ.get(name)
+    if value is None:
+        return None
+    stripped = value.strip()
+    return stripped or None
+
+
 def _normalize_command_argv(
     argv: list[str] | None,
 ) -> tuple[list[str] | None, bool, bool]: