Skip to content

Commit 38e7e3a

Browse files
committed
Merge branch 'stages/rc-2025-03-27' into 'stages/prod'
Deploy RC 89 to Prod See merge request lg/identity-pki!84
2 parents 9de9bf7 + 3a445e5 commit 38e7e3a

File tree

4 files changed

+41
-3
lines changed

4 files changed

+41
-3
lines changed

Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ GEM
205205
net-protocol
206206
newrelic_rpm (8.16.0)
207207
nio4r (2.7.4)
208-
nokogiri (1.18.3)
208+
nokogiri (1.18.6)
209209
mini_portile2 (~> 2.8.2)
210210
racc (~> 1.4)
211211
pairing_heap (3.1.0)

app/models/certificate.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ def key_id
113113
end
114114

115115
def signing_key_id
116-
get_extension('authorityKeyIdentifier')&.lines&.grep(/\Akeyid:/)&.first
116+
get_extension('authorityKeyIdentifier')&.lines&.first
117117
&.sub(/\Akeyid:/, '')&.chomp&.upcase
118118
end
119119

k8files/application.yaml

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -417,6 +417,9 @@ spec:
417417
- op: replace
418418
path: /spec/template/spec/containers/0/image
419419
value: {{ECR_REGISTRY}}/identity-idp/idp:{{IDP_CONTAINER_TAG}}
420+
- op: replace
421+
path: /spec/template/spec/initContainers/0/image
422+
value: {{ECR_REGISTRY}}/identity-idp/idp:{{IDP_CONTAINER_TAG}}
420423
- op: replace
421424
path: /spec/template/spec/containers/0/imagePullPolicy
422425
value: Always
@@ -427,6 +430,9 @@ spec:
427430
- op: replace
428431
path: /spec/template/spec/containers/0/image
429432
value: {{ECR_REGISTRY}}/identity-idp/idp:{{IDP_CONTAINER_TAG}}
433+
- op: replace
434+
path: /spec/template/spec/initContainers/0/image
435+
value: {{ECR_REGISTRY}}/identity-idp/idp:{{IDP_CONTAINER_TAG}}
430436
- op: replace
431437
path: /spec/template/spec/containers/0/imagePullPolicy
432438
value: Always
@@ -437,6 +443,9 @@ spec:
437443
- op: replace
438444
path: /spec/template/spec/containers/0/image
439445
value: {{ECR_REGISTRY}}/identity-idp/idp:{{IDP_CONTAINER_TAG}}
446+
- op: replace
447+
path: /spec/template/spec/initContainers/0/image
448+
value: {{ECR_REGISTRY}}/identity-idp/idp:{{IDP_CONTAINER_TAG}}
440449
- op: replace
441450
path: /spec/template/spec/containers/0/imagePullPolicy
442451
value: Always
@@ -448,6 +457,9 @@ spec:
448457
- op: replace
449458
path: /spec/template/spec/containers/0/image
450459
value: {{ECR_REGISTRY}}/identity-dashboard/review:{{DASHBOARD_CONTAINER_TAG}}
460+
- op: replace
461+
path: /spec/template/spec/initContainers/0/image
462+
value: {{ECR_REGISTRY}}/identity-dashboard/review:{{DASHBOARD_CONTAINER_TAG}}
451463
- op: replace
452464
path: /spec/template/spec/containers/0/imagePullPolicy
453465
value: Always
@@ -458,6 +470,9 @@ spec:
458470
- op: replace
459471
path: /spec/template/spec/containers/0/image
460472
value: {{ECR_REGISTRY}}/identity-dashboard/review:{{DASHBOARD_CONTAINER_TAG}}
473+
- op: replace
474+
path: /spec/template/spec/initContainers/0/image
475+
value: {{ECR_REGISTRY}}/identity-dashboard/review:{{DASHBOARD_CONTAINER_TAG}}
461476
- op: replace
462477
path: /spec/template/spec/containers/0/imagePullPolicy
463478
value: Always
@@ -468,6 +483,9 @@ spec:
468483
- op: replace
469484
path: /spec/template/spec/containers/0/image
470485
value: {{ECR_REGISTRY}}/identity-dashboard/review:{{DASHBOARD_CONTAINER_TAG}}
486+
- op: replace
487+
path: /spec/template/spec/initContainers/0/image
488+
value: {{ECR_REGISTRY}}/identity-dashboard/review:{{DASHBOARD_CONTAINER_TAG}}
471489
- op: replace
472490
path: /spec/template/spec/containers/0/imagePullPolicy
473491
value: Always
@@ -513,6 +531,9 @@ spec:
513531
- op: replace
514532
path: /spec/template/spec/containers/1/image
515533
value: {{ECR_REGISTRY}}/identity-idp/idp:{{IDP_CONTAINER_TAG}}
534+
- op: replace
535+
path: /spec/template/spec/initContainers/0/image
536+
value: {{ECR_REGISTRY}}/identity-idp/idp:{{IDP_CONTAINER_TAG}}
516537
- op: replace
517538
path: /spec/template/spec/containers/0/imagePullPolicy
518539
value: Always
@@ -527,6 +548,9 @@ spec:
527548
- op: replace
528549
path: /spec/template/spec/containers/0/image
529550
value: {{ECR_REGISTRY}}/identity-idp/idp:{{IDP_CONTAINER_TAG}}
551+
- op: replace
552+
path: /spec/template/spec/initContainers/0/image
553+
value: {{ECR_REGISTRY}}/identity-idp/idp:{{IDP_CONTAINER_TAG}}
530554
- op: replace
531555
path: /spec/template/spec/containers/0/imagePullPolicy
532556
value: Always

spec/models/certificate_spec.rb

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@
308308

309309
describe '#signing_key_id' do
310310
it 'handles multiline authorityKeyIdentifier' do
311-
# stub multiline aKI
311+
# stub multiline authorityKeyIdentifier
312312
expect(certificate).to receive(:get_extension).with('authorityKeyIdentifier').and_return(
313313
<<~CERT
314314
keyid:cf:ab:b1:cf:b3:eb:28:e2:e0:c7:24:75:72:3b:f5:b6:31:18:77:6f
@@ -320,6 +320,20 @@
320320
'CF:AB:B1:CF:B3:EB:28:E2:E0:C7:24:75:72:3B:F5:B6:31:18:77:6F'
321321
)
322322
end
323+
324+
it 'handles multiline authorityKeyIdentifier without keyid prefix' do
325+
# stub multiline authorityKeyIdentifier
326+
expect(certificate).to receive(:get_extension).with('authorityKeyIdentifier').and_return(
327+
<<~CERT
328+
cf:ab:b1:cf:b3:eb:28:e2:e0:c7:24:75:72:3b:f5:b6:31:18:77:6f
329+
DirName:/CN=my test CA
330+
serial:89:20:39:72:B8:50:56:5E
331+
CERT
332+
)
333+
expect(certificate.signing_key_id).to eq(
334+
'CF:AB:B1:CF:B3:EB:28:E2:E0:C7:24:75:72:3B:F5:B6:31:18:77:6F'
335+
)
336+
end
323337
end
324338
end
325339

0 commit comments

Comments
 (0)