AttributeError: type object 'VaultOverview' has no attribute 'model_validate'

[alavi-sorrek]

Scenario & Reproduction Steps

Seems any time I try to list vaults or list items using the docs' suggestions, I'm thrown an attribute error related to model_validate for both items and vaults.

pip install git+https://github.com/1Password/[email protected]#egg=onepassword

import asyncio
from onepassword.client import Client

async def get_items():
    client = await Client.authenticate(auth=token, integration_name="secret_loader", integration_version="v1.0.0")
    vaults = await client.vaults.list_all()
    async for vault in vaults:
        print(vault.title)
        items = await client.items.list_all(vault.id)
        async for item in items:
            print(item.title)


asyncio.run(get_items())

Actual Behavior

AttributeError: type object 'VaultOverview' has no attribute 'model_validate'

Expected Behavior

I'm expecting to retrieve information related to vaults and items in them that are associated with my account

SDK version

No response

Additional information

No response

[hculea]

Hi @alavi-sorrek , thank you for reaching out. Can you please give me a few more details related to:

• the platform where you are running the SDK (OS + arch)
• the Python version that you use
• if you are running in any virtual environment, or if you use a pyproject.toml manifest to declare your project's dependencies

Looking forward to hearing back from you!

[alavi-sorrek]

I was definitely running on Python 3.9, and either on Ubuntu 22 or it was throwing the error on my Lambda - I can’t remember which here. I ended up using the 1password PyPi, which also had its own issues, but I was able to work around that.

…

On Thu, Sep 12, 2024 at 3:17 AM Horia Culea ***@***.***> wrote: Hi @alavi-sorrek <https://github.com/alavi-sorrek> , thank you for reaching out. Can you please give me a few more details related to: - the platform where you are running the SDK (OS + arch) - the Python version that you use - if you are running in any virtual environment, or if you use a pyproject.toml manifest to declare your project's dependencies Looking forward to hearing back from you! — Reply to this email directly, view it on GitHub <#109 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A2QBB54ZYMS3ZFPZ5Q3A2ADZWE5W3AVCNFSM6AAAAABN7LTIAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBVGQ2TGNJYGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[MOmarMiraj]

Hi @alavi-sorrek,

We pushed a fix for a bad commit when installing the Python SDK. Could you please retry and let me know if the error is still happening. If so, I have some follow up questions:

1. Did you try running the example.py code and does that work fine?
2. What version of pydantic are you using?

Looking forward to hearing from you!

[alavi-sorrek]

Thanks Mohammad - I’ll check it out this week!

…

On Tue, Sep 24, 2024 at 10:52 AM Mohammed Omar Miraj < ***@***.***> wrote: Hi @alavi-sorrek <https://github.com/alavi-sorrek>, We pushed a fix for a bad commit when installing the Python SDK. Could you please retry and let me know if the error is still happening. If so, I have some follow up questions: 1. Did you try running the example.py code and does that work fine? 2. What version of pydantic are you using? Looking forward to hearing from you! — Reply to this email directly, view it on GitHub <#109 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A2QBB54RN66WF4SMYROLHR3ZYF4BTAVCNFSM6AAAAABN7LTIAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZRGUZTQMBQGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[kumarnmanoj]

Hi @MOmarMiraj

We tried to list the vault and facing the same error. We followed the installation instructions provided in the README.

File "/.venv/lib/python3.10/site-packages/onepassword/vaults.py", line 28, in list_all
    objects = [VaultOverview.model_validate(data) for data in response_data]
File "/.venv/lib/python3.10/site-packages/onepassword/vaults.py", line 28, in <listcomp>
    objects = [VaultOverview.model_validate(data) for data in response_data]
AttributeError: type object 'VaultOverview' has no attribute 'model_validate'

Python Version - 3.10.7
pydantic = "^1.10.7"

[MOmarMiraj]

Hi @kumarnmanoj

Thanks for looking into this deeper and sorry your having trouble with this still.

It seems that the issue is your pydantic version. The minimum version of pydantic that the SDK requires is v2.5. Is it possible you update your pydantic version to a version thats greater than v2.5 and try again?

This is a dependancy we do not currently document and we will address this soon.

[kumarnmanoj]

Hi @MOmarMiraj

Thanks for the quick reply. We upgraded the pydantic to the latest version and it worked perfectly.

Thanks again.

[MOmarMiraj]

Im glad I could fix it, I will close the issue as this has been resolved!