G67

Author: 1T17

cppcheck_report.txt

@@ -13,90 +13,59 @@
 // Maximum input size to prevent buffer overflows
 #define MAX_INPUT_SIZE (1024 * 1024) // 1MB limit
 
-// Fixed function signature to match Node.js FFI binding
 const char* compile_ggcode_from_string(const char* source_code) {
     clock_t start_time = clock();
-
-    // Input validation
     if (!source_code) {
         return strdup("; ERROR: NULL input\n");
     }
-    
-    // Check input length to prevent buffer overflows
     size_t input_len = strlen(source_code);
     if (input_len == 0) {
         return strdup("; EMPTY INPUT\n");
     }
-    
     if (input_len > MAX_INPUT_SIZE) {
         return strdup("; ERROR: Input too large (max 1MB)\n");
     }
-
-    // Initialize runtime state properly (no global contamination)
     init_runtime();
     Runtime* runtime = get_runtime();
-
-    runtime->statement_count = 0;  // Use runtime state instead of global
-
-    // Initialize output buffer
+    runtime->statement_count = 0;
     init_output_buffer();
-    
-    // Parse and compile
     ASTNode* root = parse_script_from_string(source_code);
-    
     if (!root) {
         reset_runtime_state();
         free_output_buffer();
         return strdup("; ERROR: Parsing failed\n");
     }
-    
-    // Set runtime state variables for note block parsing BEFORE emit_gcode
     char ggcode_file_name[64];
     snprintf(ggcode_file_name, sizeof(ggcode_file_name), "nodejs.ggcode");
-    
     Runtime *rt = get_runtime();
     strncpy(rt->RUNTIME_FILENAME, ggcode_file_name, sizeof(rt->RUNTIME_FILENAME) - 1);
     rt->RUNTIME_FILENAME[sizeof(rt->RUNTIME_FILENAME) - 1] = '\0';
-    
-    // Set current time
     char time_line[64];
     time_t now = time(NULL);
     struct tm *t = localtime(&now);
     strftime(time_line, sizeof(time_line), "%Y-%m-%d %H:%M:%S", t);
     strncpy(rt->RUNTIME_TIME, time_line, sizeof(rt->RUNTIME_TIME) - 1);
     rt->RUNTIME_TIME[sizeof(rt->RUNTIME_TIME) - 1] = '\0';
-    
     emit_gcode(root);
-
-    // Generate G-code header
     emit_gcode_preamble(ggcode_file_name);
-
-    // Get output and check for errors
     const char* output = strdup(get_output_buffer());
     long output_size = get_output_length();
-    
     if (has_errors()) {
         report_error("[NodeJS] Compilation failed or errors detected");
         print_errors();
         clear_errors();
-        free((void*)output);  // Free the output we just allocated
+        free((void*)output);
         reset_runtime_state();
         free_ast(root);
         free_output_buffer();
         return strdup("; ERROR: Compilation failed\n");
     }
-
-    // Print basic compilation report for successful compilation
     clock_t end_time = clock();
     double elapsed = ((double)(end_time - start_time)) / CLOCKS_PER_SEC * 1000.0;
-    fprintf(stderr, "GGcode: Compiled %zu bytes → %ld bytes in %.2fms\n", 
-           input_len, output_size, elapsed);
-
-    // Cleanup
+    fprintf(stderr, "GGcode: Compiled %zu bytes \u2192 %ld bytes in %.2fms\n", input_len, output_size, elapsed);
     reset_runtime_state();
     free_ast(root);
     free_output_buffer();
-    
     return output;
 }
 

src/bindings/nodejs.c

@@ -35,10 +35,6 @@ Runtime* get_runtime() {
     return &g_runtime;
 }
 
-void set_input_file(const char* filename) {
-    input_file = filename;
-}
-
 const char* get_input_file() {
     return input_file;
 }

src/config/config.c

@@ -56,12 +56,6 @@ Value *make_number_value(double num)
     return val;
 }
 
-int get_statement_count()
-{
-    Runtime *rt = get_runtime();
-    return rt->statement_count;
-}
-
 // Global flag to reset emitter state
 static int emitter_reset_flag = 0;
 

src/generator/emitter.c

@@ -24,11 +24,3 @@ Token make_token(Token_Type type, const char *value, int line, int column) {
 
 
 
-/// @brief Free memory allocated for a token's value
-void token_free(Token token) {
-    if (token.value) {
-        free(token.value);
-    }
-}
-
-

src/lexer/token_utils.c

@@ -3,105 +3,4 @@
 #include <string.h>
 #include "../error/error.h"
 
-// Helper functions for common AST node creation patterns
-
-ASTNode* create_number_node(double value) {
-    ASTNode *ast_node = malloc(sizeof(ASTNode));
-    if (!ast_node) {
-        report_error("[AST] malloc failed for ASTNode");
-        return NULL;
-    }
-    ast_node->type = AST_NUMBER;
-    ast_node->parent = NULL;
-    ast_node->number.value = value;
-    return ast_node;
-}
-
-ASTNode* create_var_node(const char* name) {
-    ASTNode *ast_node = malloc(sizeof(ASTNode));
-    if (!ast_node) {
-        report_error("[AST] malloc failed for ASTNode");
-        return NULL;
-    }
-    ast_node->type = AST_VAR;
-    ast_node->parent = NULL;
-    ast_node->var.name = strdup(name);
-    if (!ast_node->var.name) {
-        report_error("[AST] strdup failed for variable name");
-        free(ast_node);
-        return NULL;
-    }
-    return ast_node;
-}
-
-ASTNode* create_binary_node(Token_Type op, ASTNode* left, ASTNode* right) {
-    ASTNode *ast_node = malloc(sizeof(ASTNode));
-    if (!ast_node) {
-        report_error("[AST] malloc failed for ASTNode");
-        return NULL;
-    }
-    ast_node->type = AST_BINARY;
-    ast_node->parent = NULL;
-    ast_node->binary_expr.op = op;
-    ast_node->binary_expr.left = left;
-    ast_node->binary_expr.right = right;
-    return ast_node;
-}
-
-ASTNode* create_unary_node(Token_Type op, ASTNode* operand) {
-    ASTNode *ast_node = malloc(sizeof(ASTNode));
-    if (!ast_node) {
-        report_error("[AST] malloc failed for ASTNode");
-        return NULL;
-    }
-    ast_node->type = AST_UNARY;
-    ast_node->parent = NULL;
-    ast_node->unary_expr.op = op;
-    ast_node->unary_expr.operand = operand;
-    return ast_node;
-}
-
-ASTNode* create_call_node(const char* name, ASTNode** args, int arg_count) {
-    ASTNode *ast_node = malloc(sizeof(ASTNode));
-    if (!ast_node) {
-        report_error("[AST] malloc failed for ASTNode");
-        return NULL;
-    }
-    ast_node->type = AST_CALL;
-    ast_node->parent = NULL;
-    ast_node->call_expr.name = strdup(name);
-    if (!ast_node->call_expr.name) {
-        report_error("[AST] strdup failed for function name");
-        free(ast_node);
-        return NULL;
-    }
-    ast_node->call_expr.args = args;
-    ast_node->call_expr.arg_count = arg_count;
-    return ast_node;
-}
-
-ASTNode* create_array_literal_node(ASTNode** elements, int count) {
-    ASTNode *ast_node = malloc(sizeof(ASTNode));
-    if (!ast_node) {
-        report_error("[AST] malloc failed for ASTNode");
-        return NULL;
-    }
-    ast_node->type = AST_ARRAY_LITERAL;
-    ast_node->parent = NULL;
-    ast_node->array_literal.elements = elements;
-    ast_node->array_literal.count = count;
-    return ast_node;
-}
-
-ASTNode* create_block_node(ASTNode** statements, int count) {
-    ASTNode *ast_node = malloc(sizeof(ASTNode));
-    if (!ast_node) {
-        report_error("[AST] malloc failed for ASTNode");
-        return NULL;
-    }
-    ast_node->type = AST_BLOCK;
-    ast_node->parent = NULL;
-    ast_node->block.statements = statements;
-    ast_node->block.count = count;
-    return ast_node;
-}
+// Helper functions for common AST node creation patterns

src/parser/ast_helpers.c

@@ -13,14 +13,8 @@
 #define PARSE_ERROR(msg, ...) \
     fatal_error(get_runtime()->parser.lexer->source, get_runtime()->parser.current.line, get_runtime()->parser.current.column, msg, ##__VA_ARGS__)
 
-static int gcode_mode_active = 0;
 // Parser moved to runtime state - no more global parser
 
-// Function to reset parser static variables
-void reset_parser_static_vars(void) {
-    gcode_mode_active = 0;
-}
-
 static ASTNode *parse_binary_expression();
 static ASTNode *parse_block();
 static ASTNode *parse_while();
@@ -38,8 +32,9 @@ static ASTNode *parse_return();
 static ASTNode *parse_postfix_expression(); // <-- add this
 
 // Forward declaration
-Token lexer_peek_token(Lexer *lexer);
 
+// Restore static variable needed by parse_gcode
+static int gcode_mode_active = 0;
 
 /// @brief step 2
 /// @return
@@ -1149,15 +1144,3 @@ case AST_EXPR_STMT:
 
     free(node);
 }
-
-Token lexer_peek_token(Lexer *lexer)
-{
-    int saved_pos = lexer->pos;
-    int saved_column = lexer->column;
-
-    Token next = lexer_next_token(lexer);
-
-    lexer->pos = saved_pos;
-    lexer->column = saved_column;
-    return next;
-}