Allow users to add error details during manual response creation

1eyewonder · 1eyewonder · commit 7e736746c135 · 2021-12-09T14:19:42.000-06:00
diff --git a/ExceptionAll.APIExample/ExceptionAll.APIExample.csproj b/ExceptionAll.APIExample/ExceptionAll.APIExample.csproj
@@ -5,9 +5,9 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="FluentValidation" Version="10.3.0" />
-    <PackageReference Include="FluentValidation.AspNetCore" Version="10.3.0" />
-    <PackageReference Include="Swashbuckle.AspNetCore" Version="6.1.5" />
+    <PackageReference Include="FluentValidation" Version="10.3.5" />
+    <PackageReference Include="FluentValidation.AspNetCore" Version="10.3.5" />
+    <PackageReference Include="Swashbuckle.AspNetCore" Version="6.2.3" />
   </ItemGroup>
 
   <ItemGroup>
diff --git a/ExceptionAll.Tests/ExceptionAll.Tests.csproj b/ExceptionAll.Tests/ExceptionAll.Tests.csproj
@@ -9,7 +9,7 @@
   <ItemGroup>
     <PackageReference Include="Microsoft.AspNetCore.Http" Version="2.2.2" />
     <PackageReference Include="Microsoft.AspNetCore.Mvc.Abstractions" Version="2.2.0" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.10.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.0.0" />
     <PackageReference Include="Moq" Version="4.16.1" />
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
diff --git a/ExceptionAll/Details/BadRequestDetails.cs b/ExceptionAll/Details/BadRequestDetails.cs
@@ -2,24 +2,24 @@
 
 public class BadRequestDetails : BaseDetails
 {
-    public BadRequestDetails(ActionContext context, string title = null, string message = null, List<ErrorDetail> errors = null) :
+    public BadRequestDetails(ActionContext context, string? title = null, string? message = null, List<ErrorDetail>? errors = null) :
         base(
         context ?? throw new ArgumentNullException(nameof(context)),
         string.IsNullOrEmpty(title) ? "Bad Request" : title,
         context.HttpContext.Request.Path,
         StatusCodes.Status400BadRequest,
         string.IsNullOrEmpty (message) ? "See errors or logs for more details" : message,
-        errors)
+        errors ?? new List<ErrorDetail>())
     { 
     }
-    public BadRequestDetails(ExceptionContext context, string title = null, string message = null, List<ErrorDetail> errors = null) :
+    public BadRequestDetails(ExceptionContext context, string? title = null, string? message = null, List<ErrorDetail>? errors = null) :
         base(
         context ?? throw new ArgumentNullException(nameof(context)),
         string.IsNullOrEmpty(title) ? "Bad Request" : title,
         context.HttpContext.Request.Path,
         StatusCodes.Status400BadRequest,
         string.IsNullOrEmpty(message) ? "See errors or logs for more details" : message,
-        errors)
+        errors ?? new List<ErrorDetail>())
     {
     }
 }
diff --git a/ExceptionAll/Details/ForbiddenDetails.cs b/ExceptionAll/Details/ForbiddenDetails.cs
@@ -2,24 +2,24 @@
 
 public class ForbiddenDetails : BaseDetails
 {
-    public ForbiddenDetails(ActionContext context, string title = null, string message = null, List<ErrorDetail> errors = null) :
+    public ForbiddenDetails(ActionContext context, string? title = null, string? message = null, List<ErrorDetail>? errors = null) :
         base(
         context ?? throw new ArgumentNullException(nameof(context)),
         string.IsNullOrEmpty(title) ? "Forbidden" : title,
         context.HttpContext.Request.Path,
         StatusCodes.Status403Forbidden,
         string.IsNullOrEmpty(message) ? "See errors or logs for more details" : message,
-        errors)
+        errors ?? new List<ErrorDetail>())
     {
     }
-    public ForbiddenDetails(ExceptionContext context, string title = null, string message = null, List<ErrorDetail> errors = null) :
+    public ForbiddenDetails(ExceptionContext context, string? title = null, string? message = null, List<ErrorDetail>? errors = null) :
         base(
         context ?? throw new ArgumentNullException(nameof(context)),
         string.IsNullOrEmpty(title) ? "Forbidden" : title,
         context.HttpContext.Request.Path,
         StatusCodes.Status403Forbidden,
         string.IsNullOrEmpty(message) ? "See errors or logs for more details" : message,
-        errors)
+        errors ?? new List<ErrorDetail>())
     {
     }
 }
diff --git a/ExceptionAll/Details/InternalServerErrorDetails.cs b/ExceptionAll/Details/InternalServerErrorDetails.cs
@@ -2,24 +2,24 @@
 
 public class InternalServerErrorDetails : BaseDetails
 {
-    public InternalServerErrorDetails(ActionContext context, string title = null, string message = null, List<ErrorDetail> errors = null) :
+    public InternalServerErrorDetails(ActionContext context, string? title = null, string? message = null, List<ErrorDetail>? errors = null) :
         base(
         context ?? throw new ArgumentNullException(nameof(context)),
         string.IsNullOrEmpty(title) ? "Internal Server Error" : title,
         context.HttpContext.Request.Path,
         StatusCodes.Status500InternalServerError,
         string.IsNullOrEmpty(message) ? "See errors or logs for more details" : message,
-        errors)
+        errors ?? new List<ErrorDetail>())
     {
     }
-    public InternalServerErrorDetails(ExceptionContext context, string title = null, string message = null, List<ErrorDetail> errors = null) :
+    public InternalServerErrorDetails(ExceptionContext context, string? title = null, string? message = null, List<ErrorDetail>? errors = null) :
         base(
         context ?? throw new ArgumentNullException(nameof(context)),
         string.IsNullOrEmpty(title) ? "Internal Server Error" : title,
         context.HttpContext.Request.Path,
         StatusCodes.Status500InternalServerError,
         string.IsNullOrEmpty(message) ? "See errors or logs for more details" : message,
-        errors)
+        errors ?? new List<ErrorDetail>())
     {
     }
 }
diff --git a/ExceptionAll/Details/NotFoundDetails.cs b/ExceptionAll/Details/NotFoundDetails.cs
@@ -2,24 +2,24 @@
 
 public class NotFoundDetails : BaseDetails
 {
-    public NotFoundDetails(ActionContext context, string title = null, string message = null, List<ErrorDetail> errors = null) :
+    public NotFoundDetails(ActionContext context, string? title = null, string? message = null, List<ErrorDetail>? errors = null) :
         base(
         context ?? throw new ArgumentNullException(nameof(context)),
         string.IsNullOrEmpty(title) ? "Not Found" : title,
         context.HttpContext.Request.Path,
         StatusCodes.Status404NotFound,
         string.IsNullOrEmpty(message) ? "See errors or logs for more details" : message,
-        errors)
+        errors ?? new List<ErrorDetail>())
     {
     }
-    public NotFoundDetails(ExceptionContext context, string title = null, string message = null, List<ErrorDetail> errors = null) :
+    public NotFoundDetails(ExceptionContext context, string? title = null, string? message = null, List<ErrorDetail>? errors = null) :
         base(
         context ?? throw new ArgumentNullException(nameof(context)),
         string.IsNullOrEmpty(title) ? "Not Found" : title,
         context.HttpContext.Request.Path,
         StatusCodes.Status404NotFound,
         string.IsNullOrEmpty(message) ? "See errors or logs for more details" : message,
-        errors)
+        errors ?? new List<ErrorDetail>())
     {
     }
 }
diff --git a/ExceptionAll/Details/UnauthorizedDetails.cs b/ExceptionAll/Details/UnauthorizedDetails.cs
@@ -2,24 +2,24 @@
 
 public class UnauthorizedDetails : BaseDetails
 {
-    public UnauthorizedDetails(ActionContext context, string title = null, string message = null, List<ErrorDetail> errors = null) :
+    public UnauthorizedDetails(ActionContext context, string? title = null, string? message = null, List<ErrorDetail>? errors = null) :
         base(
         context ?? throw new ArgumentNullException(nameof(context)),
         string.IsNullOrEmpty(title) ? "Unauthorized" : title,
         context.HttpContext.Request.Path,
         StatusCodes.Status401Unauthorized,
         string.IsNullOrEmpty(message) ? "See errors or logs for more details" : message,
-        errors)
+        errors ?? new List<ErrorDetail>())
     {
     }
-    public UnauthorizedDetails(ExceptionContext context, string title = null, string message = null, List<ErrorDetail> errors = null) :
+    public UnauthorizedDetails(ExceptionContext context, string? title = null, string? message = null, List<ErrorDetail>? errors = null) :
         base(
         context ?? throw new ArgumentNullException(nameof(context)),
         string.IsNullOrEmpty(title) ? "Unauthorized" : title,
         context.HttpContext.Request.Path,
         StatusCodes.Status401Unauthorized,
         string.IsNullOrEmpty(message) ? "See errors or logs for more details" : message,
-        errors)
+        errors ?? new List<ErrorDetail>())
     {
     }
 }
diff --git a/ExceptionAll/ExceptionAll.csproj b/ExceptionAll/ExceptionAll.csproj
@@ -13,14 +13,17 @@
 	  <Authors>Bronson Bata</Authors>
     <AssemblyVersion>1.1.0.0</AssemblyVersion>
     <FileVersion>1.1.0.0</FileVersion>
-    <Version>3.0.0</Version>
+    <Version>3.1.0</Version>
+    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="FluentValidation" Version="10.3.0" />
+    <PackageReference Include="FluentValidation" Version="10.3.5" />
     <PackageReference Include="Microsoft.AspNetCore.Mvc" Version="2.2.0" />
-    <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="5.0.2" />
-    <PackageReference Include="Microsoft.Extensions.Logging" Version="5.0.0" />
+    <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="6.0.0" />
+    <PackageReference Include="Microsoft.Extensions.Logging" Version="6.0.0" />
+    <PackageReference Include="Moq" Version="4.16.1" />
+    <PackageReference Include="Swashbuckle.AspNetCore.Filters" Version="7.0.2" />
   </ItemGroup>
 
 </Project>
diff --git a/ExceptionAll/GlobalUsings.cs b/ExceptionAll/GlobalUsings.cs
@@ -8,4 +8,5 @@
 global using FluentValidation;
 global using ExceptionAll.Validation;
 global using Microsoft.Extensions.Logging;
-global using System.Reflection;
+global using System.Reflection;
+global using Swashbuckle.AspNetCore.Filters;
diff --git a/ExceptionAll/Helpers/ProblemDetailsHelper.cs b/ExceptionAll/Helpers/ProblemDetailsHelper.cs
@@ -4,7 +4,7 @@ public static class ProblemDetailsHelper
 {
     public static void AddDefaultExtensionsFromContext(this BaseDetails details,
         ActionContext context,
-        List<ErrorDetail> errors = null)
+        List<ErrorDetail>? errors = null)
     {
         foreach (var (key, value) in GetExtensionsFromContext(context, errors))
         {
@@ -14,7 +14,7 @@ public static void AddDefaultExtensionsFromContext(this BaseDetails details,
 
     public static void AddDefaultExtensionsFromContext(this BaseDetails details,
         ExceptionContext context,
-        List<ErrorDetail> errors = null)
+        List<ErrorDetail>? errors = null)
     {
         foreach (var (key, value) in GetExtensionsFromContext(context, errors))
         {
@@ -23,12 +23,12 @@ public static void AddDefaultExtensionsFromContext(this BaseDetails details,
     }
 
     private static IDictionary<string, object> GetExtensionsFromContext(ActionContext context,
-        List<ErrorDetail> errors = null)
+        List<ErrorDetail>? errors = null)
     {
         var dictionary = new Dictionary<string, object>
             {
                 {"Method", context.HttpContext.Request.Method },
-                {"QueryString", context.HttpContext.Request.QueryString.Value },
+                {"QueryString", context.HttpContext.Request.QueryString.Value ?? string.Empty },
                 {"CorrelationId", context.HttpContext.Request.Headers["x-correlation-id"].ToString() },
                 {"TraceId", context.HttpContext.TraceIdentifier }
             };
@@ -39,12 +39,12 @@ private static IDictionary<string, object> GetExtensionsFromContext(ActionContex
     }
 
     private static IDictionary<string, object> GetExtensionsFromContext(ExceptionContext context,
-        List<ErrorDetail> errors = null)
+        List<ErrorDetail>? errors = null)
     {
         var dictionary = new Dictionary<string, object>
             {
                 {"Method", context.HttpContext.Request.Method },
-                {"QueryString", context.HttpContext.Request.QueryString.Value },
+                {"QueryString", context.HttpContext.Request.QueryString.Value ?? string.Empty },
                 {"CorrelationId", context.HttpContext.Request.Headers["x-correlation-id"].ToString() },
                 {"TraceId", context.HttpContext.TraceIdentifier }
             };
@@ -54,22 +54,15 @@ private static IDictionary<string, object> GetExtensionsFromContext(ExceptionCon
         return dictionary;
     }
 
-    public static ConstructorInfo GetActionContextConstructor<T>()
+    public static ConstructorInfo? GetActionContextConstructor<T>()
         where T : BaseDetails
     {
-        try
+        return typeof(T).GetConstructor(new[]
         {
-            return typeof(T).GetConstructor(new[]
-            {
-                    typeof(ActionContext),
-                    typeof(string),
-                    typeof(string),
-                    typeof(List<ErrorDetail>)
-                });
-        }
-        catch (Exception e)
-        {
-            throw new Exception($"Error creating constructor for type: {typeof(T)}", e);
-        }
+            typeof(ActionContext),
+            typeof(string),
+            typeof(string),
+            typeof(List<ErrorDetail>)
+        });
     }
 }
diff --git a/ExceptionAll/Interfaces/IActionResultService.cs b/ExceptionAll/Interfaces/IActionResultService.cs
@@ -18,6 +18,7 @@ public interface IActionResultService
     /// <typeparam name="T"></typeparam>
     /// <param name="context">ControllerContext</param>
     /// <param name="message">Optional developer message</param>
+    /// <param name="errors"></param>
     /// <returns></returns>
-    IActionResult GetResponse<T>(ActionContext context, string message = null) where T : BaseDetails;
+    IActionResult GetResponse<T>(ActionContext context, string? message = null, IEnumerable<ErrorDetail>? errors = null) where T : BaseDetails;
 }
diff --git a/ExceptionAll/Services/ActionResultService.cs b/ExceptionAll/Services/ActionResultService.cs
@@ -16,16 +16,21 @@ public IActionResult GetErrorResponse(ExceptionContext context)
     {
         BaseDetails details;
         if (_errorResponseService.GetErrorResponses()
-            .TryGetValue(context.Exception.GetType(),
-            out var response))
+                                 .TryGetValue(
+                                     context.Exception.GetType(),
+                                     out var response))
         {
             new ErrorResponseValidator().ValidateAndThrow(response);
             var constructorInfo = GetExceptionContextConstructor(response.DetailsType);
 
-            details = (BaseDetails)constructorInfo.Invoke(new object[]
-            {
+            if (constructorInfo is null)
+                throw new Exception("Could not find the specified constructor");
+
+            details = (BaseDetails)constructorInfo.Invoke(
+                new object[]
+                {
                     context, response.ErrorTitle, null, null
-            });
+                });
 
             if (details.Status != null)
             {
@@ -37,7 +42,7 @@ public IActionResult GetErrorResponse(ExceptionContext context)
         else
         {
             context.HttpContext.Response.StatusCode = StatusCodes.Status500InternalServerError;
-            details = new InternalServerErrorDetails(context, "Internal Server Error");
+            details                                 = new InternalServerErrorDetails(context, "Internal Server Error");
             Logger.LogError(context.Exception, "Error encountered when accessing resource");
         }
 
@@ -47,21 +52,27 @@ public IActionResult GetErrorResponse(ExceptionContext context)
         };
     }
 
-    public IActionResult GetResponse<T>(ActionContext context, string message = null) where T : BaseDetails
+    public IActionResult GetResponse<T>(ActionContext context, string? message = null, IEnumerable<ErrorDetail>? errors = null) where T : BaseDetails
     {
         T details;
         if (!typeof(T).IsSubclassOf(typeof(BaseDetails)) &&
             typeof(T) == typeof(BaseDetails))
         {
             var e = new Exception("ProblemDetails is not an acceptable type");
-            Logger.LogError(e, "ProblemDetails is not a valid type for this class. Please refer to documentation for assistance");
+            Logger.LogError(
+                e,
+                "ProblemDetails is not a valid type for this class. Please refer to documentation for assistance");
             throw e;
         }
 
         try
         {
             var constructorInfo = ProblemDetailsHelper.GetActionContextConstructor<T>();
-            details = (T)constructorInfo.Invoke(new object[] { context, "Caught Exception", message, null });
+            if (constructorInfo is null)
+                throw new Exception("Could not find the specified constructor");
+
+            details = (T)constructorInfo.Invoke(
+                new object[] { context, "Caught Exception", message, errors?.ToList() });
         }
         catch (Exception e)
         {
@@ -79,21 +90,14 @@ public IActionResult GetResponse<T>(ActionContext context, string message = null
         };
     }
 
-    private static ConstructorInfo GetExceptionContextConstructor(Type type)
+    private static ConstructorInfo? GetExceptionContextConstructor(Type type)
     {
-        try
+        return type.GetConstructor(new[]
         {
-            return type.GetConstructor(new[]
-            {
-                    typeof(ExceptionContext),
-                    typeof(string),
-                    typeof(string),
-                    typeof(List<ErrorDetail>)
-                });
-        }
-        catch (Exception e)
-        {
-            throw new Exception($"Error creating constructor for type: {type}", e);
-        }
+            typeof(ExceptionContext),
+            typeof(string),
+            typeof(string),
+            typeof(List<ErrorDetail>)
+        });
     }
 }
diff --git a/ExceptionAll/Swagger/BadRequestDetailsExample.cs b/ExceptionAll/Swagger/BadRequestDetailsExample.cs
@@ -0,0 +1,9 @@
+﻿namespace ExceptionAll.Swagger;
+
+public class BadRequestDetailsExample : IExamplesProvider<BadRequestDetails>
+{
+    public BadRequestDetails GetExamples()
+    {
+        throw new NotImplementedException();
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -2,24 +2,24 @@`
`2`	`2`
`3`	`3`	`public class BadRequestDetails : BaseDetails`
`4`	`4`	`{`
`5`		`- public BadRequestDetails(ActionContext context, string title = null, string message = null, List<ErrorDetail> errors = null) :`
	`5`	`+ public BadRequestDetails(ActionContext context, string? title = null, string? message = null, List<ErrorDetail>? errors = null) :`
`6`	`6`	`base(`
`7`	`7`	`context ?? throw new ArgumentNullException(nameof(context)),`
`8`	`8`	`string.IsNullOrEmpty(title) ? "Bad Request" : title,`
`9`	`9`	`context.HttpContext.Request.Path,`
`10`	`10`	`StatusCodes.Status400BadRequest,`
`11`	`11`	`string.IsNullOrEmpty (message) ? "See errors or logs for more details" : message,`
`12`		`- errors)`
	`12`	`+ errors ?? new List<ErrorDetail>())`
`13`	`13`	`{`
`14`	`14`	`}`
`15`		`- public BadRequestDetails(ExceptionContext context, string title = null, string message = null, List<ErrorDetail> errors = null) :`
	`15`	`+ public BadRequestDetails(ExceptionContext context, string? title = null, string? message = null, List<ErrorDetail>? errors = null) :`
`16`	`16`	`base(`
`17`	`17`	`context ?? throw new ArgumentNullException(nameof(context)),`
`18`	`18`	`string.IsNullOrEmpty(title) ? "Bad Request" : title,`
`19`	`19`	`context.HttpContext.Request.Path,`
`20`	`20`	`StatusCodes.Status400BadRequest,`
`21`	`21`	`string.IsNullOrEmpty(message) ? "See errors or logs for more details" : message,`
`22`		`- errors)`
	`22`	`+ errors ?? new List<ErrorDetail>())`
`23`	`23`	`{`
`24`	`24`	`}`
`25`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,24 +2,24 @@`
`2`	`2`
`3`	`3`	`public class ForbiddenDetails : BaseDetails`
`4`	`4`	`{`
`5`		`- public ForbiddenDetails(ActionContext context, string title = null, string message = null, List<ErrorDetail> errors = null) :`
	`5`	`+ public ForbiddenDetails(ActionContext context, string? title = null, string? message = null, List<ErrorDetail>? errors = null) :`
`6`	`6`	`base(`
`7`	`7`	`context ?? throw new ArgumentNullException(nameof(context)),`
`8`	`8`	`string.IsNullOrEmpty(title) ? "Forbidden" : title,`
`9`	`9`	`context.HttpContext.Request.Path,`
`10`	`10`	`StatusCodes.Status403Forbidden,`
`11`	`11`	`string.IsNullOrEmpty(message) ? "See errors or logs for more details" : message,`
`12`		`- errors)`
	`12`	`+ errors ?? new List<ErrorDetail>())`
`13`	`13`	`{`
`14`	`14`	`}`
`15`		`- public ForbiddenDetails(ExceptionContext context, string title = null, string message = null, List<ErrorDetail> errors = null) :`
	`15`	`+ public ForbiddenDetails(ExceptionContext context, string? title = null, string? message = null, List<ErrorDetail>? errors = null) :`
`16`	`16`	`base(`
`17`	`17`	`context ?? throw new ArgumentNullException(nameof(context)),`
`18`	`18`	`string.IsNullOrEmpty(title) ? "Forbidden" : title,`
`19`	`19`	`context.HttpContext.Request.Path,`
`20`	`20`	`StatusCodes.Status403Forbidden,`
`21`	`21`	`string.IsNullOrEmpty(message) ? "See errors or logs for more details" : message,`
`22`		`- errors)`
	`22`	`+ errors ?? new List<ErrorDetail>())`
`23`	`23`	`{`
`24`	`24`	`}`
`25`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,24 +2,24 @@`
`2`	`2`
`3`	`3`	`public class InternalServerErrorDetails : BaseDetails`
`4`	`4`	`{`
`5`		`- public InternalServerErrorDetails(ActionContext context, string title = null, string message = null, List<ErrorDetail> errors = null) :`
	`5`	`+ public InternalServerErrorDetails(ActionContext context, string? title = null, string? message = null, List<ErrorDetail>? errors = null) :`
`6`	`6`	`base(`
`7`	`7`	`context ?? throw new ArgumentNullException(nameof(context)),`
`8`	`8`	`string.IsNullOrEmpty(title) ? "Internal Server Error" : title,`
`9`	`9`	`context.HttpContext.Request.Path,`
`10`	`10`	`StatusCodes.Status500InternalServerError,`
`11`	`11`	`string.IsNullOrEmpty(message) ? "See errors or logs for more details" : message,`
`12`		`- errors)`
	`12`	`+ errors ?? new List<ErrorDetail>())`
`13`	`13`	`{`
`14`	`14`	`}`
`15`		`- public InternalServerErrorDetails(ExceptionContext context, string title = null, string message = null, List<ErrorDetail> errors = null) :`
	`15`	`+ public InternalServerErrorDetails(ExceptionContext context, string? title = null, string? message = null, List<ErrorDetail>? errors = null) :`
`16`	`16`	`base(`
`17`	`17`	`context ?? throw new ArgumentNullException(nameof(context)),`
`18`	`18`	`string.IsNullOrEmpty(title) ? "Internal Server Error" : title,`
`19`	`19`	`context.HttpContext.Request.Path,`
`20`	`20`	`StatusCodes.Status500InternalServerError,`
`21`	`21`	`string.IsNullOrEmpty(message) ? "See errors or logs for more details" : message,`
`22`		`- errors)`
	`22`	`+ errors ?? new List<ErrorDetail>())`
`23`	`23`	`{`
`24`	`24`	`}`
`25`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,24 +2,24 @@`
`2`	`2`
`3`	`3`	`public class NotFoundDetails : BaseDetails`
`4`	`4`	`{`
`5`		`- public NotFoundDetails(ActionContext context, string title = null, string message = null, List<ErrorDetail> errors = null) :`
	`5`	`+ public NotFoundDetails(ActionContext context, string? title = null, string? message = null, List<ErrorDetail>? errors = null) :`
`6`	`6`	`base(`
`7`	`7`	`context ?? throw new ArgumentNullException(nameof(context)),`
`8`	`8`	`string.IsNullOrEmpty(title) ? "Not Found" : title,`
`9`	`9`	`context.HttpContext.Request.Path,`
`10`	`10`	`StatusCodes.Status404NotFound,`
`11`	`11`	`string.IsNullOrEmpty(message) ? "See errors or logs for more details" : message,`
`12`		`- errors)`
	`12`	`+ errors ?? new List<ErrorDetail>())`
`13`	`13`	`{`
`14`	`14`	`}`
`15`		`- public NotFoundDetails(ExceptionContext context, string title = null, string message = null, List<ErrorDetail> errors = null) :`
	`15`	`+ public NotFoundDetails(ExceptionContext context, string? title = null, string? message = null, List<ErrorDetail>? errors = null) :`
`16`	`16`	`base(`
`17`	`17`	`context ?? throw new ArgumentNullException(nameof(context)),`
`18`	`18`	`string.IsNullOrEmpty(title) ? "Not Found" : title,`
`19`	`19`	`context.HttpContext.Request.Path,`
`20`	`20`	`StatusCodes.Status404NotFound,`
`21`	`21`	`string.IsNullOrEmpty(message) ? "See errors or logs for more details" : message,`
`22`		`- errors)`
	`22`	`+ errors ?? new List<ErrorDetail>())`
`23`	`23`	`{`
`24`	`24`	`}`
`25`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,24 +2,24 @@`
`2`	`2`
`3`	`3`	`public class UnauthorizedDetails : BaseDetails`
`4`	`4`	`{`
`5`		`- public UnauthorizedDetails(ActionContext context, string title = null, string message = null, List<ErrorDetail> errors = null) :`
	`5`	`+ public UnauthorizedDetails(ActionContext context, string? title = null, string? message = null, List<ErrorDetail>? errors = null) :`
`6`	`6`	`base(`
`7`	`7`	`context ?? throw new ArgumentNullException(nameof(context)),`
`8`	`8`	`string.IsNullOrEmpty(title) ? "Unauthorized" : title,`
`9`	`9`	`context.HttpContext.Request.Path,`
`10`	`10`	`StatusCodes.Status401Unauthorized,`
`11`	`11`	`string.IsNullOrEmpty(message) ? "See errors or logs for more details" : message,`
`12`		`- errors)`
	`12`	`+ errors ?? new List<ErrorDetail>())`
`13`	`13`	`{`
`14`	`14`	`}`
`15`		`- public UnauthorizedDetails(ExceptionContext context, string title = null, string message = null, List<ErrorDetail> errors = null) :`
	`15`	`+ public UnauthorizedDetails(ExceptionContext context, string? title = null, string? message = null, List<ErrorDetail>? errors = null) :`
`16`	`16`	`base(`
`17`	`17`	`context ?? throw new ArgumentNullException(nameof(context)),`
`18`	`18`	`string.IsNullOrEmpty(title) ? "Unauthorized" : title,`
`19`	`19`	`context.HttpContext.Request.Path,`
`20`	`20`	`StatusCodes.Status401Unauthorized,`
`21`	`21`	`string.IsNullOrEmpty(message) ? "See errors or logs for more details" : message,`
`22`		`- errors)`
	`22`	`+ errors ?? new List<ErrorDetail>())`
`23`	`23`	`{`
`24`	`24`	`}`
`25`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ public static class ProblemDetailsHelper`
`4`	`4`	`{`
`5`	`5`	`public static void AddDefaultExtensionsFromContext(this BaseDetails details,`
`6`	`6`	`ActionContext context,`
`7`		`- List<ErrorDetail> errors = null)`
	`7`	`+ List<ErrorDetail>? errors = null)`
`8`	`8`	`{`
`9`	`9`	`foreach (var (key, value) in GetExtensionsFromContext(context, errors))`
`10`	`10`	`{`
`@@ -14,7 +14,7 @@ public static void AddDefaultExtensionsFromContext(this BaseDetails details,`
`14`	`14`
`15`	`15`	`public static void AddDefaultExtensionsFromContext(this BaseDetails details,`
`16`	`16`	`ExceptionContext context,`
`17`		`- List<ErrorDetail> errors = null)`
	`17`	`+ List<ErrorDetail>? errors = null)`
`18`	`18`	`{`
`19`	`19`	`foreach (var (key, value) in GetExtensionsFromContext(context, errors))`
`20`	`20`	`{`
`@@ -23,12 +23,12 @@ public static void AddDefaultExtensionsFromContext(this BaseDetails details,`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`private static IDictionary<string, object> GetExtensionsFromContext(ActionContext context,`
`26`		`- List<ErrorDetail> errors = null)`
	`26`	`+ List<ErrorDetail>? errors = null)`
`27`	`27`	`{`
`28`	`28`	`var dictionary = new Dictionary<string, object>`
`29`	`29`	`{`
`30`	`30`	`{"Method", context.HttpContext.Request.Method },`
`31`		`- {"QueryString", context.HttpContext.Request.QueryString.Value },`
	`31`	`+ {"QueryString", context.HttpContext.Request.QueryString.Value ?? string.Empty },`
`32`	`32`	`{"CorrelationId", context.HttpContext.Request.Headers["x-correlation-id"].ToString() },`
`33`	`33`	`{"TraceId", context.HttpContext.TraceIdentifier }`
`34`	`34`	`};`
`@@ -39,12 +39,12 @@ private static IDictionary<string, object> GetExtensionsFromContext(ActionContex`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`private static IDictionary<string, object> GetExtensionsFromContext(ExceptionContext context,`
`42`		`- List<ErrorDetail> errors = null)`
	`42`	`+ List<ErrorDetail>? errors = null)`
`43`	`43`	`{`
`44`	`44`	`var dictionary = new Dictionary<string, object>`
`45`	`45`	`{`
`46`	`46`	`{"Method", context.HttpContext.Request.Method },`
`47`		`- {"QueryString", context.HttpContext.Request.QueryString.Value },`
	`47`	`+ {"QueryString", context.HttpContext.Request.QueryString.Value ?? string.Empty },`
`48`	`48`	`{"CorrelationId", context.HttpContext.Request.Headers["x-correlation-id"].ToString() },`
`49`	`49`	`{"TraceId", context.HttpContext.TraceIdentifier }`
`50`	`50`	`};`
`@@ -54,22 +54,15 @@ private static IDictionary<string, object> GetExtensionsFromContext(ExceptionCon`
`54`	`54`	`return dictionary;`
`55`	`55`	`}`
`56`	`56`
`57`		`- public static ConstructorInfo GetActionContextConstructor<T>()`
	`57`	`+ public static ConstructorInfo? GetActionContextConstructor<T>()`
`58`	`58`	`where T : BaseDetails`
`59`	`59`	`{`
`60`		`- try`
	`60`	`+ return typeof(T).GetConstructor(new[]`
`61`	`61`	`{`
`62`		`- return typeof(T).GetConstructor(new[]`
`63`		`- {`
`64`		`- typeof(ActionContext),`
`65`		`- typeof(string),`
`66`		`- typeof(string),`
`67`		`- typeof(List<ErrorDetail>)`
`68`		`- });`
`69`		`- }`
`70`		`- catch (Exception e)`
`71`		`- {`
`72`		`- throw new Exception($"Error creating constructor for type: {typeof(T)}", e);`
`73`		`- }`
	`62`	`+ typeof(ActionContext),`
	`63`	`+ typeof(string),`
	`64`	`+ typeof(string),`
	`65`	`+ typeof(List<ErrorDetail>)`
	`66`	`+ });`
`74`	`67`	`}`
`75`	`68`	`}`