Update 1 code files

Modified:
  • src/omnipkg/dispatcher.py (+5/-8 lines)

[gitship-generated]

Author: 1minds3t

src/omnipkg/dispatcher.py

@@ -575,21 +575,18 @@ def _install_binary_into_bin_dir(binary_tmp, target_bin, src_hash: str, debug: b
     target_bin = Path(target_bin)
 
     _exe = ".exe" if sys.platform == "win32" else ""
-    all_succeeded = True  # <-- NEW: Track if any replacements fail
+    all_succeeded = True  # <-- NEW: Track if all binaries successfully update
 
     for name in ("8pkg", "omnipkg", "OMNIPKG", "8PKG"):
         target = target_bin / (name + _exe)
         if target.exists():
             try:
-                # NEW: Windows running-executable overwrite trick
+                # NEW: Windows file lock bypass: Rename the running executable first
                 if sys.platform == "win32":
                     old_target = target.with_name(target.name + ".old")
                     try:
                         if old_target.exists():
                             old_target.unlink()
-                    except Exception:
-                        pass
-                    try:
                         target.rename(old_target)
                     except Exception:
                         pass
@@ -599,11 +596,11 @@ def _install_binary_into_bin_dir(binary_tmp, target_bin, src_hash: str, debug: b
                     os.chmod(str(target), 0o755)
                 replaced.append(str(target))
             except Exception as e:
-                all_succeeded = False  # <-- Mark failure
+                all_succeeded = False  # <-- NEW: Mark as failed!
                 if debug:
                     print(f"[C-INSTALL] could not replace {target}: {e}", file=sys.stderr)
 
-    # NEW: Only write marker if ALL binaries were successfully replaced
+    # NEW: ONLY write the marker if every replacement succeeded
     if replaced and all_succeeded and src_hash and c_src:
         try:
             (target_bin / ".omnipkg_dispatch_compiled").write_text(
@@ -1767,7 +1764,7 @@ def _ensure_all_version_shims(bin_dir: Path, debug_mode: bool = False) -> None:
                     try:
                         existing = bat_path.read_text(encoding="ascii")
                         # NEW: Check against \n version safely
-                        if existing == bat_content or existing == bat_content.replace("\r\n", "\n"):
+                        if existing.replace("\r\n", "\n") == bat_content.replace("\r\n", "\n"):
                             continue  # already correct — truly idempotent
 
                         if debug_mode: