From a6136f03d2dbe7d5cef3f4690455e9f6b26a1f3a Mon Sep 17 00:00:00 2001 From: spacemanspiff2007 <10754716+spacemanspiff2007@users.noreply.github.com> Date: Fri, 28 May 2021 10:47:31 +0200 Subject: [PATCH 01/12] Fix log output Fix log output, since %H never prints anything --- main/ZsensorBME280.ino | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/main/ZsensorBME280.ino b/main/ZsensorBME280.ino index 800b2f60df..845e32296b 100644 --- a/main/ZsensorBME280.ino +++ b/main/ZsensorBME280.ino @@ -51,7 +51,7 @@ BME280 mySensor; void setupZsensorBME280() { mySensor.settings.commInterface = I2C_MODE; mySensor.settings.I2CAddress = BME280_i2c_addr; - Log.notice(F("Setup BME280 on adress: %H" CR), BME280_i2c_addr); + Log.notice(F("Setup BME280 on adress: %X" CR), BME280_i2c_addr); //***Operation settings*****************************// // runMode Setting - Values: @@ -101,7 +101,7 @@ void setupZsensorBME280() { mySensor.settings.humidOverSample = 1; delay(10); // Gives the Sensor enough time to turn on (The BME280 requires 2ms to start up) - Log.notice(F("Bosch BME280 Initialized - Result of .begin(): 0x %h" CR), mySensor.begin()); + Log.notice(F("Bosch BME280 Initialized - Result of .begin(): %X" CR), mySensor.begin()); } void MeasureTempHumAndPressure() { From 6f755835b5f2699cf36002915ec710b5b7b58d18 Mon Sep 17 00:00:00 2001 From: spacemanspiff2007 <10754716+spacemanspiff2007@users.noreply.github.com> Date: Fri, 28 May 2021 14:17:13 +0200 Subject: [PATCH 02/12] Update ZsensorBME280.ino log status --- main/ZsensorBME280.ino | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/main/ZsensorBME280.ino b/main/ZsensorBME280.ino index 845e32296b..82d5af4d15 100644 --- a/main/ZsensorBME280.ino +++ b/main/ZsensorBME280.ino @@ -101,7 +101,14 @@ void setupZsensorBME280() { mySensor.settings.humidOverSample = 1; delay(10); // Gives the Sensor enough time to turn on (The BME280 requires 2ms to start up) - Log.notice(F("Bosch BME280 Initialized - Result of .begin(): %X" CR), mySensor.begin()); + + int ret = mySensor.begin(); + if (ret == 0x60) { + Log.notice(F("Bosch BME280 successfully Initialized: %X" CR), ret); + } + else { + Log.notice(F("Bosch BME280 failed: %X" CR), ret); + } } void MeasureTempHumAndPressure() { From 5753a768cb2bf099f33b78a69c423b0a935b9e44 Mon Sep 17 00:00:00 2001 From: spacemanspiff2007 <10754716+spacemanspiff2007@users.noreply.github.com> Date: Fri, 28 May 2021 14:36:52 +0200 Subject: [PATCH 03/12] Update ZsensorBME280.ino Initialize I2C --- main/ZsensorBME280.ino | 2 ++ 1 file changed, 2 insertions(+) diff --git a/main/ZsensorBME280.ino b/main/ZsensorBME280.ino index 82d5af4d15..b3cebb04a8 100644 --- a/main/ZsensorBME280.ino +++ b/main/ZsensorBME280.ino @@ -49,6 +49,8 @@ BME280 mySensor; void setupZsensorBME280() { + Wire.begin(BME280_PIN_SDA, BME280_PIN_SCL); + mySensor.settings.commInterface = I2C_MODE; mySensor.settings.I2CAddress = BME280_i2c_addr; Log.notice(F("Setup BME280 on adress: %X" CR), BME280_i2c_addr); From d89e01b67d3d1fd3c571cdd8d54848c2dcd4e7de Mon Sep 17 00:00:00 2001 From: spacemanspiff2007 <10754716+spacemanspiff2007@users.noreply.github.com> Date: Fri, 28 May 2021 14:37:17 +0200 Subject: [PATCH 04/12] Update config_BME280.h --- main/config_BME280.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/main/config_BME280.h b/main/config_BME280.h index c042032c10..724d68a9c9 100644 --- a/main/config_BME280.h +++ b/main/config_BME280.h @@ -58,4 +58,7 @@ extern void BME280toMQTT(); unsigned long timebme280 = 0; int BME280_i2c_addr = 0x76; // Bosch BME280 I2C Address +int BME280_PIN_SDA = 21; // PIN SDA +int BME280_PIN_SCL = 22; // PIN SCL + #endif From b4db6112038a4f2a27b84827f09f99b9992b871a Mon Sep 17 00:00:00 2001 From: spacemanspiff2007 <10754716+spacemanspiff2007@users.noreply.github.com> Date: Sat, 29 May 2021 05:36:16 +0200 Subject: [PATCH 05/12] update format --- main/ZsensorBME280.ino | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/main/ZsensorBME280.ino b/main/ZsensorBME280.ino index b3cebb04a8..4ba8ece364 100644 --- a/main/ZsensorBME280.ino +++ b/main/ZsensorBME280.ino @@ -50,7 +50,7 @@ BME280 mySensor; void setupZsensorBME280() { Wire.begin(BME280_PIN_SDA, BME280_PIN_SCL); - + mySensor.settings.commInterface = I2C_MODE; mySensor.settings.I2CAddress = BME280_i2c_addr; Log.notice(F("Setup BME280 on adress: %X" CR), BME280_i2c_addr); @@ -107,8 +107,7 @@ void setupZsensorBME280() { int ret = mySensor.begin(); if (ret == 0x60) { Log.notice(F("Bosch BME280 successfully Initialized: %X" CR), ret); - } - else { + } else { Log.notice(F("Bosch BME280 failed: %X" CR), ret); } } From 7ff645f1a9db7dc9df64fd7dd23f74f9fb0a670e Mon Sep 17 00:00:00 2001 From: spacemanspiff2007 <10754716+spacemanspiff2007@users.noreply.github.com> Date: Sat, 29 May 2021 05:36:30 +0200 Subject: [PATCH 06/12] Update config_BME280.h update format --- main/config_BME280.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/main/config_BME280.h b/main/config_BME280.h index 724d68a9c9..4b620c9209 100644 --- a/main/config_BME280.h +++ b/main/config_BME280.h @@ -58,7 +58,7 @@ extern void BME280toMQTT(); unsigned long timebme280 = 0; int BME280_i2c_addr = 0x76; // Bosch BME280 I2C Address -int BME280_PIN_SDA = 21; // PIN SDA -int BME280_PIN_SCL = 22; // PIN SCL +int BME280_PIN_SDA = 21; // PIN SDA +int BME280_PIN_SCL = 22; // PIN SCL #endif From a5842e232acd008ede985fb2e9b03d8833b6b742 Mon Sep 17 00:00:00 2001 From: spacemanspiff2007 <10754716+spacemanspiff2007@users.noreply.github.com> Date: Sat, 29 May 2021 05:38:40 +0200 Subject: [PATCH 07/12] Update ZsensorBME280.ino fix typo --- main/ZsensorBME280.ino | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main/ZsensorBME280.ino b/main/ZsensorBME280.ino index 4ba8ece364..a3aeeeafe2 100644 --- a/main/ZsensorBME280.ino +++ b/main/ZsensorBME280.ino @@ -106,7 +106,7 @@ void setupZsensorBME280() { int ret = mySensor.begin(); if (ret == 0x60) { - Log.notice(F("Bosch BME280 successfully Initialized: %X" CR), ret); + Log.notice(F("Bosch BME280 successfully initialized: %X" CR), ret); } else { Log.notice(F("Bosch BME280 failed: %X" CR), ret); } From 7c2953372287b0f3a7b1fc5d43349a9bf3613652 Mon Sep 17 00:00:00 2001 From: spacemanspiff2007 <10754716+spacemanspiff2007@users.noreply.github.com> Date: Sat, 29 May 2021 07:22:36 +0200 Subject: [PATCH 08/12] Update ZsensorBME280.ino --- main/ZsensorBME280.ino | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/main/ZsensorBME280.ino b/main/ZsensorBME280.ino index a3aeeeafe2..1eb76d2ebd 100644 --- a/main/ZsensorBME280.ino +++ b/main/ZsensorBME280.ino @@ -49,7 +49,13 @@ BME280 mySensor; void setupZsensorBME280() { - Wire.begin(BME280_PIN_SDA, BME280_PIN_SCL); + + // Allow custom pins on ESP Platforms + #if defined(ESP8266) || defined(ESP32) + Wire.setPins(BME280_PIN_SDA, BME280_PIN_SCL); + #endif + + Wire.begin(); mySensor.settings.commInterface = I2C_MODE; mySensor.settings.I2CAddress = BME280_i2c_addr; From 9e73a65e98ab63bd2655e2213a7569444bccfec2 Mon Sep 17 00:00:00 2001 From: spacemanspiff2007 <10754716+spacemanspiff2007@users.noreply.github.com> Date: Sat, 29 May 2021 07:22:56 +0200 Subject: [PATCH 09/12] Update config_BME280.h --- main/config_BME280.h | 1 + 1 file changed, 1 insertion(+) diff --git a/main/config_BME280.h b/main/config_BME280.h index 4b620c9209..7bdf426ca1 100644 --- a/main/config_BME280.h +++ b/main/config_BME280.h @@ -58,6 +58,7 @@ extern void BME280toMQTT(); unsigned long timebme280 = 0; int BME280_i2c_addr = 0x76; // Bosch BME280 I2C Address +// Only supported for ESP int BME280_PIN_SDA = 21; // PIN SDA int BME280_PIN_SCL = 22; // PIN SCL From 48f441be1e59d70e36f9137633117e03667283dc Mon Sep 17 00:00:00 2001 From: spacemanspiff2007 <10754716+spacemanspiff2007@users.noreply.github.com> Date: Sat, 29 May 2021 17:51:54 +0200 Subject: [PATCH 10/12] Update ZsensorBME280.ino fixes --- main/ZsensorBME280.ino | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/main/ZsensorBME280.ino b/main/ZsensorBME280.ino index 1eb76d2ebd..abf47a830d 100644 --- a/main/ZsensorBME280.ino +++ b/main/ZsensorBME280.ino @@ -50,12 +50,12 @@ BME280 mySensor; void setupZsensorBME280() { +# if defined(ESP8266) || defined(ESP32) // Allow custom pins on ESP Platforms - #if defined(ESP8266) || defined(ESP32) - Wire.setPins(BME280_PIN_SDA, BME280_PIN_SCL); - #endif - + Wire.begin(BME280_PIN_SDA, BME280_PIN_SCL); +# else Wire.begin(); +# endif mySensor.settings.commInterface = I2C_MODE; mySensor.settings.I2CAddress = BME280_i2c_addr; From 5ea7f0e37ffdd40f1f5541a790c27200f5be2c49 Mon Sep 17 00:00:00 2001 From: spacemanspiff2007 <10754716+spacemanspiff2007@users.noreply.github.com> Date: Sun, 30 May 2021 05:40:28 +0200 Subject: [PATCH 11/12] Update ZsensorBME280.ino linter fixes --- main/ZsensorBME280.ino | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/main/ZsensorBME280.ino b/main/ZsensorBME280.ino index abf47a830d..2fda87dd20 100644 --- a/main/ZsensorBME280.ino +++ b/main/ZsensorBME280.ino @@ -50,12 +50,12 @@ BME280 mySensor; void setupZsensorBME280() { -# if defined(ESP8266) || defined(ESP32) +# if defined(ESP8266) || defined(ESP32) // Allow custom pins on ESP Platforms Wire.begin(BME280_PIN_SDA, BME280_PIN_SCL); -# else +# else Wire.begin(); -# endif +# endif mySensor.settings.commInterface = I2C_MODE; mySensor.settings.I2CAddress = BME280_i2c_addr; From 6b65e30df4d452bd892e112b77cb23ef6a7bedda Mon Sep 17 00:00:00 2001 From: spacemanspiff2007 <10754716+spacemanspiff2007@users.noreply.github.com> Date: Sun, 30 May 2021 17:42:26 +0200 Subject: [PATCH 12/12] Update ZsensorBME280.ino removed empty line --- main/ZsensorBME280.ino | 1 - 1 file changed, 1 deletion(-) diff --git a/main/ZsensorBME280.ino b/main/ZsensorBME280.ino index 2fda87dd20..e037d47ba5 100644 --- a/main/ZsensorBME280.ino +++ b/main/ZsensorBME280.ino @@ -49,7 +49,6 @@ BME280 mySensor; void setupZsensorBME280() { - # if defined(ESP8266) || defined(ESP32) // Allow custom pins on ESP Platforms Wire.begin(BME280_PIN_SDA, BME280_PIN_SCL);