Skip to content

Commit 9d3ec12

Browse files
committed
fix(inter): Minor bug fix
1 parent b1ff258 commit 9d3ec12

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

src/interceptor-service.ts

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ export class InterceptorService extends Http {
8181
.build();
8282

8383
return Observable.create((observer: Subscriber<Response>) => {
84-
const localRequestNum = this.requestNum;
85-
const subscription = this.httpRequest(request, localRequestNum).subscribe(
84+
const reqNum = this.requestNum;
85+
const subscription = this.httpRequest(request, reqNum).subscribe(
8686
(response: Response) => observer.next(response),
8787
(e: Error) => observer.error(e),
8888
() => observer.complete()
@@ -92,7 +92,7 @@ export class InterceptorService extends Http {
9292
for (let index = this.interceptors.length - 1; index >= 0; index--) {
9393
const interceptor = this.interceptors[index];
9494
if (interceptor.onUnsubscribe !== undefined) {
95-
interceptor.onUnsubscribe(index, url, options, localRequestNum);
95+
interceptor.onUnsubscribe(index, url, options, reqNum);
9696
}
9797
}
9898
});
@@ -188,8 +188,8 @@ export class InterceptorService extends Http {
188188
}
189189

190190
/** Private functions **/
191-
private httpRequest(request: InterceptorRequest, requestNum: number): Observable<Response> {
192-
return this.runBeforeInterceptors(request, requestNum)
191+
private httpRequest(request: InterceptorRequest, reqNum: number): Observable<Response> {
192+
return this.runBeforeInterceptors(request, reqNum)
193193
.flatMap<InterceptorRequest, InterceptorResponseWrapper>((transformedRequest: InterceptorRequest, _: number) => {
194194
console.log(`Received request`, transformedRequest);
195195
const transformedRequestInternal = <InterceptorRequestInternal>transformedRequest;
@@ -231,7 +231,7 @@ export class InterceptorService extends Http {
231231
});
232232
})
233233
.flatMap((responseWrapper: InterceptorResponseWrapper, index: number) => {
234-
return this.runAfterInterceptors(responseWrapper, requestNum);
234+
return this.runAfterInterceptors(responseWrapper, reqNum);
235235
})
236236
.flatMap((responseWrapper: InterceptorResponseWrapper, index: number) => {
237237
if (!responseWrapper.response) {
@@ -247,7 +247,7 @@ export class InterceptorService extends Http {
247247
});
248248
}
249249

250-
private runBeforeInterceptors(params: InterceptorRequest, requestNum: number): Observable<InterceptorRequest> {
250+
private runBeforeInterceptors(params: InterceptorRequest, reqNum: number): Observable<InterceptorRequest> {
251251
let request$: Observable<InterceptorRequest> = Observable.of(params);
252252

253253
for (let index = 0; index < this.interceptors.length; index++) {
@@ -270,7 +270,7 @@ export class InterceptorService extends Http {
270270
if (interceptor.beforeRequest !== undefined) {
271271
try {
272272
console.log('Invoking beforeRequest on', interceptor);
273-
const processedRequest = interceptor.beforeRequest(request, index, requestNum);
273+
const processedRequest = interceptor.beforeRequest(request, index, reqNum);
274274
let processedRequest$: Observable<InterceptorRequest>;
275275

276276
if (!processedRequest) { // if no request is returned; just proceed with the original request
@@ -301,7 +301,7 @@ export class InterceptorService extends Http {
301301
return request$;
302302
}
303303

304-
private runAfterInterceptors(responseWrapper: InterceptorResponseWrapper, requestNum: number): Observable<InterceptorResponseWrapper> {
304+
private runAfterInterceptors(responseWrapper: InterceptorResponseWrapper, reqNum: number): Observable<InterceptorResponseWrapper> {
305305
let responseWrapper$: Observable<InterceptorResponseWrapper> = Observable.of(responseWrapper);
306306

307307
let startFrom: number;
@@ -328,7 +328,7 @@ export class InterceptorService extends Http {
328328
if (transformedResponseWrapper.forceRequestCompletion) {
329329
if (interceptor.onForceCompleteOrForceReturn !== undefined) {
330330
console.log('Invoking onForceCompleteOrForceReturn on', interceptor);
331-
interceptor.onForceCompleteOrForceReturn(transformedResponseWrapper, index, requestNum);
331+
interceptor.onForceCompleteOrForceReturn(transformedResponseWrapper, index, reqNum);
332332
}
333333
if (index === 0) { // complete the observable, since this is the first interceptor (last in the response chain)
334334
return Observable.empty();
@@ -338,7 +338,7 @@ export class InterceptorService extends Http {
338338
} else if (transformedResponseWrapper.forceReturnResponse) {
339339
if (interceptor.onForceCompleteOrForceReturn !== undefined) {
340340
console.log('Invoking onForceCompleteOrForceReturn on', interceptor);
341-
interceptor.onForceCompleteOrForceReturn(transformedResponseWrapper, index, requestNum);
341+
interceptor.onForceCompleteOrForceReturn(transformedResponseWrapper, index, reqNum);
342342
}
343343
return Observable.of(transformedResponseWrapper);
344344
}
@@ -348,16 +348,16 @@ export class InterceptorService extends Http {
348348
if (transformedResponseWrapper.err) {
349349
if (interceptor.onErr !== undefined) {
350350
console.log('Invoking onErr on', interceptor);
351-
processedResponse = interceptor.onErr(transformedResponseWrapper, index, requestNum);
351+
processedResponse = interceptor.onErr(transformedResponseWrapper, index, reqNum);
352352
}
353353
} else if (transformedResponseWrapper.isShortCircuited()) {
354354
if (interceptor.onShortCircuit !== undefined) {
355355
console.log('Invoking onShortCircuit on', interceptor);
356-
processedResponse = interceptor.onShortCircuit(transformedResponseWrapper, index, requestNum);
356+
processedResponse = interceptor.onShortCircuit(transformedResponseWrapper, index, reqNum);
357357
}
358358
} else if (interceptor.onResponse !== undefined) {
359359
console.log('Invoking onResponse on', interceptor);
360-
processedResponse = interceptor.onResponse(transformedResponseWrapper, index, requestNum);
360+
processedResponse = interceptor.onResponse(transformedResponseWrapper, index, reqNum);
361361
}
362362

363363
let procesedResponseWrapper$: Observable<InterceptorResponseWrapper>;

0 commit comments

Comments
 (0)