refactor (#323)

Author: kalashsinghal

tests/testthat/_snaps/exclude_cols_then_pivot_wider.md

@@ -7,7 +7,7 @@
        $ companies_id              : chr [1:456] "antimonarchy_canine" "antimonarchy_canine" "antimonarchy_canine" "antimonarchy_canine" ...
        $ grouped_by                : chr [1:456] "all" "isic_4digit" "tilt_subsector" "unit" ...
        $ risk_category             : chr [1:456] "high" "high" "high" "high" ...
-       $ profile_ranking           : num [1:456] 1 1 1 1 1 1 1 1 1 1 ...
+       $ profile_ranking           : num [1:456] 1 1 1 1 NA 1 1 1 1 1 ...
        $ clustered                 : chr [1:456] "tent" "tent" "tent" "tent" ...
        $ activity_uuid_product_uuid: chr [1:456] "76269c17-78d6-420b-991a-aa38c51b45b7" "76269c17-78d6-420b-991a-aa38c51b45b7" "76269c17-78d6-420b-991a-aa38c51b45b7" "76269c17-78d6-420b-991a-aa38c51b45b7" ...
        $ co2_footprint             : num [1:456] 303 303 303 303 303 ...
@@ -32,7 +32,7 @@
        $ companies_id                    : chr [1:690] "antimonarchy_canine" "antimonarchy_canine" "antimonarchy_canine" "antimonarchy_canine" ...
        $ grouped_by                      : chr [1:690] "all" "input_isic_4digit" "input_tilt_subsector" "input_unit" ...
        $ risk_category                   : chr [1:690] "high" "high" "high" "high" ...
-       $ profile_ranking                 : num [1:690] 0.938 1 1 1 1 ...
+       $ profile_ranking                 : num [1:690] 0.938 1 1 1 NA ...
        $ clustered                       : chr [1:690] "tent" "tent" "tent" "tent" ...
        $ activity_uuid_product_uuid      : chr [1:690] "76269c17-78d6-420b-991a-aa38c51b45b7" "76269c17-78d6-420b-991a-aa38c51b45b7" "76269c17-78d6-420b-991a-aa38c51b45b7" "76269c17-78d6-420b-991a-aa38c51b45b7" ...
        $ input_activity_uuid_product_uuid: chr [1:690] "44e5e288-4f81-40d0-88b4-e79eaea6574c" "44e5e288-4f81-40d0-88b4-e79eaea6574c" "44e5e288-4f81-40d0-88b4-e79eaea6574c" "44e5e288-4f81-40d0-88b4-e79eaea6574c" ...

tests/testthat/_snaps/toy_result.md

@@ -404,27 +404,6 @@ test_that("with some match preserves unmatched products (#193)", {
   expect_equal(unique(product$activity_uuid_product_uuid), c(uuid, "unmatched"))
 })
 
-test_that("with no match errors gracefully", {
-  companies <- read_csv(toy_emissions_profile_any_companies()) |>
-    filter(companies_id %in% dplyr::first(companies_id)) |>
-    mutate(activity_uuid_product_uuid = "unmatched")
-  co2 <- read_csv(toy_emissions_profile_products_ecoinvent())
-
-  europages_companies <- read_csv(toy_europages_companies())
-  ecoinvent_activities <- read_csv(toy_ecoinvent_activities())
-  ecoinvent_europages <- read_csv(toy_ecoinvent_europages())
-  isic_name <- read_csv(toy_isic_name())
-
-  expect_error(profile_emissions(
-    companies,
-    co2,
-    europages_companies,
-    ecoinvent_activities,
-    ecoinvent_europages,
-    isic_name
-  ), class = "all_benchmark_is_na")
-})
-
 test_that("at product level, preserves missing benchmarks (#153#issuecomment-2010043596)", {
   companies <- read_csv(toy_emissions_profile_any_companies())
   id <- unique(companies$companies_id)[[1]]
@@ -562,7 +541,9 @@ test_that("if `*profile$` column has NA then `tilt_sector` and `tilt_subsector`
     isic_name
   )
 
-  product <- unnest_product(out)
+  product <- unnest_product(out) |>
+    # Due to single product, it qualifies for the uuid exclusion of unit-isic group if unique uuid count is 1. Please change the sample data!
+    filter(benchmark != "unit_isic_4digit")
   where_risk_category_is_na <- product |>
     filter(is.na(get_column(product, "profile$")))