Skip to content

Commit a3c1ba0

Browse files
committed
Orb: my_volume -> orb_volume.
1 parent 2281334 commit a3c1ba0

6 files changed

Lines changed: 23 additions & 10 deletions

File tree

src/snappy/extensions/Orb/cython_src/Orb.pxi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ cdef extern from "SnapPea.h":
1616
extern void free_triangulation(c_Triangulation *manifold) except *
1717

1818
extern c_SolutionType find_structure(c_Triangulation *manifold, Boolean) except *
19-
extern Real my_volume(c_Triangulation *manifold, Boolean * ok) except *
2019

2120
extern int get_num_cusps(c_Triangulation *manifold) except *
2221
extern int get_num_or_cusps(c_Triangulation *manifold) except *
@@ -31,6 +30,7 @@ cdef extern from "Orb.h":
3130
c_Triangulation * manifold,
3231
int singular_index,
3332
double singular_order) except *
33+
extern Real orb_volume(c_Triangulation *manifold, Boolean * ok) except *
3434

3535
cdef extern from "kernel_prototypes.h":
3636
extern void remove_finite_vertices(c_Triangulation *manifold)

src/snappy/extensions/Orb/cython_src/core/orbifold.pyx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,4 @@ cdef class Orbifold(OrbTriangulation):
4343

4444
find_structure(self.c_triangulation, False)
4545

46-
return self._number_(Real2Number(my_volume(self.c_triangulation, &ok)))
46+
return self._number_(Real2Number(orb_volume(self.c_triangulation, &ok)))

src/snappy/extensions/Orb/kernel/code/my_identify_solution_type.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,13 +80,13 @@ void my_identify_solution_type(
8080
return;
8181
}
8282

83-
if (my_solution_is_geometric(manifold) && my_volume(manifold, &ok) > VOLUME_EPSILON )
83+
if (my_solution_is_geometric(manifold) && orb_volume(manifold, &ok) > VOLUME_EPSILON )
8484
{
8585
manifold->solution_type[filled] = geometric_solution;
8686
return;
8787
}
8888

89-
if (my_volume(manifold, &ok) > VOLUME_EPSILON)
89+
if (orb_volume(manifold, &ok) > VOLUME_EPSILON)
9090
{
9191
manifold->solution_type[filled] = nongeometric_solution;
9292
return;

src/snappy/extensions/Orb/kernel/code/my_volume.c renamed to src/snappy/extensions/Orb/kernel/code/orb_volume.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ static Complex U( Complex z, double *angles, Boolean *ok );
66

77
/* Volume computed using formula in "A volume forumla for generalized hyperbolic tetrahedra" by Ushijima */
88

9-
extern double my_volume( Triangulation *manifold, Boolean *ok )
9+
extern double orb_volume( Triangulation *manifold, Boolean *ok )
1010
{
1111
Tetrahedron *tet;
1212
double volume=0,angles[6], tet_vol=0;
@@ -28,7 +28,7 @@ extern double my_volume( Triangulation *manifold, Boolean *ok )
2828
if (!flat_tet(tet))
2929
{
3030
*ok = FALSE;
31-
uFatalError("my_volume", "my_volume");
31+
uFatalError("orb_volume", "orb_volume");
3232
}
3333
}
3434

src/snappy/extensions/Orb/kernel/headers/Orb.h

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,29 @@
55

66
SNAPPEA_NAMESPACE_BEGIN_SCOPE
77

8-
void get_singular_orders(Triangulation *manifold,
8+
/************************************************************************/
9+
/* */
10+
/* orb_interface.c */
11+
/* */
12+
/************************************************************************/
13+
14+
extern void get_singular_orders(Triangulation *manifold,
915
int * num_singular_arcs,
1016
double ** singular_orders);
1117

12-
void set_singular_order(Triangulation *manifold,
18+
extern void set_singular_order(Triangulation *manifold,
1319
int singular_index,
1420
double singular_order);
1521

22+
/************************************************************************/
23+
/* */
24+
/* orb_volume.c */
25+
/* */
26+
/************************************************************************/
27+
28+
extern double tetrahedron_volume(double *angles, Boolean *ok);
29+
extern double orb_volume(Triangulation *manifold, Boolean *ok);
30+
1631
SNAPPEA_NAMESPACE_END_SCOPE
1732

1833
#endif

src/snappy/extensions/Orb/kernel/headers/SnapPea.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2573,8 +2573,6 @@ extern void two_bridge( Triangulation *manifold,
25732573
/************************************************************************/
25742574

25752575
extern double volume(Triangulation *manifold, int *precision);
2576-
extern double my_volume(Triangulation *manifold, Boolean *ok ); /* DJH */
2577-
extern double tetrahedron_volume(double *angles, Boolean *ok ); /* DJH */
25782576
/*
25792577
* Computes and returns the volume of the manifold.
25802578
* If the pointer "precision" is not NULL, estimates the number

0 commit comments

Comments
 (0)