Merge pull request #14 from 33Fraise33/fix/opencode-thread-limit

fix: Updated limits for comments

Author: 33Fraise33

.github/scripts/opencode-target.mjs

@@ -2,7 +2,7 @@ import { appendFileSync, readFileSync } from "node:fs"
 import { randomUUID } from "node:crypto"
 import { pathToFileURL } from "node:url"
 
-export const MAX_THREAD_COMMENTS = 10
+export const MAX_THREAD_ITEMS = 50
 export const MAX_THREAD_CONTEXT_CHARACTERS = 60_000
 export const MAX_PULL_REQUEST_FILES = 100
 const CONTEXT_FORMAT_OVERHEAD = 10_000
@@ -56,7 +56,7 @@ async function fetchTargetData({ apiUrl, repository, endpoint, token, fetchImpl
 async function assertBoundedThread(target, options) {
   const issueComments = await fetchTargetData({
     ...options,
-    endpoint: `issues/${target.number}/comments?per_page=${MAX_THREAD_COMMENTS + 1}`,
+    endpoint: `issues/${target.number}/comments?per_page=${MAX_THREAD_ITEMS + 1}`,
   })
   const context = [
     options.subject.title,
@@ -70,15 +70,15 @@ async function assertBoundedThread(target, options) {
   if (target.type === "pull_request") {
     const reviews = await fetchTargetData({
       ...options,
-      endpoint: `pulls/${target.number}/reviews?per_page=${MAX_THREAD_COMMENTS + 1}`,
+      endpoint: `pulls/${target.number}/reviews?per_page=${MAX_THREAD_ITEMS + 1}`,
     })
     itemCount += reviews.value.length
     context.push(...reviews.value.flatMap((review) => [review.user?.login, review.submitted_at, review.state, review.body]))
     const reviewComments = await Promise.all(
       reviews.value.map((review) =>
         fetchTargetData({
           ...options,
-          endpoint: `pulls/${target.number}/reviews/${review.id}/comments?per_page=${MAX_THREAD_COMMENTS + 1}`,
+          endpoint: `pulls/${target.number}/reviews/${review.id}/comments?per_page=${MAX_THREAD_ITEMS + 1}`,
         }),
       ),
     )
@@ -93,10 +93,10 @@ async function assertBoundedThread(target, options) {
       throw new Error(`OpenCode limits pull requests to ${MAX_PULL_REQUEST_FILES} changed files.`)
     }
     context.push(...files.value.flatMap((file) => [file.filename, file.status, file.additions, file.deletions]))
-    if (reviews.hasNextPage || reviewComments.some((result) => result.hasNextPage)) itemCount = MAX_THREAD_COMMENTS + 1
+    if (reviews.hasNextPage || reviewComments.some((result) => result.hasNextPage)) itemCount = MAX_THREAD_ITEMS + 1
   }
-  if (itemCount > MAX_THREAD_COMMENTS || issueComments.hasNextPage) {
-    throw new Error(`OpenCode limits issue and pull request threads to ${MAX_THREAD_COMMENTS} comments.`)
+  if (itemCount > MAX_THREAD_ITEMS || issueComments.hasNextPage) {
+    throw new Error(`OpenCode limits issue and pull request threads to ${MAX_THREAD_ITEMS} items.`)
   }
 
   const text = context.filter((value) => typeof value === "string" || typeof value === "number")

.github/scripts/opencode-target.test.mjs

@@ -1,7 +1,7 @@
 import assert from "node:assert/strict"
 import test from "node:test"
 
-import { MAX_PULL_REQUEST_FILES, MAX_THREAD_COMMENTS, classifyTarget, inspectTarget } from "./opencode-target.mjs"
+import { MAX_PULL_REQUEST_FILES, MAX_THREAD_ITEMS, classifyTarget, inspectTarget } from "./opencode-target.mjs"
 
 const repository = "owner/repo"
 const pull = {
@@ -92,26 +92,31 @@ test("plan permits fork pull requests", async () => {
   assert.equal(result.head_repo, "fork/repo")
 })
 
+test("accepts a thread at the item limit", async () => {
+  const comments = Array.from({ length: MAX_THREAD_ITEMS }, () => ({ body: "comment" }))
+  await assert.doesNotReject(() => inspectTarget({ issue: { number: 8 } }, "plan", { ...options, fetchImpl: response({ issueComments: comments }) }))
+})
+
 test("rejects oversized thread context before model access", async () => {
-  const comments = Array.from({ length: MAX_THREAD_COMMENTS + 1 }, () => ({ body: "comment" }))
+  const comments = Array.from({ length: MAX_THREAD_ITEMS + 1 }, () => ({ body: "comment" }))
   await assert.rejects(
     () => inspectTarget({ issue: { number: 8 } }, "plan", { ...options, fetchImpl: response({ issueComments: comments }) }),
-    /limits issue and pull request threads/,
+    /limits issue and pull request threads to 50 items/,
   )
 })
 
 test("counts PR reviews and nested review comments in the context limit", async () => {
-  const reviews = Array.from({ length: MAX_THREAD_COMMENTS + 1 }, (_, id) => ({ id, body: "review" }))
+  const reviews = Array.from({ length: MAX_THREAD_ITEMS + 1 }, (_, id) => ({ id, body: "review" }))
   await assert.rejects(
     () => inspectTarget({ pull_request: { number: 9 } }, "plan", { ...options, fetchImpl: response({ reviews }) }),
-    /limits issue and pull request threads/,
+    /limits issue and pull request threads to 50 items/,
   )
   await assert.rejects(
     () => inspectTarget({ pull_request: { number: 9 } }, "plan", {
       ...options,
-      fetchImpl: response({ reviews: [{ id: 1, body: "review" }], reviewComments: Array.from({ length: MAX_THREAD_COMMENTS }, () => ({ body: "comment" })) }),
+      fetchImpl: response({ reviews: [{ id: 1, body: "review" }], reviewComments: Array.from({ length: MAX_THREAD_ITEMS }, () => ({ body: "comment" })) }),
     }),
-    /limits issue and pull request threads/,
+    /limits issue and pull request threads to 50 items/,
   )
 })
 

docs/opencode-github.md

@@ -12,7 +12,7 @@ OpenCode responds to explicit commands in GitHub issue comments, pull request co
 - The build agent statically denies edits. A trusted startup plugin enables edits only for ordinary repository files and retains canonical and symlink path checks. If the plugin or config hook fails, editing stays denied.
 - The build agent has no shell, network, subagent, external-directory, or merge access. It cannot edit `.github/`, `.opencode/`, `.git/`, `opencode.json`, `AGENTS.md`, `vault_pass.sh`, `.env`, or `.env.*` files.
 - Comment workflows start from the trusted default branch before OpenCode processes PR content.
-- Authorization bounds the repository-collected issue and pull-request context to ten issue/review/review-thread comments, 100 changed files, and 60,000 characters before OAuth is exposed. Native OpenCode may independently fetch additional GitHub context. GitHub attachment URLs are rejected rather than downloaded. Authorization captures current target state, `updated_at`, PR base branch, head branch, head SHA, and head repository. After environment approval, build mode rechecks the commenter's permission and fetches the target again immediately before OpenCode, rejecting any relevant change.
+- Authorization bounds the repository-collected issue and pull-request context to 50 combined conversation comments, reviews, and inline review comments, 100 changed files, and 60,000 characters before OAuth is exposed. Native OpenCode may independently fetch additional GitHub context. GitHub attachment URLs are rejected rather than downloaded. Authorization captures current target state, `updated_at`, PR base branch, head branch, head SHA, and head repository. After environment approval, build mode rechecks the commenter's permission and fetches the target again immediately before OpenCode, rejecting any relevant change.
 - Builds may update any same-repository, non-default-branch PR head. A residual race remains: OpenCode v1.18.4 ultimately fetches and pushes by mutable branch name, so a branch can theoretically move after verification and before fetch or push. Execution is not immutable by SHA unless upstream changes this behavior; all such branches need equivalent protection where appropriate, and final human diff review remains mandatory.
 - OpenCode sessions are never shared. The workflow downloads OpenCode v1.18.4 and verifies its pinned SHA-256 digest.
 - OpenCode can create or update a branch and pull request but has no merge operation in its configured toolset. Protected branch rules provide the final merge boundary.