From 7f6e8cba072b39ef92977ed4b0dd1a32393877a3 Mon Sep 17 00:00:00 2001
From: Brian Dunavant <brian@omniti.com>
Date: Fri, 12 Jun 2015 15:47:28 -0400
Subject: [PATCH] allow valid set() calls without a callback to proceed.  These
 were failing silently for no reason other than the fact that a callback was
 not provided.

---
 lib/utils.js                   |  2 +-
 test/memcached-get-set.test.js | 37 ++++++++++++++++++++++++++++++++++
 2 files changed, 38 insertions(+), 1 deletion(-)

diff --git a/lib/utils.js b/lib/utils.js
index a75a05b..349b674 100644
--- a/lib/utils.js
+++ b/lib/utils.js
@@ -50,7 +50,7 @@ exports.validateArg = function validateArg (args, config) {
         break;
 
       case Function:
-        if (toString.call(value) !== '[object Function]') {
+        if (typeof obj !== "undefined" && toString.call(value) !== '[object Function]') {
           err = 'Argument "' + key + '" is not a valid Function.';
         }
 
diff --git a/test/memcached-get-set.test.js b/test/memcached-get-set.test.js
index 2614ebf..f271f4b 100644
--- a/test/memcached-get-set.test.js
+++ b/test/memcached-get-set.test.js
@@ -9,6 +9,8 @@ var assert = require('assert')
 
 global.testnumbers = global.testnumbers || +(Math.random(10) * 1000000).toFixed();
 
+var set_without_callback_testnr = ++global.testnumbers;
+
 /**
  * Expresso test suite for all `get` related
  * memcached commands
@@ -625,4 +627,39 @@ describe("Memcached GET SET", function() {
       done();
     });
   });
+
+  /*
+    Make sure that set without a callback works.
+   While not common, sometimes people want to just call set without a callback and ignore error cases.  While this is a bad practice, there is no requirement that you pass in a callback for most functions.  The code used to silently fail without actually setting the value (since it would try to error using the callback, which did not exist, so it would just ignore and keep going.
+  */
+  before(function(done) {
+    var memcached = new Memcached(common.servers.single)
+      , message = 'i was set'
+      , testnr = set_without_callback_testnr;
+
+    memcached.set('set_without_callback_test:'+testnr , message, 1000 );
+    // wait .5 seconds before continuing.  While this is an arbitrary value, if your memcache set takes half a second you have bigger issues
+    setTimeout(done, 500);
+  });  
+  it("make sure you can set() without a callback", function(done) {
+    var memcached = new Memcached(common.servers.single)
+      , message = 'i was set'
+      , testnr = set_without_callback_testnr
+      , callbacks = 0;
+
+    memcached.get('set_without_callback_test:'+testnr, function(error, answer) {
+      ++callbacks;
+
+      assert.ok(!error);
+      memcached.end();
+      assert.equal(callbacks, 1);
+
+      assert.ok(typeof answer === 'string');
+      answer.should.eql(message);
+
+      done();
+    });
+  });
+
+
 });