Allow to create variables from autocompletion in more cases (#8583)

Also, in the extension editor: 
- Focus and select new parameter names
- Allow to add a new parameter from the variable autocompletion
- Allow to add behaviors from the bottom of the instruction list

Author: D8H

newIDE/app/src/BehaviorsEditor/NewBehaviorDialog.js

@@ -40,6 +40,7 @@ type Props = {|
   onChoose: (type: string, defaultName: string) => void,
   onWillInstallExtension: (extensionNames: Array<string>) => void,
   onExtensionInstalled: (extensionNames: Array<string>) => void,
+  shouldShowCapabilityBehaviors: boolean,
 |};
 
 export default function NewBehaviorDialog({
@@ -53,6 +54,7 @@ export default function NewBehaviorDialog({
   isChildObject,
   onWillInstallExtension,
   onExtensionInstalled,
+  shouldShowCapabilityBehaviors,
 }: Props): null | React.Node {
   const [isInstalling, setIsInstalling] = React.useState(false);
   const authenticatedUser = React.useContext(AuthenticatedUserContext);
@@ -103,7 +105,7 @@ export default function NewBehaviorDialog({
   const allInstalledBehaviorMetadataList: Array<BehaviorShortHeader> = React.useMemo(
     () => {
       const platform = project.getCurrentPlatform();
-      const behaviorMetadataList =
+      let behaviorMetadataList =
         project && platform
           ? enumerateBehaviorsMetadata(
               platform,
@@ -112,39 +114,48 @@ export default function NewBehaviorDialog({
             )
           : [];
 
-      return behaviorMetadataList
-        .filter(behavior => !behavior.behaviorMetadata.isHidden())
-        .map(behavior => ({
-          type: behavior.type,
-          fullName: behavior.fullName,
-          description: behavior.description,
-          previewIconUrl: behavior.previewIconUrl,
-          objectType: behavior.objectType,
-          category: behavior.category,
-          allRequiredBehaviorTypes: getAllRequiredBehaviorTypes(
-            behavior.behaviorMetadata
-          ),
-          tags: behavior.tags,
-          name: gd.PlatformExtension.getBehaviorNameFromFullBehaviorType(
-            behavior.type
-          ),
-          extensionName: gd.PlatformExtension.getExtensionFromFullBehaviorType(
-            behavior.type
-          ),
+      if (!shouldShowCapabilityBehaviors) {
+        behaviorMetadataList = behaviorMetadataList.filter(
+          behavior => !behavior.behaviorMetadata.isHidden()
+        );
+      }
+
+      return behaviorMetadataList.map(behavior => ({
+        type: behavior.type,
+        fullName: behavior.fullName,
+        description: behavior.description,
+        previewIconUrl: behavior.previewIconUrl,
+        objectType: behavior.objectType,
+        category: behavior.category,
+        allRequiredBehaviorTypes: getAllRequiredBehaviorTypes(
+          behavior.behaviorMetadata
+        ),
+        tags: behavior.tags,
+        name: gd.PlatformExtension.getBehaviorNameFromFullBehaviorType(
+          behavior.type
+        ),
+        extensionName: gd.PlatformExtension.getExtensionFromFullBehaviorType(
+          behavior.type
+        ),
 
-          isInstalled: true,
-          // The tier will be overridden with repository data.
-          // Only the built-in and user extensions will keep this value.
-          tier: 'installed',
-          // Not relevant for `installed` extensions
-          version: '',
-          url: '',
-          headerUrl: '',
-          extensionNamespace: '',
-          authorIds: [],
-        }));
+        isInstalled: true,
+        // The tier will be overridden with repository data.
+        // Only the built-in and user extensions will keep this value.
+        tier: 'installed',
+        // Not relevant for `installed` extensions
+        version: '',
+        url: '',
+        headerUrl: '',
+        extensionNamespace: '',
+        authorIds: [],
+      }));
     },
-    [project, eventsFunctionsExtension, getAllRequiredBehaviorTypes]
+    [
+      project,
+      eventsFunctionsExtension,
+      shouldShowCapabilityBehaviors,
+      getAllRequiredBehaviorTypes,
+    ]
   );
 
   const installedBehaviorMetadataList: Array<BehaviorShortHeader> = React.useMemo(

newIDE/app/src/BehaviorsEditor/index.js

@@ -612,6 +612,7 @@ export const useManageObjectBehaviors = ({
       eventsFunctionsExtension={eventsFunctionsExtension}
       onWillInstallExtension={onWillInstallExtension}
       onExtensionInstalled={onExtensionInstalled}
+      shouldShowCapabilityBehaviors={false}
     />
   );
 

newIDE/app/src/EventsFunctionsExtensionEditor/EventsBasedBehaviorOrObjectEditor/EventsBasedBehaviorOrObjectPropertiesEditor.js

@@ -90,6 +90,33 @@ const renderValueTypeIcon = (type: string, className: string): React.Node => {
   }
 };
 
+export const fillBehaviorProperty = (
+  projectScopedContainersAccessor: ProjectScopedContainersAccessor,
+  eventsBasedBehavior: gdEventsBasedBehavior,
+  property: gdNamedPropertyDescriptor,
+  behaviorType: string
+) => {
+  // Change the type of the required behavior.
+  const extraInfo = property.getExtraInfo();
+  if (extraInfo.size() === 0) {
+    extraInfo.push_back(behaviorType);
+  } else {
+    extraInfo.set(0, behaviorType);
+  }
+  const behaviorMetadata = gd.MetadataProvider.getBehaviorMetadata(
+    projectScopedContainersAccessor.getScope().project.getCurrentPlatform(),
+    behaviorType
+  );
+  const projectScopedContainers = projectScopedContainersAccessor.get();
+  const validatedNewName = getValidatedPropertyName(
+    eventsBasedBehavior.getPropertyDescriptors(),
+    projectScopedContainers,
+    behaviorMetadata.getDefaultName()
+  );
+  property.setName(validatedNewName);
+  property.setLabel(behaviorMetadata.getFullName());
+};
+
 const setExtraInfoString = (
   property: gdNamedPropertyDescriptor,
   value: string
@@ -674,27 +701,15 @@ export const EventsBasedBehaviorPropertiesEditor: React.ComponentType<{
                                       : property.getExtraInfo().at(0)
                                   }
                                   onChange={(newValue: string) => {
-                                    // Change the type of the required behavior.
-                                    const extraInfo = property.getExtraInfo();
-                                    if (extraInfo.size() === 0) {
-                                      extraInfo.push_back(newValue);
-                                    } else {
-                                      extraInfo.set(0, newValue);
+                                    if (!eventsBasedBehavior) {
+                                      return;
                                     }
-                                    const behaviorMetadata = gd.MetadataProvider.getBehaviorMetadata(
-                                      project.getCurrentPlatform(),
+                                    fillBehaviorProperty(
+                                      projectScopedContainersAccessor,
+                                      eventsBasedBehavior,
+                                      property,
                                       newValue
                                     );
-                                    const projectScopedContainers = projectScopedContainersAccessor.get();
-                                    const validatedNewName = getValidatedPropertyName(
-                                      properties,
-                                      projectScopedContainers,
-                                      behaviorMetadata.getDefaultName()
-                                    );
-                                    property.setName(validatedNewName);
-                                    property.setLabel(
-                                      behaviorMetadata.getFullName()
-                                    );
                                     forceUpdate();
                                     onPropertiesUpdated();
                                   }}