Skip to content

Commit 04ae8c7

Browse files
committed
Add/fix changelog and tests
1 parent ca65296 commit 04ae8c7

5 files changed

Lines changed: 52 additions & 0 deletions

File tree

changes/TI-2959.feature

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Allow SPV to send and update excerpts to proposal dossier. [ran]

opengever/api/tests/test_proposal.py

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -388,3 +388,48 @@ def test_submitting_additional_document_new_version(self, browser):
388388
self.assertEqual(documents[0].file.data,
389389
self.document.file.data)
390390
self.assertEqual("New", documents[0].file.data)
391+
392+
393+
class TestRISExcerptEndpoints(IntegrationTestCase):
394+
395+
@browsing
396+
def test_ris_return_and_update_excerpt(self, browser):
397+
self.login(self.regular_user, browser)
398+
399+
dossier_rel = "/".join(self.dossier.getPhysicalPath()[2:])
400+
401+
browser.open(
402+
self.document.absolute_url() + "/@ris-return-excerpt",
403+
method="POST",
404+
headers=self.api_headers,
405+
data=json.dumps(
406+
{
407+
"target_admin_unit_id": "plone",
408+
"target_dossier_relative_path": dossier_rel,
409+
}
410+
),
411+
)
412+
413+
self.assertEqual(200, browser.status_code)
414+
data = browser.json
415+
self.assertEqual(data["current_version_id"], 0)
416+
417+
excerpt_doc = self.portal.unrestrictedTraverse(data["path"].encode("utf-8"))
418+
419+
self.assertEqual(excerpt_doc.file.data, self.document.file.data)
420+
self.assertTrue(excerpt_doc.is_final_document())
421+
422+
browser.open(
423+
self.document.absolute_url() + "/@ris-update-excerpt",
424+
method="POST",
425+
headers=self.api_headers,
426+
data=json.dumps(
427+
{
428+
"target_admin_unit_id": "plone",
429+
"target_doc_relative_path": data["path"],
430+
}
431+
),
432+
)
433+
434+
self.assertEqual(browser.json["current_version_id"], 1)
435+
self.assertTrue(excerpt_doc.is_final_document())

opengever/core/lawgiver.zcml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,8 @@
247247
opengever.propertysheets: Manage PropertySheets,
248248
opengever.repository: Export repository,
249249
opengever.ris: Add Proposal,
250+
opengever.ris: Return Excerpt,
251+
opengever.ris: Update Excerpt,
250252
opengever.sharing: List Protected Objects,
251253
opengever.webactions: Manage own WebActions,
252254
opengever.workspace: Add WorkspaceFolder,

opengever/core/tests/test_view_security.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@
3636
# Add-form views are special adapters were the permission is stored
3737
# differently. These views are verified manually:
3838
'opengever.disposition.browser.form.DispositionAddView',
39+
'opengever.ris.browser.ris_excerpt.RISReturnExcerptReceive',
40+
'opengever.ris.browser.ris_excerpt.RISUpdateExcerptReceive',
3941

4042
# The custom error page needs to be public, since errors may happen
4143
# during traversal or publish, in both cases security may not yet

opengever/readonly/tests/test_all_roles_and_permissions_mapped.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,8 @@
182182
'opengever.disposition: Download SIP Package',
183183
'opengever.meeting: Add Member',
184184
'opengever.repository: Export repository',
185+
'opengever.ris: Return Excerpt',
186+
'opengever.ris: Update Excerpt',
185187
'opengever.sign: Sign Document',
186188
'opengever.sharing: List Protected Objects',
187189
'opengever.workspace: Access all users and groups',

0 commit comments

Comments
 (0)