Implement error handling when autoclose is not possible

Author: elioschmutz

opengever/api/tests/test_dossier_workflow.py

@@ -283,3 +283,39 @@ def test_resolve_dossier_auto_close_tasks(self, browser):
         self.assert_state('task-state-cancelled', open_task)
         self.assert_state('task-state-tested-and-closed', in_progress_task)
         self.assert_state('task-state-tested-and-closed', resolved_task)
+
+    @browsing
+    def test_resolve_dossier_auto_close_tasks_raises_error_if_auto_close_is_not_possible(self, browser):
+        self.login(self.secretariat_user, browser)
+
+        # A private task cannot be closed by the secretarian user.
+        # The api should raise an error in this case.
+        create(
+            Builder('task')
+            .within(self.resolvable_dossier)
+            .in_state('task-state-open')
+            .titled(u'Task 1')
+            .having(
+                issuer=self.regular_user.id,
+                responsible=self.regular_user.id,
+                responsible_client='fa',
+                is_private=True,
+            )
+        )
+
+        with browser.expect_http_error(code=400):
+            self.api_transition(
+                self.resolvable_dossier,
+                'dossier-transition-resolve',
+                browser,
+                data=json.dumps({"auto_close_tasks": True})
+            )
+
+        self.assertEqual(
+            {
+                u'error': {
+                    u'errors': [u'Auto-close tasks is not possible. Please close the tasks manually.'],
+                    u'type': u'AutoCloseTasksNotPossible'
+                }
+            },
+            browser.json)

opengever/api/transition.py

@@ -6,6 +6,7 @@
 from opengever.dossier.deactivate import DossierDeactivator
 from opengever.dossier.reactivate import Reactivator
 from opengever.dossier.resolve import AlreadyBeingResolved
+from opengever.dossier.resolve import AutoCloseTasksNotPossible
 from opengever.dossier.resolve import InvalidDates
 from opengever.dossier.resolve import LockingResolveManager
 from opengever.dossier.resolve import MSG_ALREADY_BEING_RESOLVED
@@ -212,6 +213,12 @@ def reply(self):
                 type='AlreadyBeingResolved',
                 message=msg))
 
+        except AutoCloseTasksNotPossible as e:
+            self.request.response.setStatus(400)
+            return dict(error=dict(
+                type='AutoCloseTasksNotPossible',
+                errors=[self.translate(e.message)]))
+
         except BadRequest as e:
             self.request.response.setStatus(400)
             return dict(error=dict(

opengever/dossier/locales/de/LC_MESSAGES/opengever.dossier.po

@@ -1,7 +1,7 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: 1.0\n"
-"POT-Creation-Date: 2025-03-24 10:10+0000\n"
+"POT-Creation-Date: 2025-06-24 08:51+0000\n"
 "PO-Revision-Date: 2017-05-23 04:53+0000\n"
 "Last-Translator: Jacqueline Sposato <jacqueline.sposato@gmail.com>\n"
 "Language-Team: German <https://translations.onegovgever.ch/projects/onegov-gever/opengever-dossier/de/>\n"
@@ -269,6 +269,11 @@ msgstr "Alle"
 msgid "any_role"
 msgstr "Alle"
 
+#. Default: "Auto-close tasks is not possible. Please close the tasks manually."
+#: ./opengever/dossier/resolve.py
+msgid "auto_close_tasks_not_possible"
+msgstr "Die Aufgaben konnten nicht automatisch geschlossen werden. Bitte schliessen Sie die Aufgaben manuell."
+
 #. Default: "Add"
 #: ./opengever/dossier/browser/forms.py
 msgid "button_add"

opengever/dossier/locales/en/LC_MESSAGES/opengever.dossier.po

@@ -1,7 +1,7 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: 1.0\n"
-"POT-Creation-Date: 2025-03-24 10:10+0000\n"
+"POT-Creation-Date: 2025-06-24 08:51+0000\n"
 "PO-Revision-Date: 2017-05-23 04:53+0000\n"
 "Last-Translator: Jacqueline Sposato <jacqueline.sposato@gmail.com>\n"
 "Language-Team: German <https://translations.onegovgever.ch/projects/onegov-gever/opengever-dossier/de/>\n"
@@ -336,6 +336,11 @@ msgstr "Any participant"
 msgid "any_role"
 msgstr "Any role"
 
+#. Default: "Auto-close tasks is not possible. Please close the tasks manually."
+#: ./opengever/dossier/resolve.py
+msgid "auto_close_tasks_not_possible"
+msgstr "Auto-close tasks is not possible. Please close the tasks manually."
+
 #. German translation: Erstellen
 #. Default: "Add"
 #: ./opengever/dossier/browser/forms.py

opengever/dossier/locales/fr/LC_MESSAGES/opengever.dossier.po

@@ -1,7 +1,7 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
-"POT-Creation-Date: 2025-03-24 10:10+0000\n"
+"POT-Creation-Date: 2025-06-24 08:51+0000\n"
 "PO-Revision-Date: 2017-12-03 11:16+0000\n"
 "Last-Translator: Jacqueline Sposato <jacqueline.sposato@gmail.com>\n"
 "Language-Team: French <https://translations.onegovgever.ch/projects/onegov-gever/opengever-dossier/fr/>\n"
@@ -267,6 +267,11 @@ msgstr "Tous"
 msgid "any_role"
 msgstr "Tous"
 
+#. Default: "Auto-close tasks is not possible. Please close the tasks manually."
+#: ./opengever/dossier/resolve.py
+msgid "auto_close_tasks_not_possible"
+msgstr "La fermeture automatique des tâches n'est pas possible. Veuillez clôturer les tâches manuellement."
+
 #. Default: "Add"
 #: ./opengever/dossier/browser/forms.py
 msgid "button_add"

opengever/dossier/locales/opengever.dossier.pot

@@ -4,7 +4,7 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
-"POT-Creation-Date: 2025-03-24 10:10+0000\n"
+"POT-Creation-Date: 2025-06-24 08:51+0000\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI +ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@li.org>\n"
@@ -268,6 +268,11 @@ msgstr ""
 msgid "any_role"
 msgstr ""
 
+#. Default: "Auto-close tasks is not possible. Please close the tasks manually."
+#: ./opengever/dossier/resolve.py
+msgid "auto_close_tasks_not_possible"
+msgstr ""
+
 #. Default: "Add"
 #: ./opengever/dossier/browser/forms.py
 msgid "button_add"

opengever/dossier/resolve.py

@@ -19,6 +19,7 @@
 from opengever.dossier.statusmessage_mixin import DossierResolutionStatusmessageMixin
 from opengever.task.task import ITask
 from plone import api
+from plone.api.exc import InvalidParameterError
 from Products.CMFCore.Expression import createExprContext
 from Products.CMFCore.Expression import Expression
 from Products.CMFCore.utils import getToolByName
@@ -64,6 +65,11 @@ def __init__(self, invalid_dossier_titles):
         self.invalid_dossier_titles = invalid_dossier_titles
 
 
+class AutoCloseTasksNotPossible(Exception):
+    """Could not auto close the tasks. Please do it manually.
+    """
+
+
 def get_resolver(dossier):
     """Return the currently configured dossier-resolver."""
 
@@ -196,7 +202,12 @@ def _auto_close_tasks(self, tasks):
         """Auto-close all pending tasks."""
         for brain in tasks:
             task = brain.getObject()
-            task.force_finish_task()
+            try:
+                task.force_finish_task()
+            except InvalidParameterError:
+                raise AutoCloseTasksNotPossible(
+                    _('auto_close_tasks_not_possible',
+                      default=u'Auto-close tasks is not possible. Please close the tasks manually.'))
 
     def _get_pending_tasks(self):
         """Get all pending tasks in dossier."""