Merge pull request #8160 from 4teamwork/es/TI-2422-task-permission-revoke

Fix revocation of temporary dossier permissions when a task is cancelled from the "in progress" state.

Author: elioschmutz

changes/TI-2422.bugfix

@@ -0,0 +1 @@
+Ensure that temporary dossier permissions are correctly revoked when a task is cancelled from the "in progress" state. [elioschmutz]

opengever/task/__init__.py

@@ -43,6 +43,7 @@
 
 FINAL_TRANSITIONS = [
     'task-transition-open-cancelled',
+    'task-transition-in-progress-cancelled',
     'task-transition-open-tested-and-closed',
     'task-transition-in-progress-tested-and-closed',
     'task-transition-resolved-tested-and-closed',

opengever/task/tests/test_localroles.py

@@ -771,6 +771,30 @@ def test_cancelling_a_task_revokes_roles(self, browser):
         storage = RoleAssignmentManager(self.subtask).storage
         self.assertEqual([], storage._storage())
 
+    @browsing
+    def test_cancelling_a_task_in_progress_revokes_roles(self, browser):
+        self.login(self.dossier_responsible, browser=browser)
+        self.set_workflow_state('task-state-in-progress', self.subtask)
+        storage = RoleAssignmentManager(self.subtask).storage
+
+        self.assertEqual(
+            [{'cause': ASSIGNMENT_VIA_TASK,
+              'roles': ['Editor'],
+              'reference': Oguid.for_object(self.subtask),
+              'principal': self.regular_user.id},
+             {'cause': ASSIGNMENT_VIA_TASK_AGENCY,
+              'roles': ['Editor'],
+              'reference': Oguid.for_object(self.subtask),
+              'principal': 'fa_inbox_users'}],
+            storage._storage())
+
+        # cancel
+        browser.open(self.subtask, view='tabbedview_view-overview')
+        browser.click_on('Cancel')
+        browser.click_on('Save')
+
+        self.assertEqual([], storage._storage())
+
     @browsing
     def test_cancelling_a_task_does_not_revoke_roles_if_revoke_permission_is_false(self, browser):
         self.login(self.dossier_responsible, browser=browser)