Skip to content

Commit e4daaf6

Browse files
author
Nikita Denisenko
committed
Alert rules: remove url params from AlertRules() method
1 parent adcc4e9 commit e4daaf6

File tree

1 file changed

+5
-23
lines changed

1 file changed

+5
-23
lines changed

alerting_alert_rule.go

+5-23
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package gapi
33
import (
44
"encoding/json"
55
"fmt"
6-
"net/url"
76
"time"
87
)
98

@@ -65,30 +64,13 @@ type RelativeTimeRange struct {
6564

6665
// AlertRules fetches and returns Grafana alertRules.
6766
func (c *Client) AlertRules() ([]AlertRule, error) {
68-
const limit = 1000
69-
70-
var (
71-
page = 0
72-
newAlertRules []AlertRule
73-
alertRules []AlertRule
74-
query = make(url.Values)
75-
)
76-
query.Set("limit", fmt.Sprint(limit))
77-
78-
for {
79-
page++
80-
query.Set("page", fmt.Sprint(page))
81-
82-
if err := c.request("GET", "/api/v1/provisioning/alert-rules", query, nil, &newAlertRules); err != nil {
83-
return nil, err
84-
}
85-
86-
alertRules = append(alertRules, newAlertRules...)
67+
var alertRules []AlertRule
8768

88-
if len(newAlertRules) < limit {
89-
return alertRules, nil
90-
}
69+
if err := c.request("GET", "/api/v1/provisioning/alert-rules", nil, nil, &alertRules); err != nil {
70+
return nil, err
9171
}
72+
73+
return alertRules, nil
9274
}
9375

9476
// AlertRule fetches a single alert rule, identified by its UID.

0 commit comments

Comments
 (0)