Skip to content

Commit 47750c1

Browse files
calliclesclaude
andcommitted
Correct docs and the sort label ahead of the next release
A docs audit and QA pass over main (0.4.0 plus #37-#40) turned up a handful of places where the docs and the UI had drifted apart: - CHANGELOG: link issue #35 alongside PR #38 on the TTL-outlier entry, to match how the sibling entries cite their issue. Amend the 80-column entry to cover the Time -> Ping header rename and the matching `--once` column widths and right-aligned TTL, and the error-badge entry to mention that the badge also covers the "not a domain name" label. Drop a stray blank line between two bullets in the released 0.4.0 section. - README: bump the Nix pin example to v0.4.0, the newest tag that exists. - app.rs: `SortMode::label` still said "time" for the latency sort, so the footer disagreed with the column #40 renamed to Ping. Say "ping", and update the README key-binding row to match. No changelog entry of its own: the label ships unreleased, covered by the amended #40 entry. - main.rs: document the `"<fg> on <bg>"` theme form in the long --help, which #40 added but never wrote down. - AGENTS.md: the module map was missing theme.rs, globe.rs and world_data.rs, still described sites.rs as id.server-only (NSID leads since #39) and config.rs as resolvers-only (it owns theme/ecs/view too), and app.rs now owns TableLayout. Verified: cargo fmt --check, clippy -D warnings and 120 tests pass; `--once` prints its table; --help shows the new theme line; and driving the real binary through a PTY shows the footer read "sort: ping" after cycling Ctrl+S twice to the latency mode. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent ec8dd01 commit 47750c1

5 files changed

Lines changed: 20 additions & 13 deletions

File tree

AGENTS.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,15 @@ human contributor.
1010
| File | Owns |
1111
|---|---|
1212
| `src/main.rs` | CLI (clap), event loop, key handling, `--once` mode |
13-
| `src/app.rs` | `App` state, input editing, answer grouping, TTL verdicts |
13+
| `src/app.rs` | `App` state, input editing, answer grouping, TTL verdicts, table column layout |
1414
| `src/ui.rs` | All rendering: map, table, gauge, footer |
15+
| `src/theme.rs` | UI color roles, `Paint`/`Muted` parsing |
16+
| `src/globe.rs` | Orthographic globe projection and panel geometry |
17+
| `src/world_data.rs` | Coastline vector data |
1518
| `src/dns.rs` | Resolver queries and error mapping |
1619
| `src/resolvers.rs` | Built-in resolver list |
17-
| `src/config.rs` | TOML config file (custom resolvers) |
18-
| `src/sites.rs` | Anycast POP discovery (id.server probes, IATA codes) |
20+
| `src/config.rs` | TOML config file (resolvers, theme, ecs, view) |
21+
| `src/sites.rs` | Anycast POP discovery (NSID, id.server fallback, IATA codes) |
1922

2023
Keep logic in `app.rs` (testable, no I/O) and rendering in `ui.rs`. Key
2124
bindings live in `handle_key` in `main.rs` and should call one-line `App`

CHANGELOG.md

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,11 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
1313
(Ping, TTL, Exp) are right-aligned so their digits line up, units that the
1414
header already implies are gone, and where there isn't room for the
1515
spelled-out status the verdict moves to a glyph in the left margin
16-
(`✓ ≠ ! ↻ ∅ ✗`) — one place to scan for failures. Wider terminals are
17-
unchanged: they keep the status word, the same answer column and the same
18-
map/globe thresholds.
16+
(`✓ ≠ ! ↻ ∅ ✗`) — one place to scan for failures. The round-trip column is
17+
now headed `Ping` (it was `Time`). Wider terminals are unchanged: they keep
18+
the status word, the same answer column and the same map/globe thresholds.
19+
`--once` matches: it prints the same name/location/IP column widths as the
20+
TUI and right-aligns its TTL, so the two views line up.
1921
([#33](https://github.com/514-labs/dnsglobe/issues/33),
2022
[#40](https://github.com/514-labs/dnsglobe/pull/40))
2123
- The per-row expiry countdown is coarse: at most two digits and a unit
@@ -25,7 +27,8 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
2527
precise figure (`TTL ≈ 2h23m`).
2628
([#33](https://github.com/514-labs/dnsglobe/issues/33),
2729
[#40](https://github.com/514-labs/dnsglobe/pull/40))
28-
- Failures now show as a white-on-red badge on the status glyph and word
30+
- Failures now show as a white-on-red badge — on the status glyph and word in
31+
the table, and on the `not a domain name` label under a malformed input —
2932
rather than red text, which went washed-out on terminal themes with a
3033
mid-toned background (macOS Terminal's "Ocean"). Only the marker is
3134
filled — error messages, map dots, the propagation gauge and slow ping
@@ -72,7 +75,8 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
7275
tenth of it), and any resolver that reported one is named on the note line
7376
with what it claims — that cache really will serve the old answer after a
7477
change, and it is worth knowing which one it is.
75-
([#38](https://github.com/514-labs/dnsglobe/pull/38))
78+
([#35](https://github.com/514-labs/dnsglobe/issues/35),
79+
[#38](https://github.com/514-labs/dnsglobe/pull/38))
7680

7781
## [0.4.0] - 2026-07-11
7882

@@ -110,7 +114,6 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
110114
toggles by hand and pins the choice; `--view auto|map|globe` or `view =
111115
"..."` in the config file force it outright (flag beats config).
112116
([#26](https://github.com/514-labs/dnsglobe/pull/26))
113-
114117
- Nix flake support: `nix run github:514-labs/dnsglobe` builds and runs
115118
dnsglobe from source on any system with Nix flakes enabled; specific
116119
releases can be pinned via git tag (`github:514-labs/dnsglobe/v0.3.0`).

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ their own location, not the probed network.
104104
| ↑/↓ / PgUp/PgDn | move the highlight through the resolver table (scrolls to follow) |
105105
| + | add a resolver for this session (name, IP, optional location and map position) |
106106
| Ctrl+X | remove the highlighted resolver for this session |
107-
| Ctrl+S | cycle table sort: resolver / location / time / status / answer |
107+
| Ctrl+S | cycle table sort: resolver / location / ping / status / answer |
108108
| Ctrl+O | toggle the world view between flat map and rotating globe |
109109
| Ctrl+N | cycle the ECS client subnet and re-query (only when `--ecs`/config set one up) |
110110
| Ctrl+U | clear domain |
@@ -187,7 +187,7 @@ The project provides optional Nix flake outputs for users who already use Nix. T
187187
nix run github:514-labs/dnsglobe
188188

189189
# Specific release (uses the flake at that git tag)
190-
nix run github:514-labs/dnsglobe/v0.3.1
190+
nix run github:514-labs/dnsglobe/v0.4.0
191191

192192
# Named outputs (if the flake exposes them): #latest, #source
193193
nix run github:514-labs/dnsglobe#source

src/app.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ impl SortMode {
7979
match self {
8080
SortMode::Resolver => "resolver",
8181
SortMode::Location => "location",
82-
SortMode::Time => "time",
82+
SortMode::Time => "ping",
8383
SortMode::Status => "status",
8484
SortMode::Answer => "answer",
8585
}

src/main.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ Configuration:
4545
# stale = \"208\" # stale, upstream, muted, coastline, grid
4646
# muted = \"faint\" # colors: ANSI names (\"lightred\"), 256-color
4747
# # indexes (\"208\"), or hex (\"#ff8700\"); `muted`
48-
# # also takes \"faint\" (dim the default foreground)";
48+
# # also takes \"faint\" (dim the default foreground)
49+
# error = \"white on lightred\" # \"<fg> on <bg>\" badges the failure marker";
4950

5051
/// Global DNS propagation checker TUI — watch a DNS record propagate across
5152
/// public resolvers worldwide, on a world map in your terminal.

0 commit comments

Comments
 (0)