Skip to content

Commit 7d83345

Browse files
Benoit Aubuchonclaude
andcommitted
docs: correct credential rotation comment for ClickHouse Cloud
The previous comment claimed credential rotation is always detected as a mismatch. This is only true when display_secrets_in_show_and_select is ON (self-hosted default). On ClickHouse Cloud (OFF by default), credentials appear as [HIDDEN] and fill_hidden_credentials() substitutes them from desired — rotation cannot be detected in that configuration. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 1390a95 commit 7d83345

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

apps/framework-cli/src/framework/core/infra_reality_checker.rs

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1181,9 +1181,15 @@ impl<T: OlapOperations + Sync> InfraRealityChecker<T> {
11811181

11821182
// Structural comparison: for each dict present in both the infra map and CH,
11831183
// compare the DDL body from SHOW CREATE DICTIONARY against the infra map
1184-
// definition. Credentials are compared as-is (runtime env vars are resolved
1185-
// before calling to_create_if_not_exists_sql, so a credential rotation is
1186-
// correctly detected as a mismatch).
1184+
// definition.
1185+
//
1186+
// Credential visibility depends on the ClickHouse setting
1187+
// `display_secrets_in_show_and_select`:
1188+
// - When ON (self-hosted default): credentials appear in SHOW CREATE output,
1189+
// so a credential rotation IS detected as a mismatch.
1190+
// - When OFF (ClickHouse Cloud default): credentials are replaced with
1191+
// [HIDDEN]; dicts_ddl_equivalent() substitutes them from desired so the
1192+
// comparison succeeds, but credential rotation cannot be detected.
11871193
//
11881194
// Limitation: SHOW CREATE DICTIONARY may order clauses differently from our
11891195
// generated DDL (e.g. LIFETIME before LAYOUT). dicts_ddl_equivalent() sorts

0 commit comments

Comments
 (0)