Skip to content

Commit af66ea1

Browse files
committed
chore(cli): address PR feedback — test imports, nerdctl in runtime hint
- Move Message import to mod tests scope (CodeRabbit) - Mention nerdctl in install-options bullet (514Ben) Made-with: Cursor
1 parent a27242f commit af66ea1

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

apps/framework-cli/src/cli.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2388,7 +2388,10 @@ async fn confirm_and_save_migration_legacy(
23882388

23892389
#[cfg(test)]
23902390
mod tests {
2391-
use crate::{cli::settings::read_settings, utilities::machine_id::get_or_create_machine_id};
2391+
use crate::{
2392+
cli::display::Message, cli::settings::read_settings,
2393+
utilities::machine_id::get_or_create_machine_id,
2394+
};
23922395

23932396
use super::*;
23942397

@@ -2492,7 +2495,6 @@ mod tests {
24922495

24932496
#[test]
24942497
fn format_infrastructure_routine_failure_preserves_details_and_error() {
2495-
use crate::cli::display::Message;
24962498
let rf = RoutineFailure::new(
24972499
Message::new(
24982500
"Failed".to_string(),
@@ -2512,7 +2514,6 @@ mod tests {
25122514

25132515
#[test]
25142516
fn format_infrastructure_routine_failure_without_source_error() {
2515-
use crate::cli::display::Message;
25162517
let rf = RoutineFailure::error(Message::new(
25172518
"Build".to_string(),
25182519
"something went wrong".to_string(),

apps/framework-cli/src/cli/routines/util.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ fn container_runtime_not_found_message(configured: &str) -> String {
99
\n\
1010
Choose one of the following:\n\
1111
\n\
12-
• Install a Docker-compatible CLI (Docker Desktop, Docker Engine, or Finch) and ensure the command is on your `PATH`.\n\
12+
• Install a Docker-compatible CLI (Docker Desktop, Docker Engine, Finch, or nerdctl) and ensure the command is on your `PATH`.\n\
1313
\n\
1414
• Point Moose at a specific binary: set `container_cli_path` under `[dev]` in `~/.moose/config.toml`, or set the\n\
1515
environment variable `MOOSE_DEV__CONTAINER_CLI_PATH` to the full path of your `docker`, `finch`, or `nerdctl` executable.\n\

0 commit comments

Comments
 (0)