Is it known that the docs are badly out of date and very confusing or outright not true?
At least Google provider related ones, here are some examples:
1. 3 separate providers listed in Integrations
- Gemini
- Google GenAI
- Vertex AI (deprecated)
Relation between Gemini vs GenAI is especially unclear as the seem to be one of the same, but docs slightly differ.
2. Outdated "limitations" of Google provider
- Optional values appear to be working, Enums also work in
GENAI_STRUCTURED_OUTPUTS mode.
Docs say google/<model> + vertexai=True is deprecated and vertexai/<model> should be used, but code would emit deprecation warnings which say exactly the opposite:
|
elif provider == "vertexai": |
|
warnings.warn( |
|
"The 'vertexai' provider is deprecated. Use 'google' provider with vertexai=True instead. " |
|
"Example: instructor.from_provider('google/gemini-pro', vertexai=True)", |
|
DeprecationWarning, |
|
stacklevel=2, |
|
) |
4. Incorrect mode enums.
Docs mostly specify Mode.TOOLS, Mode.JSON like here or here or here and I think basically everywhere. Yet code would throw an error on those as only GENAI_TOOLS and GENAI_STRUCTURED_OUTPUTS are supported:
|
valid_modes = { |
|
instructor.Mode.GENAI_TOOLS, |
|
instructor.Mode.GENAI_STRUCTURED_OUTPUTS, |
|
} |
I found this issues quite weird given that otherwise this library seems to be well maintained.
Is it known that the docs are badly out of date and very confusing or outright not true?
At least Google provider related ones, here are some examples:
1. 3 separate providers listed in Integrations
Relation between Gemini vs GenAI is especially unclear as the seem to be one of the same, but docs slightly differ.
2. Outdated "limitations" of Google provider
GENAI_STRUCTURED_OUTPUTSmode.3. Incorrect/inconsistent Vertex AI migration info
Docs say
google/<model>+vertexai=Trueis deprecated andvertexai/<model>should be used, but code would emit deprecation warnings which say exactly the opposite:instructor/instructor/auto_client.py
Lines 857 to 863 in 3f1d6dd
4. Incorrect
modeenums.Docs mostly specify
Mode.TOOLS,Mode.JSONlike here or here or here and I think basically everywhere. Yet code would throw an error on those as onlyGENAI_TOOLSandGENAI_STRUCTURED_OUTPUTSare supported:instructor/instructor/providers/genai/client.py
Lines 35 to 38 in 3f1d6dd
I found this issues quite weird given that otherwise this library seems to be well maintained.