Fixed leaking Guzzle exceptions from the HTTP client

Author: tg666

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.5.1] - 2025-11-10
+### Fixed
+- Fixed leaking Guzzle exceptions (e.g. `ConnectException`) from the HTTP client. An exception `UnexpectedErrorException` is thrown instead.
+
 ## [1.5.0] - 2024-05-23
 ### Added
 - Added support for content type `noContent`.

src/Http/Middleware/UnexpectedErrorMiddleware.php

@@ -5,6 +5,7 @@
 namespace SixtyEightPublishers\AmpClient\Http\Middleware;
 
 use Closure;
+use Exception;
 use GuzzleHttp\Promise\PromiseInterface;
 use Psr\Http\Message\RequestInterface;
 use SixtyEightPublishers\AmpClient\Exception\AmpExceptionInterface;
@@ -27,7 +28,11 @@ public function __invoke(Closure $next): Closure
     {
         return static function (RequestInterface $request, array $options) use ($next): PromiseInterface {
             try {
-                return $next($request, $options);
+                return $next($request, $options)->otherwise(static function ($e) {
+                    $throwable = $e instanceof Throwable ? $e : new Exception('Unknown error.');
+
+                    throw ($throwable instanceof AmpExceptionInterface ? $throwable : new UnexpectedErrorException($throwable));
+                });
             } catch (Throwable $e) {
                 throw ($e instanceof AmpExceptionInterface ? $e : new UnexpectedErrorException($e));
             }