remove unnecessary Unsafe enum casting optimization that causes compiler warning

a simple cast produces the same JIT optimized assembly

Author: mayfieldiv

Core/Generators/CSharp/CSharpGenerator.cs

@@ -1074,7 +1074,7 @@ private string CompileEncodeField(TypeBase type, string target, int depth = 0, i
                     _ => throw new ArgumentOutOfRangeException()
                 },
                 DefinedType dt when Schema.Definitions[dt.Name] is EnumDefinition ed =>
-                    CompileEncodeField(ed.ScalarType, $"{As(PrefixNamespace(dt.Name.ToPascalCase()), TypeName(ed.ScalarType), target)}", depth, indentDepth),
+                    CompileEncodeField(ed.ScalarType, $"({TypeName(ed.ScalarType)}){target}", depth, indentDepth),
                 DefinedType dt =>
                     $"{PrefixNamespace(dt.Name.ToPascalCase())}.__EncodeInto({target}, ref writer);",
                 _ => throw new InvalidOperationException($"CompileEncodeField: {type}")
@@ -1134,7 +1134,7 @@ private string CompileDecodeField(TypeBase type, string target, int depth = 0)
                     "}",
                 ScalarType st => $"{target} = {ReadBaseType(st.BaseType)};",
                 DefinedType dt when Schema.Definitions[dt.Name] is EnumDefinition ed =>
-                    $"{target} = {As(TypeName(ed.ScalarType), PrefixNamespace(dt.Name.ToPascalCase()), ReadBaseType(ed.BaseType))};",
+                    $"{target} = ({PrefixNamespace(dt.Name.ToPascalCase())}){ReadBaseType(ed.BaseType)};",
                 DefinedType dt =>
                     $"{target} = {PrefixNamespace(dt.Name.ToPascalCase())}.__DecodeFrom(ref reader);",
                 _ => throw new InvalidOperationException($"CompileDecodeField: {type}")
@@ -1352,11 +1352,6 @@ private string TypeName(in TypeBase type, string arraySizeVar = "")
             };
         }
 
-        private static string As(string from, string to, string value)
-        {
-            return $"System.Runtime.CompilerServices.Unsafe.As<{from}, {to}>(ref System.Runtime.CompilerServices.Unsafe.AsRef({value}))";
-        }
-
         public override string Alias { get => "cs"; set => throw new NotImplementedException(); }
         public override string Name { get => "C#"; set => throw new NotImplementedException(); }
 

Laboratory/Integration/IntegrationTesting.csproj

@@ -6,7 +6,6 @@
     <LangVersion>preview</LangVersion>
     <TargetFramework>net8.0</TargetFramework>
     <CheckEolTargetFramework>false</CheckEolTargetFramework>
-      <NoWarn>$(NoWarn);CS9193</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>