Merge pull request #380 from Zaczero/master

Better Python Runtime

Author: andrewmd5

Core/Generators/Python/PythonGenerator.cs

@@ -113,7 +113,7 @@ private string CompileEncodeField(TypeBase type, string target, int depth = 0, i
             var enumAppendix = isEnum ? ".value" : "";
             return type switch
             {
-                ArrayType at when at.IsBytes() => $"writer.writeBytes({target})",
+                ArrayType at when at.IsBytes() => $"writer.write_bytes({target})",
                 ArrayType at =>
                     $"length{depth} = len({target})" + nl +
                     $"writer.write_uint32(length{depth})" + nl +
@@ -254,7 +254,7 @@ private string CompileDecodeField(TypeBase type, string target, int depth = 0)
             var i = GeneratorUtils.LoopVariable(depth);
             return type switch
             {
-                ArrayType at when at.IsBytes() => $"{target} = reader.readBytes()",
+                ArrayType at when at.IsBytes() => $"{target} = reader.read_bytes()",
                 ArrayType at =>
                     $"length{depth} = reader.read_uint32()" + nl +
                     $"{target} = []" + nl +

Laboratory/Integration/Python/src/lib.py

@@ -1,5 +1,5 @@
 from schema import Library, Instrument, Album, StudioAlbum, LiveAlbum, Song, Musician
-from datetime import datetime
+from datetime import datetime, timezone
 from uuid import UUID
 
 def make_lib():
@@ -24,7 +24,7 @@ def make_lib():
 
     adams_apple_album = LiveAlbum()
     adams_apple_album.venueName = "Tunisia"
-    adams_apple_album.concertDate = datetime.fromtimestamp(528205479)
+    adams_apple_album.concertDate = datetime.fromtimestamp(528205479, tz=timezone.utc)
 
     unnamed_song = Song()
     unnamed_song.year = 1965

Laboratory/Python/test/test_basic_types.py

@@ -1,5 +1,5 @@
 from schemas import BasicTypes
-from datetime import datetime
+from datetime import datetime, timezone
 from uuid import UUID
 
 
@@ -17,7 +17,7 @@ def test_write_read():
         a_float64=2.0,
         a_string="a_string",
         a_guid=UUID("ff1ed055-1839-4d7f-84d3-5ca28fa298b9"),
-        a_date=datetime(1999, 5, 17),
+        a_date=datetime(1999, 5, 17, tzinfo=timezone.utc),
     )
 
     encoded = BasicTypes.encode(bt)
@@ -36,6 +36,6 @@ def test_write_read():
     assert decoded.a_float64 == 2.0
     assert decoded.a_string == "a_string"
     assert decoded.a_guid == UUID("ff1ed055-1839-4d7f-84d3-5ca28fa298b9")
-    assert decoded.a_date == datetime(1999, 5, 17)
+    assert decoded.a_date == datetime(1999, 5, 17, tzinfo=timezone.utc)
 
 

Laboratory/Python/test/test_date_precision.py

@@ -0,0 +1,20 @@
+from datetime import datetime, timezone
+
+from python_bebop.bebop import BebopReader, BebopWriter
+
+
+def test_date_precision_and_utc():
+    # Arrange: Create a writer and a date with specific microseconds in UTC
+    writer = BebopWriter()
+    expected_dt = datetime(2023, 1, 1, 12, 0, 0, 123456, tzinfo=timezone.utc)
+
+    # Act: Write the date and read it back
+    writer.write_date(expected_dt)
+    buffer = writer.to_list()
+    reader = BebopReader.from_buffer(bytearray(buffer))
+    actual_dt = reader.read_date()
+
+    # Assert: Verify precision (microseconds) and Timezone (UTC) are preserved
+    assert actual_dt.microsecond == 123456
+    assert actual_dt.tzinfo == timezone.utc
+    assert actual_dt == expected_dt

Laboratory/Python/test/test_writer_framing.py

@@ -0,0 +1,22 @@
+from python_bebop.bebop import BebopReader, BebopWriter
+
+
+def test_fill_message_length_writes_4_bytes():
+    # Arrange: Prepare writer with reserved length slot and dummy payload
+    writer = BebopWriter()
+    length_index = writer.reserve_message_length()
+    payload = bytearray(b"\x01" * 10)
+    # Manually write payload since write_bytes now enforces length prefix
+    writer._buffer += payload
+
+    # Act: Backfill the correct length into the reserved slot
+    writer.fill_message_length(length_index, len(payload))
+
+    # Assert: Verify the length was written correctly by reading it back
+    reader = BebopReader.from_buffer(bytearray(writer.to_list()))
+
+    read_length = reader.read_message_length()
+    assert read_length == 10
+
+    remaining = reader._buffer[reader.index :]
+    assert remaining == payload

Runtime/Python/setup.cfg

@@ -6,13 +6,13 @@ author_email = korbinian.habereder@gmail.com
 description = bebop runtime bindings for Python
 long_description = file: README.md
 long_description_content_type = text/markdown
-url = https://github.com/liquidiert/bebop
+url = https://github.com/6over3/bebop
 project_urls =
-    Bug Tracker = https://github.com/liquidiert/bebop
+    Bug Tracker = https://github.com/6over3/bebop
 classifiers =
     Programming Language :: Python :: 3
-    License :: OSI Approved :: Apache Software License
     Operating System :: OS Independent
+license = Apache-2.0
 
 [options]
 package_dir =