refactor(hosted-web): establish runtime feature boundaries - #252
refactor(hosted-web): establish runtime feature boundaries#252777genius wants to merge 942 commits into
Conversation
|
Important Review skippedToo many files! This PR contains 2784 files, which is 2634 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2784)
You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests (beta)
|
ReviewRouter
Summary
Review Scope
Files not shown as full diffs in the primary prompt:
Codex providers with agentic context can inspect related files read-only during review. This section is still shown so a "no findings" result on a large PR is auditable. Findings🟡 Major (5)🟡 1. Missing backup run repository module breaks buildReported Location: This new feature imports Model: codex/gpt-5.5 🟡 2. Renamed readiness types are not exported by the unchanged contract layerReported Location: This file now imports Model: codex/gpt-5.5 🟡 3. Imported gateway is not exportedReported Location: This changed import pulls Model: codex/gpt-5.5 🟡 4. Case variants bypass roster uniquenessReported Location: The replace-members IPC only checks View reasoningEvidence: 🟡 Medium Confidence (50% confidence) 100% provider agreement, direct evidence in changed code Model: codex/gpt-5.5 🟡 5. Worker message feed cache is not invalidatedReported Location: The helper invalidates the main-thread message feed cache via View reasoningEvidence: 🟡 Medium Confidence (50% confidence) 100% provider agreement, direct evidence in changed code Model: codex/gpt-5.5 Previous Review ThreadsLifecycle attention required
Performance Metrics
Provider Performance:
503.5s • OAuth subscription • Powered by ReviewRouter |
Pushes to refactor/team-provisioning-round2-reapply and refactor/hosted-web-feature-boundaries ran no CI (push triggers covered only main and dev, and pull_request runs silently stop whenever PR #252 goes CONFLICTING). Regressions repeatedly lived on these branches for days before surfacing through unrelated merges. Trigger the same CI on direct pushes so the branches keep themselves green.
|
ReviewRouter override state - signed Active skips
|
|
Recorded |
2 similar comments
|
Recorded |
|
Recorded |
|
/rr review |
1f85c50 to
b16b452
Compare
b16b452 to
597884f
Compare
|
Phase 03 authority is now revision r2 at exact head Independent cross-repository adjudication found that the existing signed-v4 path is a consumer, not the authenticated activation producer required between orchestrator The OpenCode repository remains a temporary bounded downstream patch queue, not an independently evolving product. Upstream tracking, removal criteria and the v1.18.21 convergence checklist are recorded in #471. The current v1.18.4 candidate remains |
Status
Draft cross-repository MVP integration for the Hosted Web runtime. The canonical MVP scope lock is
docs/hosted-web-core-v1-scope-lock.md; broader parity work remains deferred.Current exact product head:
1ff1cee536fd2e56a560e7562fa16e22903cc4ac.Exact
devhead integrated through the latest ordered merge:597884ffc2b5f3eaf625f49a13f906de54f9a7aaincludes the newerdevline on top of the earlier693abcfe3b8a5628661d52ef82c89d08450c31acintegration.What this PR owns
Preserved related work
chore/hosted-approval-v153-wip-preservationat6324ff3dae5e92678c74b5b0f4e61cd45ca8d875remains preservation evidence only and must not be merged wholesale.chore/hosted-actual-owner-attestation-preservationcommit332b1e12fbfec45fadccd00ed6fed2aee5b0f911, patch SHA-256c313229ac23354cf803c3f46e99574f4672f582d437bed0348e450bca70ab6cb. It is preservation evidence only and requires isolated semantic validation before any adoption.Exact-head evidence
The current head includes:
597884ffc2b5f3eaf625f49a13f906de54f9a7aa- latestdevintegration merge pushed to this PR1492ba3c8f8f70f3b393c2d18bef86fb2886fcb2- earlier exactdevintegration mergee1b4dc9517bce3ea0773c5b8473fb1ddf574bf7f- HTTP client source-size preservation65691e58a- merged quality-ratchet restoration9fc2546e8- formatted source-size ratchet correctionLocal exact-head evidence is green: project typecheck, exact changed-file lint, source-size ratchet verification, hosted phase-0 evidence integrity, feature architecture, and Team Provisioning architecture.
The previous exact head was green for validation, lint, build, CodeQL, dependency review, runtime install smoke, core/phase-6/lifecycle browser suites, required lifecycle UI, and phase-8. CI for the current artifact-pin head is running.
The current ReviewRouter retry fails before model review with
codex_oauth_control_plane_error:400:invalid_action_requestafteraction_session_exchange_failed:403:legacy_review_mutation_blocked. This is tracked as review infrastructure/control-plane failure, not a clean review or a code finding.The product and orchestrator repositories consume a byte-identical
docs/hosted-approval-wire-v4-golden.jsonwith SHA-2562594e9816f6116a406fe1b367fbd9c4231a9698c1cb7a395c2967ef2f32f1572; the focused product wire suite passes 14/14. This closes the raw-byte v4 drift gate only. It does not prove trusted publisher reachability or actual-owner activation.Existing browser and fixture suites are regression evidence only. They do not prove the final external-owner flow.
Remaining acceptance work
The canonical route is
docs/hosted-web-phases/phase-03/, revisionphase-03-actual-owner-closure-r1:No worker may enable a production gate, launch a real project, or treat the scalar compatibility lifecycle coordinator as signed-v4 authority.
Downstream policy
The bounded OpenCode compatibility patch, upstream update cadence, release evidence, and fork removal criteria are documented in docs/hosted-opencode-downstream-policy.md.
Cross-repository dependencies
6184e58ecb474fc90697c2c4b4976782299c5b60Merge rule
Keep this PR draft until exact product and owner artifacts are integrated and the sandbox actual-owner E2E passes. Fake-runtime suites cannot be used as the final completion claim.
Safety rule
All launch, provisioning, terminal, task assignment, agent command, runtime smoke, and final E2E checks use only new sandbox/test projects. Real user projects are never used.