Skip to content

Commit 54f0ff8

Browse files
committed
fix: document review thread resolve limits
1 parent 97c00fc commit 54f0ff8

4 files changed

Lines changed: 8 additions & 6 deletions

File tree

dist/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27564,9 +27564,9 @@ ${this.ledger.statusText(loaded.payload, headSha)}` : `ReviewRouter override led
2756427564
`${resolved ? "Resolved" : "Unresolved"} ReviewRouter conversation for comment ${parentCommentId}`
2756527565
);
2756627566
} catch (error2) {
27567+
const reason = sanitizeNoticeError(error2);
2756727568
logger.warn(
27568-
`Failed to ${resolved ? "resolve" : "unresolve"} ReviewRouter conversation for comment ${parentCommentId}`,
27569-
error2
27569+
`Failed to ${resolved ? "resolve" : "unresolve"} ReviewRouter conversation for comment ${parentCommentId}: ${reason}`
2757027570
);
2757127571
}
2757227572
}

dist/index.js.map

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/install.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -305,6 +305,8 @@ If a blocking inline finding is a verified false positive, reply to that specifi
305305

306306
The reason is optional. The installer generates a second non-required workflow, `.github/workflows/review-router-interaction.yml`, for `/rr ...` replies and optional discussion replies. `/rr skip` does not run Codex and does not checkout pull request code. It only verifies the command, updates the signed PR ledger, and reruns the failed `ReviewRouter / review` check when the token has `actions: write`.
307307

308+
ReviewRouter also attempts to mark the skipped review thread as resolved. GitHub does not currently allow the standard `github-actions[bot]` token to run the `resolveReviewThread` GraphQL mutation, even with `pull-requests: write`, so this is best-effort in Actions bot mode. GitHub App bot mode can use the App installation token when GitHub grants that mutation to the App.
309+
308310
Permission policy:
309311

310312
- Critical and Major findings require `maintain` or `admin`.

src/github/interaction.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,9 +256,9 @@ export class ReviewInteractionHandler {
256256
`${resolved ? 'Resolved' : 'Unresolved'} ReviewRouter conversation for comment ${parentCommentId}`
257257
);
258258
} catch (error) {
259+
const reason = sanitizeNoticeError(error);
259260
logger.warn(
260-
`Failed to ${resolved ? 'resolve' : 'unresolve'} ReviewRouter conversation for comment ${parentCommentId}`,
261-
error as Error
261+
`Failed to ${resolved ? 'resolve' : 'unresolve'} ReviewRouter conversation for comment ${parentCommentId}: ${reason}`
262262
);
263263
}
264264
}

0 commit comments

Comments
 (0)