fix(review): clarify resolved thread fallback (#33)

Author: 777genius

__tests__/unit/github/review-thread-resolver.test.ts

@@ -332,6 +332,12 @@ describe('ReviewThreadResolver', () => {
     expect(createReplyForReviewComment.mock.calls[0][0].body).toContain(
       'reviewrouter-lifecycle-resolution:v1'
     );
+    expect(createReplyForReviewComment.mock.calls[0][0].body).toContain(
+      '**Resolved ✅ ✅ ✅**\n\n<sub>ReviewRouter rechecked this finding'
+    );
+    expect(createReplyForReviewComment.mock.calls[0][0].body).toContain(
+      'a maintainer can click Resolve conversation.</sub>'
+    );
   });
 
   it('reports when the resolution fallback reply could not be posted', async () => {

dist/index.js

@@ -27877,7 +27877,9 @@ function renderResolutionFallbackComment(candidate) {
   return [
     `<!-- ${RESOLUTION_REPLY_MARKER} target_id=${candidate.target.targetId} fingerprint=${candidate.target.fingerprint} -->`,
     "",
-    "ReviewRouter rechecked this finding and the provider quorum marked it resolved. GitHub did not allow the app token to close this review thread automatically, so a maintainer can mark the conversation resolved manually."
+    "**Resolved \u2705 \u2705 \u2705**",
+    "",
+    "<sub>ReviewRouter rechecked this finding and the provider quorum marked it resolved. GitHub did not allow the app token to close this review thread automatically, so a maintainer can click Resolve conversation.</sub>"
   ].join("\n");
 }
 function mapBackendReasonCodes(reasonCodes, fallback2 = []) {

dist/index.js.map

@@ -654,7 +654,9 @@ function renderResolutionFallbackComment(
   return [
     `<!-- ${RESOLUTION_REPLY_MARKER} target_id=${candidate.target.targetId} fingerprint=${candidate.target.fingerprint} -->`,
     '',
-    'ReviewRouter rechecked this finding and the provider quorum marked it resolved. GitHub did not allow the app token to close this review thread automatically, so a maintainer can mark the conversation resolved manually.',
+    '**Resolved ✅ ✅ ✅**',
+    '',
+    '<sub>ReviewRouter rechecked this finding and the provider quorum marked it resolved. GitHub did not allow the app token to close this review thread automatically, so a maintainer can click Resolve conversation.</sub>',
   ].join('\n');
 }