fix(investigation): refine oversized context searches

Author: 777genius

__tests__/unit/context-gateway/filesystem-context-gateway-v4.test.ts

@@ -233,6 +233,40 @@ describe('FilesystemContextGatewayV4', () => {
     }
   });
 
+  it('rejects searches spanning more relation paths than deterministic expansion can represent', async () => {
+    const fixture = await createWideSearchFixture();
+    try {
+      const { gateway, recorder, replayMaterial } =
+        await createGateway(fixture);
+
+      await expect(
+        gateway.searchText({ query: 'WIDE_RELATION_CANARY', paths: ['.'] })
+      ).rejects.toThrow('context_gateway_relation_path_limit_exceeded');
+
+      expect(recorder.snapshot()).toMatchObject({
+        confinementTainted: false,
+        events: [
+          expect.objectContaining({
+            outcome: 'rejected',
+            failureClass: 'budget_exceeded',
+            operationReceiptId: null,
+            sanitizedReason: 'context_gateway_relation_path_limit_exceeded',
+          }),
+        ],
+      });
+      expect(replayMaterial.snapshot().entries).toHaveLength(0);
+
+      await expect(
+        gateway.searchText({
+          query: 'SENSITIVE_QUERY_CANARY',
+          paths: ['src'],
+        })
+      ).resolves.toMatchObject({ complete: true });
+    } finally {
+      await rm(fixture.parent, { recursive: true, force: true });
+    }
+  });
+
   it('canonicalizes safe virtual-root aliases without duplicating evidence', async () => {
     const fixture = await createFixture();
     try {
@@ -492,6 +526,30 @@ async function createFixture() {
   return { parent, root, mergeBaseSha, headSha, headTreeOid };
 }
 
+async function createWideSearchFixture() {
+  const fixture = await createFixture();
+  await Promise.all(
+    Array.from({ length: 513 }, async (_, index) => {
+      await writeFile(
+        path.join(
+          fixture.root,
+          'docs',
+          `wide-${String(index).padStart(3, '0')}.md`
+        ),
+        'WIDE_RELATION_CANARY\n'
+      );
+    })
+  );
+  await git(fixture.root, ['add', '.']);
+  await git(fixture.root, ['commit', '-qm', 'wide relation fixture']);
+  const headSha = await gitText(fixture.root, ['rev-parse', 'HEAD']);
+  const headTreeOid = await gitText(fixture.root, [
+    'rev-parse',
+    `${headSha}^{tree}`,
+  ]);
+  return { ...fixture, headSha, headTreeOid };
+}
+
 async function initializeRepo(root: string) {
   await git(root, ['init', '-q']);
   await git(root, ['config', 'user.name', 'ReviewRouter Test']);

__tests__/unit/review-orchestration/review-investigation-recording-adapter.test.ts

@@ -237,6 +237,8 @@ describe('ReviewInvestigationRecordingAdapter', () => {
       expect(prompt).toContain(
         'Never bind an exploratory search to a deterministic_expansion obligation'
       );
+      expect(prompt).toContain('context_gateway_relation_path_limit_exceeded');
+      expect(prompt).toContain('at most 512 files');
       expect(prompt).toContain('provider-neutral obligationProposals entry');
       expect(prompt).toContain(
         'exactly kind, canonicalSubject, canonicalRequirement, and riskPriority'

dist/context-gateway.js

@@ -14111,6 +14111,7 @@ var import_crypto2 = require("crypto");
 var CONTEXT_GATEWAY_V4_POLICY_VERSION = "context-gateway-v4";
 var CONTEXT_GATEWAY_V4_CURSOR_VERSION = 1;
 var CONTEXT_GATEWAY_V4_PAGE_MAX_ITEMS = 2e3;
+var CONTEXT_GATEWAY_V4_RELATION_PATH_MAX_ITEMS = 512;
 var CONTEXT_GATEWAY_V4_CURSOR_MAX_LIFETIME_MS = 15 * 60 * 1e3;
 var CONTEXT_GATEWAY_V4_ENABLED_TOOLS = Object.freeze([
   "review_read_file",
@@ -14309,10 +14310,10 @@ var review_investigation_capability_v1_golden_default = {
       probePolicyVersion: "review-investigation-probe-policy.v2",
       runtimeProfileVersion: "gateway-attested-agent.v1",
       searchPolicyVersion: "review-investigation-fixed-string-search.v1",
-      turnPromptContractHash: "41ad2e193eb96dfe8d091a76051652d4db4eb90a48560a33d07b31ef7f46b3d0"
+      turnPromptContractHash: "87996321aa77575ce5c434a555d238c57fe319cd4131b8cac412c9fa6bf08feb"
     },
-    canonicalJson: '{"coverageContractVersion":"review-investigation-coverage.v1","criticPolicyVersion":"review-investigation-critic.v2","expansionRulesVersion":"review-investigation-expansion.v3","gatewayPolicyVersion":"context-gateway-v4","probePolicyVersion":"review-investigation-probe-policy.v2","runtimeProfileVersion":"gateway-attested-agent.v1","searchPolicyVersion":"review-investigation-fixed-string-search.v1","turnPromptContractHash":"41ad2e193eb96dfe8d091a76051652d4db4eb90a48560a33d07b31ef7f46b3d0"}',
-    sha256: "a5e7cec2158b3c8ef91e51f633e51e43287c2e50deb572716f63d7007d978407"
+    canonicalJson: '{"coverageContractVersion":"review-investigation-coverage.v1","criticPolicyVersion":"review-investigation-critic.v2","expansionRulesVersion":"review-investigation-expansion.v3","gatewayPolicyVersion":"context-gateway-v4","probePolicyVersion":"review-investigation-probe-policy.v2","runtimeProfileVersion":"gateway-attested-agent.v1","searchPolicyVersion":"review-investigation-fixed-string-search.v1","turnPromptContractHash":"87996321aa77575ce5c434a555d238c57fe319cd4131b8cac412c9fa6bf08feb"}',
+    sha256: "064b245d9ac5b710a70ec2e3c1efdefa8f5b2de0efd73332a413f846c08783db"
   },
   policy: {
     value: {
@@ -16648,6 +16649,9 @@ var FilesystemContextGatewayV4 = class _FilesystemContextGatewayV4 {
       )).map(
         (value) => value.startsWith(`${revisionSha}:`) ? value.slice(revisionSha.length + 1) : value
       ).sort();
+      if (matchedPaths.length > CONTEXT_GATEWAY_V4_RELATION_PATH_MAX_ITEMS) {
+        throw new Error("context_gateway_relation_path_limit_exceeded");
+      }
       return this.pageResult({
         operationKind: "text_search" /* TextSearch */,
         treeOid,

dist/context-gateway.release.json

@@ -1,11 +1,11 @@
 {
   "artifactKind": "reviewrouter-context-gateway",
-  "contextGatewayEntrypointDigest": "fee4fc416bed1632381f560a5504017edbf91f311d82e71df387a2407ed67e23",
+  "contextGatewayEntrypointDigest": "adc0c03552313c3bd9cd2060b454f91e8ae706d7c693477ebb6b36f09aa13630",
   "contextGatewayEntrypointPath": "dist/context-gateway.js",
   "contextGatewayPolicyVersion": "context-gateway-v4",
   "metadataVersion": 2,
   "reviewInvestigationCapability": "review_investigation_v1",
-  "reviewInvestigationCoverageProfileHash": "a5e7cec2158b3c8ef91e51f633e51e43287c2e50deb572716f63d7007d978407",
+  "reviewInvestigationCoverageProfileHash": "064b245d9ac5b710a70ec2e3c1efdefa8f5b2de0efd73332a413f846c08783db",
   "reviewInvestigationPolicyHash": "6af1a3ecea3cb01f8a0e1cea614c8578c6bc7e4010db13603c114757291af698",
   "supportedContextGatewayPolicyVersions": [
     "context-gateway-v3",

dist/index.js

@@ -22141,6 +22141,7 @@ var import_crypto2 = require("crypto");
 var CONTEXT_GATEWAY_V4_POLICY_VERSION = "context-gateway-v4";
 var CONTEXT_GATEWAY_V4_CURSOR_VERSION = 1;
 var CONTEXT_GATEWAY_V4_PAGE_MAX_ITEMS = 2e3;
+var CONTEXT_GATEWAY_V4_RELATION_PATH_MAX_ITEMS = 512;
 var CONTEXT_GATEWAY_V4_CURSOR_MAX_LIFETIME_MS = 15 * 60 * 1e3;
 var CONTEXT_GATEWAY_V4_ENABLED_TOOLS = Object.freeze([
   "review_read_file",
@@ -95141,10 +95142,10 @@ var review_investigation_capability_v1_golden_default = {
       probePolicyVersion: "review-investigation-probe-policy.v2",
       runtimeProfileVersion: "gateway-attested-agent.v1",
       searchPolicyVersion: "review-investigation-fixed-string-search.v1",
-      turnPromptContractHash: "41ad2e193eb96dfe8d091a76051652d4db4eb90a48560a33d07b31ef7f46b3d0"
+      turnPromptContractHash: "87996321aa77575ce5c434a555d238c57fe319cd4131b8cac412c9fa6bf08feb"
     },
-    canonicalJson: '{"coverageContractVersion":"review-investigation-coverage.v1","criticPolicyVersion":"review-investigation-critic.v2","expansionRulesVersion":"review-investigation-expansion.v3","gatewayPolicyVersion":"context-gateway-v4","probePolicyVersion":"review-investigation-probe-policy.v2","runtimeProfileVersion":"gateway-attested-agent.v1","searchPolicyVersion":"review-investigation-fixed-string-search.v1","turnPromptContractHash":"41ad2e193eb96dfe8d091a76051652d4db4eb90a48560a33d07b31ef7f46b3d0"}',
-    sha256: "a5e7cec2158b3c8ef91e51f633e51e43287c2e50deb572716f63d7007d978407"
+    canonicalJson: '{"coverageContractVersion":"review-investigation-coverage.v1","criticPolicyVersion":"review-investigation-critic.v2","expansionRulesVersion":"review-investigation-expansion.v3","gatewayPolicyVersion":"context-gateway-v4","probePolicyVersion":"review-investigation-probe-policy.v2","runtimeProfileVersion":"gateway-attested-agent.v1","searchPolicyVersion":"review-investigation-fixed-string-search.v1","turnPromptContractHash":"87996321aa77575ce5c434a555d238c57fe319cd4131b8cac412c9fa6bf08feb"}',
+    sha256: "064b245d9ac5b710a70ec2e3c1efdefa8f5b2de0efd73332a413f846c08783db"
   },
   policy: {
     value: {
@@ -99251,14 +99252,15 @@ function compareCodeUnits3(left, right) {
 }
 
 // src/review-investigation/application/review-investigation-turn-prompt.ts
-var REVIEW_INVESTIGATION_TURN_PROMPT_CONTRACT = "review_investigation_turn_prompt.v2";
+var REVIEW_INVESTIGATION_TURN_PROMPT_CONTRACT = "review_investigation_turn_prompt.v3";
 var TURN_INSTRUCTIONS = Object.freeze([
   "REVIEW INVESTIGATION TURN CONTRACT:",
   "Use only the reviewrouter Context Gateway tools. Investigate every obligation in the authenticated turn brief.",
   'For typed search requirements, execute the exact literal query with paths=["."], revision="head", caseSensitive=true, and pageSize=500, then follow every cursor to completion.',
   "For a typed complete_page_chain obligation, put its complete receipt chain in closureClaims only. The control plane derives its discovery evidence; do not duplicate that chain in operationBackedDiscoveryClaims.",
   "For a typed complete_relation_context obligation, rerun its hydrated query and include the complete matching text_search receipt chain plus complete file_read receipts for exactly every requiredPathHashes entry. Never include unrelated search or directory receipts.",
   "During discovery turns, use operationBackedDiscoveryClaims only for additional exploratory text-search chains. Bind each chain to the coverage_contract changed_content obligation that directly motivated the search, copy the exact query passed to the tool, and include every operationReceiptId from the chain.",
+  "If an exploratory text search reports context_gateway_relation_path_limit_exceeded, do not claim that rejected search. Narrow the literal query and/or paths until each accepted search covers at most 512 files, or leave the related obligation open when no sound bounded query exists.",
   "Never bind an exploratory search to a deterministic_expansion obligation. If no changed_content source directly motivated it, omit the advisory discovery claim and leave related obligations open.",
   "When inspected evidence reveals additional review scope, add a provider-neutral obligationProposals entry instead of silently broadening an existing obligation.",
   "Each obligation proposal must contain exactly kind, canonicalSubject, canonicalRequirement, and riskPriority. Use only schema-listed kinds; never provide an obligation ID, state, authority decision, or receipt claim.",
@@ -102728,6 +102730,9 @@ var FilesystemContextGatewayV4 = class _FilesystemContextGatewayV4 {
       )).map(
         (value) => value.startsWith(`${revisionSha}:`) ? value.slice(revisionSha.length + 1) : value
       ).sort();
+      if (matchedPaths.length > CONTEXT_GATEWAY_V4_RELATION_PATH_MAX_ITEMS) {
+        throw new Error("context_gateway_relation_path_limit_exceeded");
+      }
       return this.pageResult({
         operationKind: "text_search" /* TextSearch */,
         treeOid,

dist/index.js.map

@@ -10,6 +10,7 @@ import {
 export const CONTEXT_GATEWAY_V4_POLICY_VERSION = 'context-gateway-v4' as const;
 export const CONTEXT_GATEWAY_V4_CURSOR_VERSION = 1 as const;
 export const CONTEXT_GATEWAY_V4_PAGE_MAX_ITEMS = 2_000;
+export const CONTEXT_GATEWAY_V4_RELATION_PATH_MAX_ITEMS = 512;
 export const CONTEXT_GATEWAY_V4_CURSOR_MAX_LIFETIME_MS = 15 * 60 * 1_000;
 export const CONTEXT_GATEWAY_V4_ENABLED_TOOLS = Object.freeze([
   'review_read_file',

src/context-gateway/context-gateway-v4-contract.ts

@@ -15,6 +15,7 @@ import {
 import {
   CONTEXT_GATEWAY_V4_POLICY_VERSION,
   CONTEXT_GATEWAY_V4_PAGE_MAX_ITEMS,
+  CONTEXT_GATEWAY_V4_RELATION_PATH_MAX_ITEMS,
   ContextGatewayV4OperationKind,
   ContextGatewayV4Revision,
   ContextOperationFailureClass,
@@ -411,6 +412,9 @@ export class FilesystemContextGatewayV4 {
             : value
         )
         .sort();
+      if (matchedPaths.length > CONTEXT_GATEWAY_V4_RELATION_PATH_MAX_ITEMS) {
+        throw new Error('context_gateway_relation_path_limit_exceeded');
+      }
       return this.pageResult({
         operationKind: ContextGatewayV4OperationKind.TextSearch,
         treeOid,

src/context-gateway/filesystem-context-gateway-v4.ts

@@ -2,7 +2,7 @@ import type { ReviewInvestigationTurnBrief } from '../domain/investigation-state
 import { canonicalJson, sha256 } from '../domain/canonical-json';
 
 export const REVIEW_INVESTIGATION_TURN_PROMPT_CONTRACT =
-  'review_investigation_turn_prompt.v2' as const;
+  'review_investigation_turn_prompt.v3' as const;
 
 const TURN_INSTRUCTIONS = Object.freeze([
   'REVIEW INVESTIGATION TURN CONTRACT:',
@@ -11,6 +11,7 @@ const TURN_INSTRUCTIONS = Object.freeze([
   'For a typed complete_page_chain obligation, put its complete receipt chain in closureClaims only. The control plane derives its discovery evidence; do not duplicate that chain in operationBackedDiscoveryClaims.',
   'For a typed complete_relation_context obligation, rerun its hydrated query and include the complete matching text_search receipt chain plus complete file_read receipts for exactly every requiredPathHashes entry. Never include unrelated search or directory receipts.',
   'During discovery turns, use operationBackedDiscoveryClaims only for additional exploratory text-search chains. Bind each chain to the coverage_contract changed_content obligation that directly motivated the search, copy the exact query passed to the tool, and include every operationReceiptId from the chain.',
+  'If an exploratory text search reports context_gateway_relation_path_limit_exceeded, do not claim that rejected search. Narrow the literal query and/or paths until each accepted search covers at most 512 files, or leave the related obligation open when no sound bounded query exists.',
   'Never bind an exploratory search to a deterministic_expansion obligation. If no changed_content source directly motivated it, omit the advisory discovery claim and leave related obligations open.',
   'When inspected evidence reveals additional review scope, add a provider-neutral obligationProposals entry instead of silently broadening an existing obligation.',
   'Each obligation proposal must contain exactly kind, canonicalSubject, canonicalRequirement, and riskPriority. Use only schema-listed kinds; never provide an obligation ID, state, authority decision, or receipt claim.',

src/review-investigation/application/review-investigation-turn-prompt.ts

@@ -8,10 +8,10 @@
       "probePolicyVersion": "review-investigation-probe-policy.v2",
       "runtimeProfileVersion": "gateway-attested-agent.v1",
       "searchPolicyVersion": "review-investigation-fixed-string-search.v1",
-      "turnPromptContractHash": "41ad2e193eb96dfe8d091a76051652d4db4eb90a48560a33d07b31ef7f46b3d0"
+      "turnPromptContractHash": "87996321aa77575ce5c434a555d238c57fe319cd4131b8cac412c9fa6bf08feb"
     },
-    "canonicalJson": "{\"coverageContractVersion\":\"review-investigation-coverage.v1\",\"criticPolicyVersion\":\"review-investigation-critic.v2\",\"expansionRulesVersion\":\"review-investigation-expansion.v3\",\"gatewayPolicyVersion\":\"context-gateway-v4\",\"probePolicyVersion\":\"review-investigation-probe-policy.v2\",\"runtimeProfileVersion\":\"gateway-attested-agent.v1\",\"searchPolicyVersion\":\"review-investigation-fixed-string-search.v1\",\"turnPromptContractHash\":\"41ad2e193eb96dfe8d091a76051652d4db4eb90a48560a33d07b31ef7f46b3d0\"}",
-    "sha256": "a5e7cec2158b3c8ef91e51f633e51e43287c2e50deb572716f63d7007d978407"
+    "canonicalJson": "{\"coverageContractVersion\":\"review-investigation-coverage.v1\",\"criticPolicyVersion\":\"review-investigation-critic.v2\",\"expansionRulesVersion\":\"review-investigation-expansion.v3\",\"gatewayPolicyVersion\":\"context-gateway-v4\",\"probePolicyVersion\":\"review-investigation-probe-policy.v2\",\"runtimeProfileVersion\":\"gateway-attested-agent.v1\",\"searchPolicyVersion\":\"review-investigation-fixed-string-search.v1\",\"turnPromptContractHash\":\"87996321aa77575ce5c434a555d238c57fe319cd4131b8cac412c9fa6bf08feb\"}",
+    "sha256": "064b245d9ac5b710a70ec2e3c1efdefa8f5b2de0efd73332a413f846c08783db"
   },
   "policy": {
     "value": {