Merge pull request #37 from 777genius/fix/review-v2-live-lifecycle

fix(review): preserve lifecycle targets in partial projections

Author: 777genius

__tests__/unit/review-projection/build-current-review-projection.test.ts

@@ -300,7 +300,14 @@ describe('BuildCurrentReviewProjection', () => {
       CheckConclusion.Neutral
     );
     expect(result.envelope.publishing.inlineReviewChunks).toEqual([]);
-    expect(result.envelope.publishing.lifecycle).toEqual([]);
+    expect(result.envelope.publishing.lifecycle).toEqual([
+      expect.objectContaining({
+        targetId: 'target-1',
+        threadId: 'thread-1',
+        mutationEligible: false,
+        reasonCodes: expect.arrayContaining(['partial_coverage']),
+      }),
+    ]);
     expect(result.envelope.snapshot).toEqual({
       occurrenceProvenance: [],
       lineageHints: [],

src/review-projection/application/build-current-review-projection.ts

@@ -160,15 +160,17 @@ export class BuildCurrentReviewProjection {
     const coverageOnly = coverage.state === ProjectionCoverageState.Partial;
     const allClear =
       !coverageOnly && canClaimAllClear(coverage, inventory, occurrences, gate);
-    const lifecycleFacts = coverageOnly
-      ? []
-      : buildLifecycleFacts(
-          inventory,
-          lifecycleDecisions,
-          command.priorLineageHints,
-          coverage,
-          occurrences
-        );
+    // Preserve target identities even for partial coverage so the control plane
+    // can prove that live lifecycle state is still the state this projection saw.
+    // buildLifecycleFacts already makes every partial-coverage target ineligible
+    // for mutation.
+    const lifecycleFacts = buildLifecycleFacts(
+      inventory,
+      lifecycleDecisions,
+      command.priorLineageHints,
+      coverage,
+      occurrences
+    );
     const inlineChunks = coverageOnly
       ? []
       : buildInlineChunks(occurrences, this.limits);
@@ -476,7 +478,7 @@ function buildInlineChunks(
 
   assertWithinProjectionLimit('maxInlineComments', comments.length, limits);
   const chunks: ReviewProjectionInlineChunkFact[] = [];
-  for (let offset = 0; offset < comments.length; ) {
+  for (let offset = 0; offset < comments.length;) {
     const chunkComments = comments.slice(
       offset,
       offset + limits.maxInlineCommentsPerChunk