Skip to content

Commit c3e488e

Browse files
committed
Iot: Use English description
1 parent 425f46d commit c3e488e

File tree

4 files changed

+18
-18
lines changed

4 files changed

+18
-18
lines changed

main/iot/things/battery.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,16 @@ class Battery : public Thing {
1515
bool discharging_ = false;
1616

1717
public:
18-
Battery() : Thing("Battery", "电池管理") {
18+
Battery() : Thing("Battery", "The battery of the device") {
1919
// 定义设备的属性
20-
properties_.AddNumberProperty("level", "当前电量百分比", [this]() -> int {
20+
properties_.AddNumberProperty("level", "Current battery level", [this]() -> int {
2121
auto& board = Board::GetInstance();
2222
if (board.GetBatteryLevel(level_, charging_, discharging_)) {
2323
return level_;
2424
}
2525
return 0;
2626
});
27-
properties_.AddBooleanProperty("charging", "是否充电中", [this]() -> int {
27+
properties_.AddBooleanProperty("charging", "Whether the battery is charging", [this]() -> int {
2828
return charging_;
2929
});
3030
}

main/iot/things/lamp.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,21 +32,21 @@ class Lamp : public Thing {
3232
}
3333

3434
public:
35-
Lamp() : Thing("Lamp", "一个测试用的灯"), power_(false) {
35+
Lamp() : Thing("Lamp", "A test lamp"), power_(false) {
3636
InitializeGpio();
3737

3838
// 定义设备的属性
39-
properties_.AddBooleanProperty("power", "灯是否打开", [this]() -> bool {
39+
properties_.AddBooleanProperty("power", "Whether the lamp is on", [this]() -> bool {
4040
return power_;
4141
});
4242

4343
// 定义设备可以被远程执行的指令
44-
methods_.AddMethod("TurnOn", "打开灯", ParameterList(), [this](const ParameterList& parameters) {
44+
methods_.AddMethod("turn_on", "Turn on the lamp", ParameterList(), [this](const ParameterList& parameters) {
4545
power_ = true;
4646
gpio_set_level(gpio_num_, 1);
4747
});
4848

49-
methods_.AddMethod("TurnOff", "关闭灯", ParameterList(), [this](const ParameterList& parameters) {
49+
methods_.AddMethod("turn_off", "Turn off the lamp", ParameterList(), [this](const ParameterList& parameters) {
5050
power_ = false;
5151
gpio_set_level(gpio_num_, 0);
5252
});

main/iot/things/screen.cc

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,22 +13,22 @@ namespace iot {
1313
// 这里仅定义 Screen 的属性和方法,不包含具体的实现
1414
class Screen : public Thing {
1515
public:
16-
Screen() : Thing("Screen", "这是一个屏幕,可设置主题和亮度") {
16+
Screen() : Thing("Screen", "A screen that can set theme and brightness") {
1717
// 定义设备的属性
18-
properties_.AddStringProperty("theme", "主题", [this]() -> std::string {
18+
properties_.AddStringProperty("theme", "Current theme", [this]() -> std::string {
1919
auto theme = Board::GetInstance().GetDisplay()->GetTheme();
2020
return theme;
2121
});
2222

23-
properties_.AddNumberProperty("brightness", "当前亮度百分比", [this]() -> int {
23+
properties_.AddNumberProperty("brightness", "Current brightness percentage", [this]() -> int {
2424
// 这里可以添加获取当前亮度的逻辑
2525
auto backlight = Board::GetInstance().GetBacklight();
2626
return backlight ? backlight->brightness() : 100;
2727
});
2828

2929
// 定义设备可以被远程执行的指令
30-
methods_.AddMethod("SetTheme", "设置屏幕主题", ParameterList({
31-
Parameter("theme_name", "主题模式, lightdark", kValueTypeString, true)
30+
methods_.AddMethod("set_theme", "Set the screen theme", ParameterList({
31+
Parameter("theme_name", "Valid string values are \"light\" and \"dark\"", kValueTypeString, true)
3232
}), [this](const ParameterList& parameters) {
3333
std::string theme_name = static_cast<std::string>(parameters["theme_name"].string());
3434
auto display = Board::GetInstance().GetDisplay();
@@ -37,8 +37,8 @@ class Screen : public Thing {
3737
}
3838
});
3939

40-
methods_.AddMethod("SetBrightness", "设置亮度", ParameterList({
41-
Parameter("brightness", "0到100之间的整数", kValueTypeNumber, true)
40+
methods_.AddMethod("set_brightness", "Set the brightness", ParameterList({
41+
Parameter("brightness", "An integer between 0 and 100", kValueTypeNumber, true)
4242
}), [this](const ParameterList& parameters) {
4343
uint8_t brightness = static_cast<uint8_t>(parameters["brightness"].number());
4444
auto backlight = Board::GetInstance().GetBacklight();

main/iot/things/speaker.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,16 @@ namespace iot {
1111
// 这里仅定义 Speaker 的属性和方法,不包含具体的实现
1212
class Speaker : public Thing {
1313
public:
14-
Speaker() : Thing("Speaker", "扬声器") {
14+
Speaker() : Thing("AudioSpeaker", "The audio speaker of the device") {
1515
// 定义设备的属性
16-
properties_.AddNumberProperty("volume", "当前音量值", [this]() -> int {
16+
properties_.AddNumberProperty("volume", "Current audio volume value", [this]() -> int {
1717
auto codec = Board::GetInstance().GetAudioCodec();
1818
return codec->output_volume();
1919
});
2020

2121
// 定义设备可以被远程执行的指令
22-
methods_.AddMethod("SetVolume", "设置音量", ParameterList({
23-
Parameter("volume", "0到100之间的整数", kValueTypeNumber, true)
22+
methods_.AddMethod("set_volume", "Set the audio volume", ParameterList({
23+
Parameter("volume", "An integer between 0 and 100", kValueTypeNumber, true)
2424
}), [this](const ParameterList& parameters) {
2525
auto codec = Board::GetInstance().GetAudioCodec();
2626
codec->SetOutputVolume(static_cast<uint8_t>(parameters["volume"].number()));

0 commit comments

Comments
 (0)