refactor: comprehensive codebase improvements for v2.8.0

- Extract CheckOptions struct with clap::Args to eliminate parameter explosion
- Split cmd_check (310 lines) into 5 focused functions
- Split scanner.rs (1148 lines) into scanner/{mod,report,network}.rs
- Create shared lockfile/platform.rs to unify duplicated platform parsing
- Encapsulate parser state into SourceState struct with methods
- Migrate deprecated serde_yaml to serde_yml
- Fix Database::open().unwrap() panic with proper error propagation
- Extract check_staleness/build_ignore_comments to src/check.rs for testability
- Replace .ok() with io::Result<()> in format output (text.rs, json.rs)
- Handle broken pipe gracefully in CLI output
- Add tempfile crate for reliable test cleanup
- Add Clone derive to FixSuggestion
- Add 13 new unit tests (307 → 320)

Author: 7a6163

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "gem-audit"
-version = "2.7.0"
+version = "2.8.0"
 edition = "2024"
 description = "Ultra-fast, standalone security auditor for Gemfile.lock"
 license = "MIT"
@@ -14,9 +14,10 @@ clap = { version = "4", features = ["derive"] }
 gix = { version = "0.80", default-features = false, features = ["blocking-network-client", "blocking-http-transport-reqwest-rust-tls", "worktree-mutation"] }
 serde = { version = "1", features = ["derive"] }
 serde_json = "1"
-serde_yaml = "0.9"
+serde_yml = "0.0.12"
 thiserror = "2"
 
 [dev-dependencies]
 assert_cmd = "2"
 predicates = "3"
+tempfile = "3"

Cargo.toml

@@ -1,3 +1,8 @@
+comment:
+  layout: "reach,diff,flags,files"
+  behavior: default
+  require_changes: false
+
 coverage:
   status:
     project:

codecov.yml

@@ -464,9 +464,9 @@ mod tests {
 
     #[test]
     fn open_fixture_advisory_dir() {
-        let (db_dir, _) = temp_mock_db("fixture");
+        let (tmp, _) = temp_mock_db("fixture");
 
-        let db = Database::open(&db_dir).unwrap();
+        let db = Database::open(tmp.path()).unwrap();
         assert!(!db.is_git());
 
         let advisories = db.advisories_for("test");
@@ -480,8 +480,6 @@ mod tests {
         // Check patched version
         let (vulns, _errors) = db.check_gem("test", &Version::parse("1.0.0").unwrap());
         assert!(vulns.is_empty());
-
-        std::fs::remove_dir_all(&db_dir).unwrap();
     }
 
     // ========== Error Cases ==========
@@ -505,60 +503,55 @@ mod tests {
 
     // Helper: create an isolated temporary mock DB for tests that don't
     // share state with `mock_database()` in scanner tests.
-    fn temp_mock_db(suffix: &str) -> (PathBuf, PathBuf) {
+    fn temp_mock_db(_suffix: &str) -> (tempfile::TempDir, PathBuf) {
         let fixture_dir = PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("tests/fixtures");
-        let db_dir = std::env::temp_dir().join(format!("gem_audit_db_test_{}", suffix));
-        let _ = std::fs::remove_dir_all(&db_dir);
-        let gem_dir = db_dir.join("gems").join("test");
+        let tmp = tempfile::tempdir().unwrap();
+        let gem_dir = tmp.path().join("gems").join("test");
         std::fs::create_dir_all(&gem_dir).unwrap();
         std::fs::copy(
             fixture_dir.join("advisory/CVE-2020-1234.yml"),
             gem_dir.join("CVE-2020-1234.yml"),
         )
         .unwrap();
-        (db_dir, fixture_dir)
+        (tmp, fixture_dir)
     }
 
     // ========== Database Display ==========
 
     #[test]
     fn database_display() {
-        let (db_dir, _) = temp_mock_db("display");
-        let db = Database::open(&db_dir).unwrap();
+        let (tmp, _) = temp_mock_db("display");
+        let db = Database::open(tmp.path()).unwrap();
         let display = db.to_string();
-        assert!(display.contains("gem_audit_db_test_display"));
-        std::fs::remove_dir_all(&db_dir).unwrap();
+        assert_eq!(display, tmp.path().to_string_lossy());
     }
 
     // ========== Database exists/path ==========
 
     #[test]
     fn database_exists_with_gems() {
-        let (db_dir, _) = temp_mock_db("exists");
-        let db = Database::open(&db_dir).unwrap();
+        let (tmp, _) = temp_mock_db("exists");
+        let db = Database::open(tmp.path()).unwrap();
         assert!(db.exists());
-        assert!(db.path() == db_dir.as_path());
-        std::fs::remove_dir_all(&db_dir).unwrap();
+        assert!(db.path() == tmp.path());
     }
 
     // ========== Database advisories/size with mock ==========
 
     #[test]
     fn database_advisories_with_mock() {
-        let (db_dir, _) = temp_mock_db("advisories");
-        let db = Database::open(&db_dir).unwrap();
+        let (tmp, _) = temp_mock_db("advisories");
+        let db = Database::open(tmp.path()).unwrap();
         let all = db.advisories();
         assert_eq!(all.len(), 1);
         assert_eq!(all[0].id, "CVE-2020-1234");
-        std::fs::remove_dir_all(&db_dir).unwrap();
     }
 
     #[test]
     fn database_size_with_mock() {
-        let (db_dir, _) = temp_mock_db("size");
-        let db = Database::open(&db_dir).unwrap();
+        let (tmp, _) = temp_mock_db("size");
+        let db = Database::open(tmp.path()).unwrap();
         assert_eq!(db.size(), 1);
-        std::fs::remove_dir_all(&db_dir).unwrap();
     }
 
     // ========== Ruby advisory methods ==========
@@ -613,11 +606,10 @@ mod tests {
 
     #[test]
     fn commit_id_none_for_non_git() {
-        let (db_dir, _) = temp_mock_db("nongit");
-        let db = Database::open(&db_dir).unwrap();
+        let (tmp, _) = temp_mock_db("nongit");
+        let db = Database::open(tmp.path()).unwrap();
         assert_eq!(db.commit_id(), None);
         assert_eq!(db.last_updated_at(), None);
-        std::fs::remove_dir_all(&db_dir).unwrap();
     }
 
     // ========== DatabaseError Display ==========

src/advisory/database.rs

@@ -111,7 +111,7 @@ pub enum AdvisoryError {
     #[error("IO error: {0}")]
     Io(#[from] std::io::Error),
     #[error("YAML parse error: {0}")]
-    Yaml(#[from] serde_yaml::Error),
+    Yaml(#[from] serde_yml::Error),
     #[error("invalid requirement '{version_str}': {error}")]
     InvalidRequirement { version_str: String, error: String },
     #[error("advisory {path} is missing both 'gem' and 'engine' fields")]
@@ -133,7 +133,7 @@ impl Advisory {
             .unwrap_or("unknown")
             .to_string();
 
-        let raw: AdvisoryYaml = serde_yaml::from_str(yaml)?;
+        let raw: AdvisoryYaml = serde_yml::from_str(yaml)?;
 
         let (name, kind) = match (raw.gem, raw.engine) {
             (Some(gem), _) => (gem, AdvisoryKind::Gem),
@@ -511,7 +511,7 @@ mod tests {
 
     #[test]
     fn advisory_error_yaml_display() {
-        let yaml_err = serde_yaml::from_str::<AdvisoryYaml>("not valid yaml {{{{").unwrap_err();
+        let yaml_err = serde_yml::from_str::<AdvisoryYaml>("not valid yaml {{{{").unwrap_err();
         let err = AdvisoryError::Yaml(yaml_err);
         assert!(err.to_string().contains("YAML parse error"));
     }