Fix javac warnings in core and plugins

Author: 8Keep

common.gradle

@@ -25,8 +25,9 @@ java {
 }
 
 tasks.withType(JavaCompile) { // compile-time options:
-    //options.compilerArgs << '-Xlint:deprecation' // to show deprecation warnings
+    options.compilerArgs << '-Xlint:deprecation'
     options.compilerArgs << '-Xlint:unchecked'
+    options.compilerArgs << '-Xlint:-options'
     options.encoding = 'UTF-8'
     options.release = 8
 }

jme3-core/src/main/java/com/jme3/effect/ParticleEmitter.java

@@ -187,6 +187,7 @@ public ParticleEmitter clone(boolean cloneMaterial) {
      *  The old clone() method that did not use the new Cloner utility.
      */
     @Override
+    @Deprecated
     public ParticleEmitter oldClone(boolean cloneMaterial) {
         ParticleEmitter clone = (ParticleEmitter) super.clone(cloneMaterial);
         clone.shape = shape.deepClone();

jme3-core/src/main/java/com/jme3/environment/EnvironmentCamera.java

@@ -309,7 +309,7 @@ protected void initialize(Application app) {
             viewports[i] = createOffViewPort("EnvView" + i, cameras[i]);
             framebuffers[i] = createOffScreenFrameBuffer(size, viewports[i]);
             textures[i] = new Texture2D(size, size, colorFormat);
-            framebuffers[i].setColorTexture(textures[i]);
+            framebuffers[i].addColorTarget(FrameBuffer.FrameBufferTarget.newTarget(textures[i]));
         }
     }
 
@@ -416,7 +416,7 @@ protected FrameBuffer createOffScreenFrameBuffer(int mapSize, ViewPort offView)
     protected FrameBuffer createOffScreenFrameBuffer(int mapSize, ViewPort offView, Image.Format depthFormat) {
         // create offscreen framebuffer
         final FrameBuffer offBuffer = new FrameBuffer(mapSize, mapSize, 1);
-        offBuffer.setDepthBuffer(depthFormat);
+        offBuffer.setDepthTarget(FrameBuffer.FrameBufferTarget.newTarget(depthFormat));
         offView.setOutputFrameBuffer(offBuffer);
         return offBuffer;
     }

jme3-core/src/main/java/com/jme3/environment/EnvironmentProbeControl.java

@@ -186,6 +186,7 @@ public static void untagGlobal(Spatial s) {
     }
 
     @Override
+    @Deprecated
     public Control cloneForSpatial(Spatial spatial) {
         throw new UnsupportedOperationException();
     }

jme3-core/src/main/java/com/jme3/renderer/Caps.java

@@ -648,7 +648,7 @@ public static boolean supports(Collection<Caps> caps, FrameBuffer fb) {
             return false;
         }
 
-        RenderBuffer depthBuf = fb.getDepthBuffer();
+        RenderBuffer depthBuf = fb.getDepthTarget();
         if (depthBuf != null) {
             Format depthFmt = depthBuf.getFormat();
             if (!depthFmt.isDepthFormat()) {
@@ -675,8 +675,8 @@ public static boolean supports(Collection<Caps> caps, FrameBuffer fb) {
                 }
             }
         }
-        for (int i = 0; i < fb.getNumColorBuffers(); i++) {
-            if (!supportsColorBuffer(caps, fb.getColorBuffer(i))) {
+        for (int i = 0; i < fb.getNumColorTargets(); i++) {
+            if (!supportsColorBuffer(caps, fb.getColorTarget(i))) {
                 return false;
             }
         }

jme3-core/src/main/java/com/jme3/renderer/RenderContext.java

@@ -45,6 +45,11 @@
  * internally to reduce state changes. NOTE: This class is specific to OpenGL.
  */
 public class RenderContext {
+    private static <T> WeakReference<T>[] newWeakReferenceArray(int size) {
+        WeakReference<T>[] refs = (WeakReference<T>[]) new WeakReference<?>[size];
+        return refs;
+    }
+
     /**
      * Number of texture units that JME supports.
      */
@@ -265,7 +270,7 @@ public class RenderContext {
      * @see Renderer#setTexture(int, com.jme3.texture.Texture)
      */
     public final WeakReference<Image> boundTextures[]
-            = new WeakReference[maxTextureUnits];
+            = newWeakReferenceArray(maxTextureUnits);
 
 
     /**
@@ -274,7 +279,7 @@ public class RenderContext {
      * @see Renderer#setUniformBufferObject(int, com.jme3.shader.BufferObject)
      * @see Renderer#setShaderStorageBufferObject(int, com.jme3.shader.BufferObject)
      */
-    public final WeakReference<BufferObject>[] boundBO = new WeakReference[maxBufferObjectUnits];
+    public final WeakReference<BufferObject>[] boundBO = newWeakReferenceArray(maxBufferObjectUnits);
 
     /**
      * IDList for texture units.
@@ -331,7 +336,7 @@ public class RenderContext {
      * Vertex attribs currently bound and enabled. If a slot is null, then
      * it is disabled.
      */
-    public final WeakReference<VertexBuffer>[] boundAttribs = new WeakReference[16];
+    public final WeakReference<VertexBuffer>[] boundAttribs = newWeakReferenceArray(16);
 
     /**
      * IDList for vertex attributes.

jme3-core/src/main/java/com/jme3/renderer/RenderManager.java

@@ -111,7 +111,7 @@ public class RenderManager {
     private final HashMap<Class<? extends PipelineContext>, PipelineContext> contexts = new HashMap<>();
     private final LinkedList<PipelineContext> usedContexts = new LinkedList<>();
     private final LinkedList<RenderPipeline<? extends PipelineContext>> usedPipelines = new LinkedList<>();
-    private RenderPipeline<? extends PipelineContext> defaultPipeline = new ForwardPipeline();
+    private RenderPipeline<? extends PipelineContext> defaultPipeline = new ForwardPipeline();
     private Camera prevCam = null;
     private Material forcedMaterial = null;
     private String forcedTechnique = null;
@@ -1382,19 +1382,22 @@ public void applyViewPort(ViewPort vp) {
      * @param vp View port to render
      * @param tpf Time per frame value
      */
-    public void renderViewPort(ViewPort vp, float tpf) {
-        if (!vp.isEnabled()) {
-            return;
-        }
-        RenderPipeline pipeline = vp.getPipeline();
-        if (pipeline == null) {
-            pipeline = defaultPipeline;
-        }
-
-        PipelineContext context = pipeline.fetchPipelineContext(this);
-        if (context == null) {
-            throw new NullPointerException("Failed to fetch pipeline context.");
-        }
+    public void renderViewPort(ViewPort vp, float tpf) {
+        if (!vp.isEnabled()) {
+            return;
+        }
+        RenderPipeline<? extends PipelineContext> pipeline = vp.getPipeline();
+        if (pipeline == null) {
+            pipeline = defaultPipeline;
+        }
+        renderViewPort(vp, tpf, pipeline);
+    }
+
+    private <T extends PipelineContext> void renderViewPort(ViewPort vp, float tpf, RenderPipeline<T> pipeline) {
+        T context = pipeline.fetchPipelineContext(this);
+        if (context == null) {
+            throw new NullPointerException("Failed to fetch pipeline context.");
+        }
         if (!context.startViewPortRender(this, vp)) {
             usedContexts.add(context);
         }

jme3-core/src/main/java/com/jme3/renderer/ViewPort.java

@@ -32,6 +32,7 @@
 package com.jme3.renderer;
 
 import com.jme3.renderer.pipeline.RenderPipeline;
+import com.jme3.renderer.pipeline.PipelineContext;
 import com.jme3.math.ColorRGBA;
 import com.jme3.post.SceneProcessor;
 import com.jme3.renderer.queue.RenderQueue;
@@ -88,7 +89,7 @@ public class ViewPort {
     /**
      * Dedicated pipeline.
      */
-    protected RenderPipeline pipeline;
+    protected RenderPipeline<? extends PipelineContext> pipeline;
     /**
      * FrameBuffer for output.
      */
@@ -440,7 +441,7 @@ public boolean isEnabled() {
      * 
      * @param pipeline pipeline, or null to use render manager's pipeline
      */
-    public void setPipeline(RenderPipeline pipeline) {
+    public void setPipeline(RenderPipeline<? extends PipelineContext> pipeline) {
         this.pipeline = pipeline;
     }
 
@@ -449,7 +450,7 @@ public void setPipeline(RenderPipeline pipeline) {
      * 
      * @return 
      */
-    public RenderPipeline getPipeline() {
+    public RenderPipeline<? extends PipelineContext> getPipeline() {
         return pipeline;
     }
 

jme3-core/src/main/java/com/jme3/renderer/opengl/GLRenderer.java

@@ -1956,6 +1956,7 @@ public void copyFrameBuffer(FrameBuffer src, FrameBuffer dst) {
     }
 
     @Override
+    @Deprecated
     public void copyFrameBuffer(FrameBuffer src, FrameBuffer dst, boolean copyDepth) {
         copyFrameBuffer(src, dst, true, copyDepth);
     }
@@ -2226,7 +2227,7 @@ private void toggleFramebufferSrgb(FrameBuffer fb) {
     }
 
     public void updateFrameBuffer(FrameBuffer fb) {
-        if (fb.getNumColorBuffers() == 0 && fb.getDepthBuffer() == null) {
+        if (fb.getNumColorTargets() == 0 && fb.getDepthTarget() == null) {
             throw new IllegalArgumentException("The framebuffer: " + fb
                     + "\nDoesn't have any color/depth buffers");
         }
@@ -2242,13 +2243,13 @@ public void updateFrameBuffer(FrameBuffer fb) {
 
         bindFrameBuffer(fb);
 
-        FrameBuffer.RenderBuffer depthBuf = fb.getDepthBuffer();
+        FrameBuffer.RenderBuffer depthBuf = fb.getDepthTarget();
         if (depthBuf != null) {
             updateFrameBufferAttachment(fb, depthBuf);
         }
 
-        for (int i = 0; i < fb.getNumColorBuffers(); i++) {
-            FrameBuffer.RenderBuffer colorBuf = fb.getColorBuffer(i);
+        for (int i = 0; i < fb.getNumColorTargets(); i++) {
+            FrameBuffer.RenderBuffer colorBuf = fb.getColorTarget(i);
             updateFrameBufferAttachment(fb, colorBuf);
         }
 
@@ -2309,13 +2310,13 @@ public void setReadDrawBuffers(FrameBuffer fb) {
 
         if (fb != null) {
 
-            if (fb.getNumColorBuffers() == 0) {
+            if (fb.getNumColorTargets() == 0) {
                 // make sure to select NONE as draw buf
                 // no color buffer attached.                
                 gl2.glDrawBuffer(GL.GL_NONE);             
                 gl2.glReadBuffer(GL.GL_NONE);                 
             } else {
-                if (fb.getNumColorBuffers() > limits.get(Limits.FrameBufferAttachments)) {
+                if (fb.getNumColorTargets() > limits.get(Limits.FrameBufferAttachments)) {
                     throw new RendererException("Framebuffer has more color "
                             + "attachments than are supported"
                             + " by the video hardware!");
@@ -2325,21 +2326,21 @@ public void setReadDrawBuffers(FrameBuffer fb) {
                         throw new RendererException("Multiple render targets "
                                 + " are not supported by the video hardware");
                     }
-                    if (fb.getNumColorBuffers() > limits.get(Limits.FrameBufferMrtAttachments)) {
+                    if (fb.getNumColorTargets() > limits.get(Limits.FrameBufferMrtAttachments)) {
                         throw new RendererException("Framebuffer has more"
                                 + " multi targets than are supported"
                                 + " by the video hardware!");
                     }
 
                     intBuf16.clear();
-                    for (int i = 0; i < fb.getNumColorBuffers(); i++) {
+                    for (int i = 0; i < fb.getNumColorTargets(); i++) {
                         intBuf16.put(GLFbo.GL_COLOR_ATTACHMENT0_EXT + i);
                     }
 
                     intBuf16.flip();
                     glext.glDrawBuffers(intBuf16);
                 } else {
-                    RenderBuffer rb = fb.getColorBuffer(fb.getTargetIndex());
+                    RenderBuffer rb = fb.getColorTarget(fb.getTargetIndex());
                     // select this draw buffer
                     gl2.glDrawBuffer(GLFbo.GL_COLOR_ATTACHMENT0_EXT + rb.getSlot());
                     // select this read buffer
@@ -2373,8 +2374,8 @@ public void setFrameBuffer(FrameBuffer fb) {
         if (boundFB != null && (boundFB.getMipMapsGenerationHint() != null
                 ? boundFB.getMipMapsGenerationHint()
                 : generateMipmapsForFramebuffers)) {
-            for (int i = 0; i < boundFB.getNumColorBuffers(); i++) {
-                RenderBuffer rb = boundFB.getColorBuffer(i);
+            for (int i = 0; i < boundFB.getNumColorTargets(); i++) {
+                RenderBuffer rb = boundFB.getColorTarget(i);
                 Texture tex = rb.getTexture();
                 if (tex != null && tex.getMinFilter().usesMipMapLevels()
                         && isMipmapGenerationSupported(tex.getImage().getFormat(),
@@ -2429,7 +2430,7 @@ public void readFrameBuffer(FrameBuffer fb, ByteBuffer byteBuf) {
 
     private void readFrameBufferWithGLFormat(FrameBuffer fb, ByteBuffer byteBuf, int glFormat, int dataType) {
         if (fb != null) {
-            RenderBuffer rb = fb.getColorBuffer();
+            RenderBuffer rb = fb.getColorTarget();
             if (rb == null) {
                 throw new IllegalArgumentException("Specified framebuffer"
                         + " does not have a colorbuffer");
@@ -2464,11 +2465,11 @@ public void deleteFrameBuffer(FrameBuffer fb) {
                 context.boundFBO = 0;
             }
 
-            if (fb.getDepthBuffer() != null) {
-                deleteRenderBuffer(fb, fb.getDepthBuffer());
+            if (fb.getDepthTarget() != null) {
+                deleteRenderBuffer(fb, fb.getDepthTarget());
             }
-            if (fb.getColorBuffer() != null) {
-                deleteRenderBuffer(fb, fb.getColorBuffer());
+            if (fb.getColorTarget() != null) {
+                deleteRenderBuffer(fb, fb.getColorTarget());
             }
 
             intBuf1.put(0, fb.getId());

jme3-core/src/main/java/com/jme3/renderer/pipeline/ForwardPipeline.java

@@ -46,7 +46,7 @@
  * 
  * @author codex
  */
-public class ForwardPipeline implements RenderPipeline {
+public class ForwardPipeline implements RenderPipeline<PipelineContext> {
 
     private boolean rendered = false;